@@ -15,11 +15,11 @@  | 
                                                    ||
| 15 | 15 | */  | 
                                                        
| 16 | 16 |  class Calendar extends AbstractCalendar { | 
                                                        
| 17 | 17 | |
| 18 | - /**  | 
                                                        |
| 19 | - * @param $units  | 
                                                        |
| 20 | - * @param $store  | 
                                                        |
| 21 | - * @param $default_value  | 
                                                        |
| 22 | - */  | 
                                                        |
| 18 | + /**  | 
                                                        |
| 19 | + * @param $units  | 
                                                        |
| 20 | + * @param $store  | 
                                                        |
| 21 | + * @param $default_value  | 
                                                        |
| 22 | + */  | 
                                                        |
| 23 | 23 |    public function __construct($units, $store, $default_value = 0) { | 
                                                        
| 24 | 24 | $this->units = $units;  | 
                                                        
| 25 | 25 | $this->store = $store;  | 
                                                        
@@ -126,8 +126,7 @@  | 
                                                    ||
| 126 | 126 | unset($this->included_set[$unit->getUnitId()]);  | 
                                                        
| 127 | 127 | $this->addMiss($unit, $reason, $constraint);  | 
                                                        
| 128 | 128 | return TRUE;  | 
                                                        
| 129 | - }  | 
                                                        |
| 130 | -    else { | 
                                                        |
| 129 | +    } else { | 
                                                        |
| 131 | 130 | return FALSE;  | 
                                                        
| 132 | 131 | }  | 
                                                        
| 133 | 132 | }  | 
                                                        
@@ -110,8 +110,7 @@ discard block  | 
                                                    ||
| 110 | 110 |        for ($i = 0; $i<=59; $i++) { | 
                                                        
| 111 | 111 |          if ($i <= 9) { | 
                                                        
| 112 | 112 | $index = 'm0'.$i;  | 
                                                        
| 113 | - }  | 
                                                        |
| 114 | -        else { | 
                                                        |
| 113 | +        } else { | 
                                                        |
| 115 | 114 | $index = 'm'.$i;  | 
                                                        
| 116 | 115 | }  | 
                                                        
| 117 | 116 | $db_events[$data['unit_id']][Event::BAT_MINUTE][$data['year']][$data['month']][$data['day']][$data['hour']][$index] = $data[$index];  | 
                                                        
@@ -190,8 +189,7 @@ discard block  | 
                                                    ||
| 190 | 189 | }  | 
                                                        
| 191 | 190 | }  | 
                                                        
| 192 | 191 | }  | 
                                                        
| 193 | - }  | 
                                                        |
| 194 | -    catch (\Exception $e) { | 
                                                        |
| 192 | +    } catch (\Exception $e) { | 
                                                        |
| 195 | 193 | $saved = FALSE;  | 
                                                        
| 196 | 194 | $transaction->rollback();  | 
                                                        
| 197 | 195 |        watchdog_exception('BAT Event Save Exception', $e); | 
                                                        
@@ -26,7 +26,7 @@ discard block  | 
                                                    ||
| 26 | 26 | */  | 
                                                        
| 27 | 27 |    public function getEventData(\DateTime $start_date, \DateTime $end_date, $unit_ids) { | 
                                                        
| 28 | 28 | |
| 29 | - $queries = $this->buildQueries($start_date, $end_date, $unit_ids);  | 
                                                        |
| 29 | + $queries = $this->buildQueries($start_date, $end_date, $unit_ids);  | 
                                                        |
| 30 | 30 | |
| 31 | 31 | $results = array();  | 
                                                        
| 32 | 32 | // Run each query and store results  | 
                                                        
@@ -37,30 +37,30 @@ discard block  | 
                                                    ||
| 37 | 37 | $db_events = array();  | 
                                                        
| 38 | 38 | |
| 39 | 39 | // Cycle through day results and setup an event array  | 
                                                        
| 40 | -    while( $data = $results[Event::BAT_DAY]->fetchAssoc()) { | 
                                                        |
| 40 | +    while ($data = $results[Event::BAT_DAY]->fetchAssoc()) { | 
                                                        |
| 41 | 41 | // Figure out how many days the current month has  | 
                                                        
| 42 | 42 | $temp_date = new \DateTime($data['year'] . "-" . $data['month']);  | 
                                                        
| 43 | 43 |        $days_in_month = (int)$temp_date->format('t'); | 
                                                        
| 44 | -      for ($i = 1; $i<=$days_in_month; $i++) { | 
                                                        |
| 45 | - $db_events[$data['unit_id']][Event::BAT_DAY][$data['year']][$data['month']]['d' . $i] = $data['d'.$i];  | 
                                                        |
| 44 | +      for ($i = 1; $i <= $days_in_month; $i++) { | 
                                                        |
| 45 | + $db_events[$data['unit_id']][Event::BAT_DAY][$data['year']][$data['month']]['d' . $i] = $data['d' . $i];  | 
                                                        |
| 46 | 46 | }  | 
                                                        
| 47 | 47 | }  | 
                                                        
| 48 | 48 | |
| 49 | 49 | // With the day events taken care off let's cycle through hours  | 
                                                        
| 50 | -    while( $data = $results[Event::BAT_HOUR]->fetchAssoc()) { | 
                                                        |
| 51 | -      for ($i = 0; $i<=23; $i++) { | 
                                                        |
| 52 | - $db_events[$data['unit_id']][Event::BAT_HOUR][$data['year']][$data['month']][$data['day']]['h'. $i] = $data['h'.$i];  | 
                                                        |
| 50 | +    while ($data = $results[Event::BAT_HOUR]->fetchAssoc()) { | 
                                                        |
| 51 | +      for ($i = 0; $i <= 23; $i++) { | 
                                                        |
| 52 | + $db_events[$data['unit_id']][Event::BAT_HOUR][$data['year']][$data['month']][$data['day']]['h' . $i] = $data['h' . $i];  | 
                                                        |
| 53 | 53 | }  | 
                                                        
| 54 | 54 | }  | 
                                                        
| 55 | 55 | |
| 56 | 56 | // With the hour events taken care off let's cycle through minutes  | 
                                                        
| 57 | -    while( $data = $results[Event::BAT_MINUTE]->fetchAssoc()) { | 
                                                        |
| 58 | -      for ($i = 0; $i<=59; $i++) { | 
                                                        |
| 57 | +    while ($data = $results[Event::BAT_MINUTE]->fetchAssoc()) { | 
                                                        |
| 58 | +      for ($i = 0; $i <= 59; $i++) { | 
                                                        |
| 59 | 59 |          if ($i <= 9) { | 
                                                        
| 60 | - $index = 'm0'.$i;  | 
                                                        |
| 60 | + $index = 'm0' . $i;  | 
                                                        |
| 61 | 61 | }  | 
                                                        
| 62 | 62 |          else { | 
                                                        
| 63 | - $index = 'm'.$i;  | 
                                                        |
| 63 | + $index = 'm' . $i;  | 
                                                        |
| 64 | 64 | }  | 
                                                        
| 65 | 65 | $db_events[$data['unit_id']][Event::BAT_MINUTE][$data['year']][$data['month']][$data['day']][$data['hour']][$index] = $data[$index];  | 
                                                        
| 66 | 66 | }  | 
                                                        
@@ -70,8 +70,7 @@ discard block  | 
                                                    ||
| 70 | 70 | $calendar_response->removeFromMatched($included_set[$unit_id]['unit'], CalendarResponse::CONSTRAINT, $this);  | 
                                                        
| 71 | 71 | |
| 72 | 72 | $this->affected_units[$unit_id] = $included_set[$unit_id]['unit'];  | 
                                                        
| 73 | - }  | 
                                                        |
| 74 | -          elseif (is_numeric($this->max_days) && $diff > $this->max_days) { | 
                                                        |
| 73 | +          } elseif (is_numeric($this->max_days) && $diff > $this->max_days) { | 
                                                        |
| 75 | 74 | $calendar_response->removeFromMatched($included_set[$unit_id]['unit'], CalendarResponse::CONSTRAINT, $this);  | 
                                                        
| 76 | 75 | |
| 77 | 76 | $this->affected_units[$unit_id] = $included_set[$unit_id]['unit'];  | 
                                                        
@@ -122,8 +121,7 @@ discard block  | 
                                                    ||
| 122 | 121 |      if ($day_of_the_week) { | 
                                                        
| 123 | 122 |        if ($start_date && $end_date) { | 
                                                        
| 124 | 123 |          $text = t('From @start_date to @end_date, if booking starts on @day_of_the_week', $args); | 
                                                        
| 125 | - }  | 
                                                        |
| 126 | -      else { | 
                                                        |
| 124 | +      } else { | 
                                                        |
| 127 | 125 |          $text = t('If booking starts on @day_of_the_week', $args); | 
                                                        
| 128 | 126 | }  | 
                                                        
| 129 | 127 | }  | 
                                                        
@@ -132,8 +130,7 @@ discard block  | 
                                                    ||
| 132 | 130 |      if ($minimum_stay || $maximum_stay) { | 
                                                        
| 133 | 131 |        if (empty($text)) { | 
                                                        
| 134 | 132 |          $text = t('The stay') . ' '; | 
                                                        
| 135 | - }  | 
                                                        |
| 136 | -      else { | 
                                                        |
| 133 | +      } else { | 
                                                        |
| 137 | 134 |          $text .=   ' ' . t('the stay') . ' '; | 
                                                        
| 138 | 135 | }  | 
                                                        
| 139 | 136 | }  | 
                                                        
@@ -141,15 +138,12 @@ discard block  | 
                                                    ||
| 141 | 138 | // Special case when min stay and max stay are the same.  | 
                                                        
| 142 | 139 |        if ($minimum_stay == $maximum_stay) { | 
                                                        
| 143 | 140 |          $text .= t('must be for @minimum_stay', $args); | 
                                                        
| 144 | - }  | 
                                                        |
| 145 | -      else { | 
                                                        |
| 141 | +      } else { | 
                                                        |
| 146 | 142 |          $text .= t('must be at least @minimum_stay and at most @maximum_stay', $args); | 
                                                        
| 147 | 143 | }  | 
                                                        
| 148 | - }  | 
                                                        |
| 149 | -    elseif ($minimum_stay) { | 
                                                        |
| 144 | +    } elseif ($minimum_stay) { | 
                                                        |
| 150 | 145 |        $text .= t('must be for at least @minimum_stay', $args); | 
                                                        
| 151 | - }  | 
                                                        |
| 152 | -    elseif ($maximum_stay) { | 
                                                        |
| 146 | +    } elseif ($maximum_stay) { | 
                                                        |
| 153 | 147 |        $text .= t('cannot be more than @maximum_stay', $args); | 
                                                        
| 154 | 148 | }  | 
                                                        
| 155 | 149 | |
@@ -111,7 +111,7 @@  | 
                                                    ||
| 111 | 111 | /**  | 
                                                        
| 112 | 112 |     * {@inheritdoc} | 
                                                        
| 113 | 113 | */  | 
                                                        
| 114 | -  public function applyConstraint(CalendarResponse &$calendar_response) { | 
                                                        |
| 114 | +  public function applyConstraint(CalendarResponse & $calendar_response) { | 
                                                        |
| 115 | 115 | $this->calendar_response = $calendar_response;  | 
                                                        
| 116 | 116 | }  | 
                                                        
| 117 | 117 | |
@@ -19,7 +19,7 @@  | 
                                                    ||
| 19 | 19 | *  | 
                                                        
| 20 | 20 | * @param $calendar_response  | 
                                                        
| 21 | 21 | */  | 
                                                        
| 22 | - public function applyConstraint(CalendarResponse &$calendar_response);  | 
                                                        |
| 22 | + public function applyConstraint(CalendarResponse & $calendar_response);  | 
                                                        |
| 23 | 23 | |
| 24 | 24 | /**  | 
                                                        
| 25 | 25 | * @param $start_date  | 
                                                        
@@ -110,8 +110,7 @@ discard block  | 
                                                    ||
| 110 | 110 |        for ($i = 0; $i<=59; $i++) { | 
                                                        
| 111 | 111 |          if ($i <= 9) { | 
                                                        
| 112 | 112 | $index = 'm0'.$i;  | 
                                                        
| 113 | - }  | 
                                                        |
| 114 | -        else { | 
                                                        |
| 113 | +        } else { | 
                                                        |
| 115 | 114 | $index = 'm'.$i;  | 
                                                        
| 116 | 115 | }  | 
                                                        
| 117 | 116 | $db_events[$data['unit_id']][Event::BAT_MINUTE][$data['year']][$data['month']][$data['day']][$data['hour']][$index] = $data[$index];  | 
                                                        
@@ -190,8 +189,7 @@ discard block  | 
                                                    ||
| 190 | 189 | }  | 
                                                        
| 191 | 190 | }  | 
                                                        
| 192 | 191 | }  | 
                                                        
| 193 | - }  | 
                                                        |
| 194 | -    catch (\Exception $e) { | 
                                                        |
| 192 | +    } catch (\Exception $e) { | 
                                                        |
| 195 | 193 | $saved = FALSE;  | 
                                                        
| 196 | 194 | $transaction->rollback();  | 
                                                        
| 197 | 195 |        watchdog_exception('BAT Event Save Exception', $e); | 
                                                        
@@ -49,14 +49,14 @@ discard block  | 
                                                    ||
| 49 | 49 | // Figure out how many days the current month has  | 
                                                        
| 50 | 50 | $temp_date = new \DateTime($data['year'] . "-" . $data['month']);  | 
                                                        
| 51 | 51 |        $days_in_month = (int)$temp_date->format('t'); | 
                                                        
| 52 | -      for ($i = 1; $i<=$days_in_month; $i++) { | 
                                                        |
| 52 | +      for ($i = 1; $i <= $days_in_month; $i++) { | 
                                                        |
| 53 | 53 | $db_events[$data['unit_id']][Event::BAT_DAY][$data['year']][$data['month']]['d' . $i] = $data['d' . $i];  | 
                                                        
| 54 | 54 | }  | 
                                                        
| 55 | 55 | }  | 
                                                        
| 56 | 56 | |
| 57 | 57 | // With the day events taken care off let's cycle through hours  | 
                                                        
| 58 | 58 |      foreach ($results[Event::BAT_HOUR]->fetchAll() as $data) { | 
                                                        
| 59 | -      for ($i = 0; $i<=23; $i++) { | 
                                                        |
| 59 | +      for ($i = 0; $i <= 23; $i++) { | 
                                                        |
| 60 | 60 | $db_events[$data['unit_id']][Event::BAT_HOUR][$data['year']][$data['month']]['d' . $data['day']]['h' . $i] = $data['h' . $i];  | 
                                                        
| 61 | 61 | }  | 
                                                        
| 62 | 62 | }  | 
                                                        
@@ -102,7 +102,7 @@ discard block  | 
                                                    ||
| 102 | 102 | // Because SQLite does not have a nice merge first we have to check if a row exists to determine whether to do an insert or an update  | 
                                                        
| 103 | 103 |            if (isset($existing_events[$event->getUnitId()][EVENT::BAT_DAY][$year][$month])) { | 
                                                        
| 104 | 104 | $command = "UPDATE $this->day_table SET ";  | 
                                                        
| 105 | -            foreach ($days as $day => $value){ | 
                                                        |
| 105 | +            foreach ($days as $day => $value) { | 
                                                        |
| 106 | 106 | $command .= "$day = $value,";  | 
                                                        
| 107 | 107 | }  | 
                                                        
| 108 | 108 | $command = rtrim($command, ',');  | 
                                                        
@@ -125,11 +125,11 @@ discard block  | 
                                                    ||
| 125 | 125 | $keys = array_keys($hours);  | 
                                                        
| 126 | 126 |                  if (isset($existing_events[$event->getUnitId()][EVENT::BAT_HOUR][$year][$month][$day])) { | 
                                                        
| 127 | 127 | $command = "UPDATE $this->hour_table SET ";  | 
                                                        
| 128 | -                  foreach ($hours as $hour => $value){ | 
                                                        |
| 128 | +                  foreach ($hours as $hour => $value) { | 
                                                        |
| 129 | 129 | $command .= "$hour = $value,";  | 
                                                        
| 130 | 130 | }  | 
                                                        
| 131 | 131 | $command = rtrim($command, ',');  | 
                                                        
| 132 | - $command .= " WHERE unit_id = " . $event->getUnitId() . " AND year = $year AND month = $month AND day = " . substr($day,1);  | 
                                                        |
| 132 | + $command .= " WHERE unit_id = " . $event->getUnitId() . " AND year = $year AND month = $month AND day = " . substr($day, 1);  | 
                                                        |
| 133 | 133 | $this->pdo->exec($command);  | 
                                                        
| 134 | 134 |                  } else { | 
                                                        
| 135 | 135 |                    $this->pdo->exec("INSERT INTO $this->hour_table (unit_id, year, month, day, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . substr($day, 1) . ", " . implode(', ', $values) . ")"); | 
                                                        
@@ -148,11 +148,11 @@ discard block  | 
                                                    ||
| 148 | 148 | $keys = array_keys($minutes);  | 
                                                        
| 149 | 149 |                  if (isset($existing_events[$event->getUnitId()][EVENT::BAT_MINUTE][$year][$month][$day][$hour])) { | 
                                                        
| 150 | 150 | $command = "UPDATE $this->minute_table SET ";  | 
                                                        
| 151 | -                  foreach ($minutes as $minute => $value){ | 
                                                        |
| 151 | +                  foreach ($minutes as $minute => $value) { | 
                                                        |
| 152 | 152 | $command .= "$minute = $value,";  | 
                                                        
| 153 | 153 | }  | 
                                                        
| 154 | 154 | $command = rtrim($command, ',');  | 
                                                        
| 155 | - $command .= " WHERE unit_id = " . $event->getUnitId() . " AND year = $year AND month = $month AND day = " . substr($day,1) . " AND hour = " . substr($hour,1);  | 
                                                        |
| 155 | + $command .= " WHERE unit_id = " . $event->getUnitId() . " AND year = $year AND month = $month AND day = " . substr($day, 1) . " AND hour = " . substr($hour, 1);  | 
                                                        |
| 156 | 156 | $this->pdo->exec($command);  | 
                                                        
| 157 | 157 |                  } else { | 
                                                        
| 158 | 158 |                    $this->pdo->exec("INSERT INTO $this->minute_table (unit_id, year, month, day, hour, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . substr($day, 1) . ", " . substr($hour, 1) . ", " . implode(', ', $values) . ")"); | 
                                                        
@@ -102,8 +102,7 @@  | 
                                                    ||
| 102 | 102 |      if ($day_of_the_week) { | 
                                                        
| 103 | 103 |        if ($start_date && $end_date) { | 
                                                        
| 104 | 104 | $text = 'From @start_date to @end_date, if booking starts on @day_of_the_week';  | 
                                                        
| 105 | - }  | 
                                                        |
| 106 | -      else { | 
                                                        |
| 105 | +      } else { | 
                                                        |
| 107 | 106 | $text = 'If booking starts on @day_of_the_week';  | 
                                                        
| 108 | 107 | }  | 
                                                        
| 109 | 108 | |
@@ -111,7 +111,7 @@  | 
                                                    ||
| 111 | 111 | /**  | 
                                                        
| 112 | 112 |     * {@inheritdoc} | 
                                                        
| 113 | 113 | */  | 
                                                        
| 114 | -  public function applyConstraint(CalendarResponse &$calendar_response) { | 
                                                        |
| 114 | +  public function applyConstraint(CalendarResponse & $calendar_response) { | 
                                                        |
| 115 | 115 | $this->calendar_response = $calendar_response;  | 
                                                        
| 116 | 116 | }  | 
                                                        
| 117 | 117 | |
@@ -111,7 +111,7 @@  | 
                                                    ||
| 111 | 111 | /**  | 
                                                        
| 112 | 112 |     * {@inheritdoc} | 
                                                        
| 113 | 113 | */  | 
                                                        
| 114 | -  public function applyConstraint(CalendarResponse &$calendar_response) { | 
                                                        |
| 114 | +  public function applyConstraint(CalendarResponse & $calendar_response) { | 
                                                        |
| 115 | 115 | $this->calendar_response = $calendar_response;  | 
                                                        
| 116 | 116 | }  | 
                                                        
| 117 | 117 | |
@@ -124,7 +124,7 @@ discard block  | 
                                                    ||
| 124 | 124 | $current_states = array_keys($unit_states);  | 
                                                        
| 125 | 125 | // Compare the current states with the set of valid states  | 
                                                        
| 126 | 126 | $remaining_states = array_diff($current_states, $valid_states);  | 
                                                        
| 127 | -      if (count($remaining_states) == 0 ) { | 
                                                        |
| 127 | +      if (count($remaining_states) == 0) { | 
                                                        |
| 128 | 128 | // Unit is in a state that is within the set of valid states so add to result set  | 
                                                        
| 129 | 129 | $units[$unit] = $unit;  | 
                                                        
| 130 | 130 | $response->addMatch($keyed_units[$unit], CalendarResponse::VALID_STATE);  | 
                                                        
@@ -163,7 +163,7 @@ discard block  | 
                                                    ||
| 163 | 163 | // Create a mock itemized event for the period in question - since event data is either  | 
                                                        
| 164 | 164 | // in the database or the default value we first create a mock event and then fill it in  | 
                                                        
| 165 | 165 | // accordingly  | 
                                                        
| 166 | - $mock_event = new Event($start_date, $end_date, new Unit(0,0,null), $this->default_value);  | 
                                                        |
| 166 | + $mock_event = new Event($start_date, $end_date, new Unit(0, 0, null), $this->default_value);  | 
                                                        |
| 167 | 167 | $itemized = $mock_event->itemizeEvent();  | 
                                                        
| 168 | 168 | |
| 169 | 169 | // Cycle through each unit retrieved and provide it with a fully configured itemized mock event  | 
                                                        
@@ -253,11 +253,11 @@ discard block  | 
                                                    ||
| 253 | 253 |          foreach ($days as $day => $hours) { | 
                                                        
| 254 | 254 |            foreach ($hours as $hour => $value) { | 
                                                        
| 255 | 255 |              if (isset($db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour])) { | 
                                                        
| 256 | - $result[$year][$month][$day][$hour] = ((int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]);  | 
                                                        |
| 256 | + $result[$year][$month][$day][$hour] = ((int)$db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]);  | 
                                                        |
| 257 | 257 | }  | 
                                                        
| 258 | 258 |              else { | 
                                                        
| 259 | 259 | // If nothing from db - then revert to the defaults  | 
                                                        
| 260 | - $result[$year][$month][$day][$hour] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 260 | + $result[$year][$month][$day][$hour] = (int)$keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 261 | 261 | }  | 
                                                        
| 262 | 262 | }  | 
                                                        
| 263 | 263 | }  | 
                                                        
@@ -270,7 +270,7 @@ discard block  | 
                                                    ||
| 270 | 270 |          foreach ($months as $month => $days) { | 
                                                        
| 271 | 271 |            foreach ($days as $day => $hours) { | 
                                                        
| 272 | 272 |              foreach ($hours as $hour => $value) { | 
                                                        
| 273 | - $result[$year][$month][$day][$hour] = ((int) $value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $value);  | 
                                                        |
| 273 | + $result[$year][$month][$day][$hour] = ((int)$value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$value);  | 
                                                        |
| 274 | 274 | }  | 
                                                        
| 275 | 275 | ksort($result[$year][$month][$day], SORT_NATURAL);  | 
                                                        
| 276 | 276 | }  | 
                                                        
@@ -300,11 +300,11 @@ discard block  | 
                                                    ||
| 300 | 300 |            foreach ($hours as $hour => $minutes) { | 
                                                        
| 301 | 301 |              foreach ($minutes as $minute => $value) { | 
                                                        
| 302 | 302 |                if (isset($db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute])) { | 
                                                        
| 303 | - $result[$year][$month][$day][$hour][$minute] = ((int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]);  | 
                                                        |
| 303 | + $result[$year][$month][$day][$hour][$minute] = ((int)$db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]);  | 
                                                        |
| 304 | 304 | }  | 
                                                        
| 305 | 305 |                else { | 
                                                        
| 306 | 306 | // If nothing from db - then revert to the defaults  | 
                                                        
| 307 | - $result[$year][$month][$day][$hour][$minute] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 307 | + $result[$year][$month][$day][$hour][$minute] = (int)$keyed_units[$unit]->getDefaultValue();  | 
                                                        |
| 308 | 308 | }  | 
                                                        
| 309 | 309 | }  | 
                                                        
| 310 | 310 | }  | 
                                                        
@@ -319,7 +319,7 @@ discard block  | 
                                                    ||
| 319 | 319 |            foreach ($days as $day => $hours) { | 
                                                        
| 320 | 320 |              foreach ($hours as $hour => $minutes) { | 
                                                        
| 321 | 321 |                foreach ($minutes as $minute => $value) { | 
                                                        
| 322 | - $result[$year][$month][$day][$hour][$minute] = ((int) $value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $value);  | 
                                                        |
| 322 | + $result[$year][$month][$day][$hour][$minute] = ((int)$value == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$value);  | 
                                                        |
| 323 | 323 | }  | 
                                                        
| 324 | 324 | ksort($result[$year][$month][$day][$hour], SORT_NATURAL);  | 
                                                        
| 325 | 325 | }  | 
                                                        
@@ -382,12 +382,12 @@ discard block  | 
                                                    ||
| 382 | 382 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 383 | 383 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 384 | 384 |                        $start_event = clone($end_event->add(new \DateInterval('PT1M'))); | 
                                                        
| 385 | - $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute,1));  | 
                                                        |
| 385 | + $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute, 1));  | 
                                                        |
| 386 | 386 | $current_value = $minute_value;  | 
                                                        
| 387 | 387 | }  | 
                                                        
| 388 | 388 |                      if ($current_value === NULL) { | 
                                                        
| 389 | 389 | // We are down to minutes and haven't created and event yet - do one now  | 
                                                        
| 390 | - $start_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute,1));  | 
                                                        |
| 390 | + $start_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . substr($hour, 1) . ':' . substr($minute, 1));  | 
                                                        |
| 391 | 391 | $end_event = clone($start_event);  | 
                                                        
| 392 | 392 | }  | 
                                                        
| 393 | 393 | $current_value = $minute_value;  | 
                                                        
@@ -530,7 +530,7 @@ discard block  | 
                                                    ||
| 530 | 530 | * @return mixed  | 
                                                        
| 531 | 531 | */  | 
                                                        
| 532 | 532 |    protected function getUnit($unit_id) { | 
                                                        
| 533 | - $keyed = $this->keyUnitsById();  | 
                                                        |
| 533 | + $keyed = $this->keyUnitsById();  | 
                                                        |
| 534 | 534 | return $keyed[$unit_id];  | 
                                                        
| 535 | 535 | }  | 
                                                        
| 536 | 536 | |
@@ -128,8 +128,7 @@ discard block  | 
                                                    ||
| 128 | 128 | // Unit is in a state that is within the set of valid states so add to result set  | 
                                                        
| 129 | 129 | $units[$unit] = $unit;  | 
                                                        
| 130 | 130 | $response->addMatch($keyed_units[$unit], CalendarResponse::VALID_STATE);  | 
                                                        
| 131 | - }  | 
                                                        |
| 132 | -      else { | 
                                                        |
| 131 | +      } else { | 
                                                        |
| 133 | 132 | $response->addMiss($keyed_units[$unit], CalendarResponse::INVALID_STATE);  | 
                                                        
| 134 | 133 | }  | 
                                                        
| 135 | 134 | |
@@ -223,8 +222,7 @@ discard block  | 
                                                    ||
| 223 | 222 |            foreach ($days as $day => $value) { | 
                                                        
| 224 | 223 | $result[$year][$month][$day] = ((int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day]);  | 
                                                        
| 225 | 224 | }  | 
                                                        
| 226 | - }  | 
                                                        |
| 227 | -        else { | 
                                                        |
| 225 | +        } else { | 
                                                        |
| 228 | 226 |            foreach ($days as $day => $value) { | 
                                                        
| 229 | 227 | $result[$year][$month][$day] = $keyed_units[$unit]->getDefaultValue();  | 
                                                        
| 230 | 228 | }  | 
                                                        
@@ -254,8 +252,7 @@ discard block  | 
                                                    ||
| 254 | 252 |            foreach ($hours as $hour => $value) { | 
                                                        
| 255 | 253 |              if (isset($db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour])) { | 
                                                        
| 256 | 254 | $result[$year][$month][$day][$hour] = ((int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]);  | 
                                                        
| 257 | - }  | 
                                                        |
| 258 | -            else { | 
                                                        |
| 255 | +            } else { | 
                                                        |
| 259 | 256 | // If nothing from db - then revert to the defaults  | 
                                                        
| 260 | 257 | $result[$year][$month][$day][$hour] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        
| 261 | 258 | }  | 
                                                        
@@ -301,8 +298,7 @@ discard block  | 
                                                    ||
| 301 | 298 |              foreach ($minutes as $minute => $value) { | 
                                                        
| 302 | 299 |                if (isset($db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute])) { | 
                                                        
| 303 | 300 | $result[$year][$month][$day][$hour][$minute] = ((int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]);  | 
                                                        
| 304 | - }  | 
                                                        |
| 305 | -              else { | 
                                                        |
| 301 | +              } else { | 
                                                        |
| 306 | 302 | // If nothing from db - then revert to the defaults  | 
                                                        
| 307 | 303 | $result[$year][$month][$day][$hour][$minute] = (int) $keyed_units[$unit]->getDefaultValue();  | 
                                                        
| 308 | 304 | }  | 
                                                        
@@ -377,8 +373,7 @@ discard block  | 
                                                    ||
| 377 | 373 |                      if ($current_value === $minute_value) { | 
                                                        
| 378 | 374 | // We are still in minutes and going through so add a minute  | 
                                                        
| 379 | 375 |                        $end_event->add(new \DateInterval('PT1M')); | 
                                                        
| 380 | - }  | 
                                                        |
| 381 | -                    elseif (($current_value != $minute_value) && ($current_value !== NULL)) { | 
                                                        |
| 376 | +                    } elseif (($current_value != $minute_value) && ($current_value !== NULL)) { | 
                                                        |
| 382 | 377 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 383 | 378 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 384 | 379 |                        $start_event = clone($end_event->add(new \DateInterval('PT1M'))); | 
                                                        
@@ -392,12 +387,10 @@ discard block  | 
                                                    ||
| 392 | 387 | }  | 
                                                        
| 393 | 388 | $current_value = $minute_value;  | 
                                                        
| 394 | 389 | }  | 
                                                        
| 395 | - }  | 
                                                        |
| 396 | -                elseif ($current_value === $hour_value) { | 
                                                        |
| 390 | +                } elseif ($current_value === $hour_value) { | 
                                                        |
| 397 | 391 | // We are in hours and can add something  | 
                                                        
| 398 | 392 |                    $end_event->add(new \DateInterval('PT1H')); | 
                                                        
| 399 | - }  | 
                                                        |
| 400 | -                elseif (($current_value != $hour_value) && ($current_value !== NULL)) { | 
                                                        |
| 393 | +                } elseif (($current_value != $hour_value) && ($current_value !== NULL)) { | 
                                                        |
| 401 | 394 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 402 | 395 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 403 | 396 | // Start event becomes the end event with a minute added  | 
                                                        
@@ -414,12 +407,10 @@ discard block  | 
                                                    ||
| 414 | 407 | $current_value = $hour_value;  | 
                                                        
| 415 | 408 | }  | 
                                                        
| 416 | 409 | }  | 
                                                        
| 417 | - }  | 
                                                        |
| 418 | -            elseif ($current_value === $value) { | 
                                                        |
| 410 | +            } elseif ($current_value === $value) { | 
                                                        |
| 419 | 411 | // We are adding a whole day so the end event gets moved to the end of the day we are adding  | 
                                                        
| 420 | 412 | $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . '23:59');  | 
                                                        
| 421 | - }  | 
                                                        |
| 422 | -            elseif (($current_value !== $value) && ($current_value !== NULL)) { | 
                                                        |
| 413 | +            } elseif (($current_value !== $value) && ($current_value !== NULL)) { | 
                                                        |
| 423 | 414 | // Value just switched - let us wrap up with current event and start a new one  | 
                                                        
| 424 | 415 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value);  | 
                                                        
| 425 | 416 | // Start event becomes the end event with a minute added  | 
                                                        
@@ -454,8 +445,7 @@ discard block  | 
                                                    ||
| 454 | 445 |            if ($event->endsLater($end_date)) { | 
                                                        
| 455 | 446 | $event->setEndDate($end_date);  | 
                                                        
| 456 | 447 | }  | 
                                                        
| 457 | - }  | 
                                                        |
| 458 | -        else { | 
                                                        |
| 448 | +        } else { | 
                                                        |
| 459 | 449 | // Event completely not in range so unset it  | 
                                                        
| 460 | 450 | unset($normalized_events[$unit_id][$key]);  | 
                                                        
| 461 | 451 | }  | 
                                                        
@@ -486,8 +476,7 @@ discard block  | 
                                                    ||
| 486 | 476 | $e++;  | 
                                                        
| 487 | 477 | $flipped[$e][$value][$datum] = $datum;  | 
                                                        
| 488 | 478 | $old_value = $value;  | 
                                                        
| 489 | - }  | 
                                                        |
| 490 | -        else { | 
                                                        |
| 479 | +        } else { | 
                                                        |
| 491 | 480 | $flipped[$e][$value][$datum] = $datum;  | 
                                                        
| 492 | 481 | }  | 
                                                        
| 493 | 482 | }  |