Roave / composer-gpg-verify

test/RoaveTest/ComposerGpgVerify/VerifyTest.php

Spacing +22 added lines, -22 removed lines

@@ -112,14 +112,14 @@ 
             ->installationManager
             ->expects(self::any())
             ->method('getInstallPath')
-            ->willReturnCallback(function (PackageInterface $package) : string {
+            ->willReturnCallback(function(PackageInterface $package) : string {
                 return array_search($package, $this->installedPackages, true);
             });
         $this
             ->localRepository
             ->expects(self::any())
             ->method('getPackages')
-            ->willReturnCallback(function () {
+            ->willReturnCallback(function() {
                 return array_values($this->installedPackages);
             });
     }
@@ -164,7 +164,7 @@ 
     public function testWillRejectNonGitPackages() : void
     {
         $packageName = 'vendor1/package1';
-        $vendor1     = sys_get_temp_dir() . '/' . uniqid('vendor', true) . '/' . $packageName;
+        $vendor1     = sys_get_temp_dir().'/'.uniqid('vendor', true).'/'.$packageName;
 
         /* @var $package PackageInterface|\PHPUnit_Framework_MockObject_MockObject */
         $package = $this->createMock(PackageInterface::class);
@@ -193,7 +193,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $gpgHomeDirectory);
+        putenv('GNUPGHOME='.$gpgHomeDirectory);
 
         $this->assertWillSucceedPackageVerification();
     }
@@ -217,7 +217,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
+        putenv('GNUPGHOME='.$personalGpgDirectory);
 
         $this->assertWillFailPackageVerification();
     }
@@ -242,7 +242,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
+        putenv('GNUPGHOME='.$personalGpgDirectory);
         putenv('LANGUAGE=de_DE');
 
         try {
@@ -275,7 +275,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
+        putenv('GNUPGHOME='.$personalGpgDirectory);
 
         $this->assertWillSucceedPackageVerification();
     }
@@ -299,7 +299,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
+        putenv('GNUPGHOME='.$personalGpgDirectory);
 
         $this->assertWillFailPackageVerification();
     }
@@ -323,7 +323,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
+        putenv('GNUPGHOME='.$personalGpgDirectory);
 
         $this->assertWillSucceedPackageVerification();
     }
@@ -342,7 +342,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $gpgHomeDirectory);
+        putenv('GNUPGHOME='.$gpgHomeDirectory);
 
         $this->assertWillSucceedPackageVerification();
     }
@@ -360,7 +360,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $this->makeGpgHomeDirectory());
+        putenv('GNUPGHOME='.$this->makeGpgHomeDirectory());
 
         $this->assertWillFailPackageVerification();
     }
@@ -382,7 +382,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $this->makeGpgHomeDirectory());
+        putenv('GNUPGHOME='.$this->makeGpgHomeDirectory());
 
         $this->assertWillFailPackageVerification();
     }
@@ -401,7 +401,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
+        putenv('GNUPGHOME='.$personalGpgDirectory);
 
         $this->assertWillFailPackageVerification();
     }
@@ -423,7 +423,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $gpgHome);
+        putenv('GNUPGHOME='.$gpgHome);
 
         $this->assertWillFailPackageVerification();
     }
@@ -445,7 +445,7 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $gpgHome);
+        putenv('GNUPGHOME='.$gpgHome);
 
         $this->assertWillFailPackageVerification();
     }
@@ -465,14 +465,14 @@ 
 
         $this->configureCorrectComposerSetup();
 
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
+        putenv('GNUPGHOME='.$personalGpgDirectory);
 
         $this->assertWillFailPackageVerification();
     }
 
     private function makeVendorDirectory() : string
     {
-        $vendorDirectory = sys_get_temp_dir() . '/' . uniqid('vendor', true);
+        $vendorDirectory = sys_get_temp_dir().'/'.uniqid('vendor', true);
 
         self::assertTrue(mkdir($vendorDirectory));
 
@@ -525,7 +525,7 @@ 
         string $email,
         string $name
     ) : string {
-        $dependencyRepository = $vendorDirectory . '/' . $packageName;
+        $dependencyRepository = $vendorDirectory.'/'.$packageName;
 
         self::assertTrue(mkdir($dependencyRepository, 0777, true));
 
@@ -553,7 +553,7 @@ 
 
     private function makeGpgHomeDirectory() : string
     {
-        $homeDirectory = sys_get_temp_dir() . '/' . uniqid('gpg-verification-test', true);
+        $homeDirectory = sys_get_temp_dir().'/'.uniqid('gpg-verification-test', true);
 
         self::assertTrue(mkdir($homeDirectory, 0700));
 
@@ -578,7 +578,7 @@ 
         self::assertGreaterThan(
             0,
             file_put_contents(
-                $gpgHomeDirectory . '/key-info.txt',
+                $gpgHomeDirectory.'/key-info.txt',
                 str_replace(['<<<NAME>>>', '<<<EMAIL>>>'], [$name, $emailAddress], $input)
             )
         );
@@ -642,7 +642,7 @@ 
         string $foreignKey,
         bool $sign
     ) : void {
-        $exportPath = sys_get_temp_dir() . '/' . uniqid('exportedKey', true);
+        $exportPath = sys_get_temp_dir().'/'.uniqid('exportedKey', true);
 
         (new Process(
             sprintf('gpg --export --armor > %s', escapeshellarg($exportPath)),
@@ -662,7 +662,7 @@ 
             ->setTimeout(30)
             ->mustRun();
 
-        if (! $sign) {
+        if (!$sign) {
             return;
         }
 

src/Roave/ComposerGpgVerify/Exception/PackagesTrustCheckFailed.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
             implode(
                 "\n\n",
                 array_map(
-                    function (PackageVerification $failedVerification) : string {
+                    function(PackageVerification $failedVerification) : string {
                         return $failedVerification->printReason();
                     },
                     array_merge([$failedVerification], $furtherFailedVerifications)

src/Roave/ComposerGpgVerify/Verify.php

Spacing +7 added lines, -7 removed lines

@@ -66,7 +66,7 @@ 
         $installationManager = $composer->getInstallationManager();
         /* @var $checkedPackages PackageVerification[] */
         $checkedPackages     = array_map(
-            function (PackageInterface $package) use ($installationManager) : PackageVerification {
+            function(PackageInterface $package) use ($installationManager) : PackageVerification {
                 return self::verifyPackage($installationManager, $package);
             },
             $composer->getRepositoryManager()->getLocalRepository()->getPackages()
@@ -76,12 +76,12 @@ 
 
         $escapes = array_filter(
             $checkedPackages,
-            function (PackageVerification $verification) : bool {
-                return ! $verification->isVerified();
+            function(PackageVerification $verification) : bool {
+                return !$verification->isVerified();
             }
         );
 
-        if (! $escapes) {
+        if (!$escapes) {
             $io->write('<info>roave/composer-gpg-verify:</info>  All installed packages passed GPG validation!');
 
             return;
@@ -94,9 +94,9 @@ 
         InstallationManager $installationManager,
         PackageInterface $package
     ) : PackageVerification {
-        $gitDirectory = $installationManager->getInstallPath($package) . '/.git';
+        $gitDirectory = $installationManager->getInstallPath($package).'/.git';
 
-        if (! is_dir($gitDirectory)) {
+        if (!is_dir($gitDirectory)) {
             return UnknownPackageFormat::fromNonGitPackage($package);
         }
 
@@ -150,7 +150,7 @@ 
     private static function checkTagSignatures(string $gitDirectory, PackageInterface $package, string ...$tags) : array
     {
         return array_map(
-            function (string $tag) use ($gitDirectory, $package) : GitSignatureCheck {
+            function(string $tag) use ($gitDirectory, $package) : GitSignatureCheck {
                 $command = sprintf(
                     'git --git-dir %s tag -v %s 2>&1',
                     escapeshellarg($gitDirectory),

src/Roave/ComposerGpgVerify/Package/Git/GitSignatureCheck.php

Spacing +16 added lines, -16 removed lines

@@ -97,7 +97,7 @@ 
         string $output
     ) : self {
         $signatureKey = self::extractKeyIdentifier($output);
-        $signed       = $signatureKey && ! $exitCode;
+        $signed       = $signatureKey && !$exitCode;
 
         return new self(
             $package->getName(),
@@ -120,7 +120,7 @@ 
         string $output
     ) : self {
         $signatureKey = self::extractKeyIdentifier($output);
-        $signed       = $signatureKey && ! $exitCode;
+        $signed       = $signatureKey && !$exitCode;
 
         return new self(
             $package->getName(),
@@ -142,14 +142,14 @@ 
             "\n",
             [
                 (($this->isSigned || $this->signatureKey) ? '[SIGNED]' : '[NOT SIGNED]')
-                . ' ' . ($this->isVerified ? '[VERIFIED]' : '[NOT VERIFIED]')
-                . ' ' . ($this->commitHash ? 'Commit #' . $this->commitHash : '')
-                . ' ' . ($this->tagName ? 'Tag ' . $this->tagName : '')
-                . ' ' . ($this->signatureAuthor ? 'By "' . $this->signatureAuthor . '"' : '')
-                . ' ' . ($this->signatureKey ? '(Key ' . $this->signatureKey . ')' : ''),
-                'Command: ' . $this->command,
-                'Exit code: ' . $this->exitCode,
-                'Output: ' . $this->output,
+                . ' '.($this->isVerified ? '[VERIFIED]' : '[NOT VERIFIED]')
+                . ' '.($this->commitHash ? 'Commit #'.$this->commitHash : '')
+                . ' '.($this->tagName ? 'Tag '.$this->tagName : '')
+                . ' '.($this->signatureAuthor ? 'By "'.$this->signatureAuthor.'"' : '')
+                . ' '.($this->signatureKey ? '(Key '.$this->signatureKey.')' : ''),
+                'Command: '.$this->command,
+                'Exit code: '.$this->exitCode,
+                'Output: '.$this->output,
             ]
         );
     }
@@ -162,7 +162,7 @@ 
     private static function extractCommitHash(string $output) : ?string
     {
         $keys = array_filter(array_map(
-            function (string $outputRow) {
+            function(string $outputRow) {
                 preg_match('/^(tree|object) ([a-fA-F0-9]{40})$/i', $outputRow, $matches);
 
                 return $matches[2] ?? false;
@@ -176,7 +176,7 @@ 
     private static function extractTagName(string $output) : ?string
     {
         $keys = array_filter(array_map(
-            function (string $outputRow) {
+            function(string $outputRow) {
                 preg_match('/^tag (.+)$/i', $outputRow, $matches);
 
                 return $matches[1] ?? false;
@@ -190,7 +190,7 @@ 
     private static function extractKeyIdentifier(string $output) : ?string
     {
         $keys = array_filter(array_map(
-            function (string $outputRow) {
+            function(string $outputRow) {
                 preg_match('/gpg:.*using .* key ([a-fA-F0-9]+)/i', $outputRow, $matches);
 
                 return $matches[1] ?? false;
@@ -204,7 +204,7 @@ 
     private static function extractSignatureAuthor(string $output) : ?string
     {
         $keys = array_filter(array_map(
-            function (string $outputRow) {
+            function(string $outputRow) {
                 preg_match('/gpg: Good signature from "(.+)" \\[.*\\]/i', $outputRow, $matches);
 
                 return $matches[1] ?? false;
@@ -217,9 +217,9 @@ 
 
     private static function signatureValidationHasNoWarnings(string $output) : bool
     {
-        return ! array_filter(
+        return !array_filter(
             explode("\n", $output),
-            function (string $outputRow) {
+            function(string $outputRow) {
                 return false !== strpos($outputRow, 'gpg: WARNING: ');
             }
         );

src/Roave/ComposerGpgVerify/Package/GitPackage.php

Spacing +5 added lines, -5 removed lines

@@ -57,7 +57,7 @@ 
                 . implode(
                     "\n\n",
                     array_map(
-                        function (GitSignatureCheck $check) : string {
+                        function(GitSignatureCheck $check) : string {
                             return $check->asHumanReadableString();
                         },
                         $this->passedChecks()
@@ -70,7 +70,7 @@ 
             . implode(
                 "\n\n",
                 array_map(
-                    function (GitSignatureCheck $check) : string {
+                    function(GitSignatureCheck $check) : string {
                         return $check->asHumanReadableString();
                     },
                     $this->failedChecks()
@@ -85,7 +85,7 @@ 
     {
         return array_values(array_filter(
             $this->checks,
-            function (GitSignatureCheck $check) {
+            function(GitSignatureCheck $check) {
                 return $check->canBeTrusted();
             }
         ));
@@ -98,8 +98,8 @@ 
     {
         return array_values(array_filter(
             $this->checks,
-            function (GitSignatureCheck $check) {
-                return ! $check->canBeTrusted();
+            function(GitSignatureCheck $check) {
+                return !$check->canBeTrusted();
             }
         ));
     }