Roave\ApiCompare\Git\PickLastMinorVersionFromCollection::forVersions()

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function forVersions(VersionsCollection $versions) : Version
    {
        Assert::that($versions->count())->greaterOrEqualThan(1);

        $versions->sort(VersionsCollection::SORT_DESC);

        /** @var Version $lastVersion */
        $lastVersion = $versions->getIterator()->current();
        $previousVersionInIteration = $lastVersion;
        /** @var Version $version */
        foreach ($versions as $version) {
            if ($lastVersion->getMinor() !== $version->getMinor()) {
                return $previousVersionInIteration;
            }
            $previousVersionInIteration = $version;
        }

        return $version;

The variable $version seems to be defined by a foreach iteration on line 27. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }