Roave\ApiCompare\Git\PickLastMinorVersionFromCollection

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	forVersions()	0	18	3

<?php
declare(strict_types=1);

namespace Roave\ApiCompare\Git;

use Assert\Assert;
use Version\Version;
use Version\VersionsCollection;

final class PickLastMinorVersionFromCollection implements PickVersionFromVersionCollection
{
    /**
     * {@inheritDoc}
     * @throws \Symfony\Component\Process\Exception\LogicException
     * @throws \Symfony\Component\Process\Exception\RuntimeException
     */
    public function forVersions(VersionsCollection $versions) : Version
    {
        Assert::that($versions->count())->greaterOrEqualThan(1);

        $versions->sort(VersionsCollection::SORT_DESC);

        /** @var Version $lastVersion */
        $lastVersion = $versions->getIterator()->current();
        $previousVersionInIteration = $lastVersion;
        /** @var Version $version */
        foreach ($versions as $version) {
            if ($lastVersion->getMinor() !== $version->getMinor()) {
                return $previousVersionInIteration;
            }
            $previousVersionInIteration = $version;
        }

        return $version;

The variable $version seems to be defined by a foreach iteration on line 27. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }
}