ReDnAxE / project-quality-inspector

src/Application/Output/HtmlReportHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
 EOT;
 
     /**
-     * @param  RuleInterface[]  $rules
+     * @param  RuleFilterIterator  $rules
      * @param  string $htmlFile
      */
     public static function generateHtmlFile(RuleFilterIterator $rules, $htmlFile)

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 namespace ProjectQualityInspector\Application\Output;
 
-use ProjectQualityInspector\Exception\RuleViolationException;
 use ProjectQualityInspector\Iterator\RuleFilterIterator;
 
 class HtmlReportHelper

Spacing +5 added lines, -5 removed lines

@@ -98,7 +98,7 @@ 
      */
     private static function createTestSuite($name, array $tests)
     {
-        $testSuite = '<h2> '.strtoupper($name).', tests: '.count($tests).' failures: '.static::sumArraysKey('failures', $tests, 'sum').', errors: '.static::sumArraysKey('errors', $tests, 'sum').', time: '.static::sumArraysKey('time', $tests).'</h2>';
+        $testSuite = '<h2> ' . strtoupper($name) . ', tests: ' . count($tests) . ' failures: ' . static::sumArraysKey('failures', $tests, 'sum') . ', errors: ' . static::sumArraysKey('errors', $tests, 'sum') . ', time: ' . static::sumArraysKey('time', $tests) . '</h2>';
 
         $testSuite .= '<table class="testsuite">
         <tr>
@@ -133,8 +133,8 @@ 
         if ($test['failures']['sum'] > 0) {
             foreach ($test['failures']['list']  as $failure) {
                 $testCase .= '<tr class="failure">
-                    <td>'.$failure['type'].'</td>
-                    <td>'.self::sanitizeTags($failure['message']).'</td>
+                    <td>'.$failure['type'] . '</td>
+                    <td>'.self::sanitizeTags($failure['message']) . '</td>
                 </tr>';
             }
         }
@@ -142,8 +142,8 @@ 
         if ($test['errors']['sum'] > 0) {
             foreach ($test['errors']['list'] as $error) {
                 $testCase .= '<tr class="error">
-                    <td>'.$error['type'].'</td>
-                    <td>'.self::sanitizeTags($error['message']).'</td>
+                    <td>'.$error['type'] . '</td>
+                    <td>'.self::sanitizeTags($error['message']) . '</td>
                 </tr>';
             }
         }

src/Application/Output/JunitHelper.php

Doc Comments +4 added lines, -4 removed lines

@@ -16,7 +16,7 @@ 
 class JunitHelper
 {
     /**
-     * @param  RuleInterface[]  $rules
+     * @param  RuleFilterIterator  $rules
      * @param  string $junitFile
      */
     public static function generateJunitFile(RuleFilterIterator $rules, $junitFile)
@@ -40,8 +40,8 @@ 
 
     /**
      * @param  array $tests
-     * @param  DOMDocument $xml
-     * @return DOMDocument
+     * @param  \DOMDocument $xml
+     * @return \DOMElement
      */
     private static function createTestSuite($name, array $tests, \DOMDocument $xml)
     {
@@ -89,7 +89,7 @@ 
      * @param  array $attributes
      * @param  \DOMDocument $xml
      * @param  string $value
-     * @return \DOMDocument
+     * @return \DOMElement
      */
     private static function createElement($tagName, array $attributes, \DOMDocument $xml, $value = null)
     {

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 namespace ProjectQualityInspector\Application\Output;
 
-use ProjectQualityInspector\Exception\RuleViolationException;
 use ProjectQualityInspector\Iterator\RuleFilterIterator;
 
 class JunitHelper

Indentation +4 added lines, -4 removed lines

@@ -28,10 +28,10 @@
             $testSuites->appendChild(static::createTestSuite($rule::getRuleName(), $rule->getAssertions(), $xml));
         }
 
-      $testSuites->setAttribute('name', 'pqi');
-      $testSuites->setAttribute('errors', static::sumDomChildsAttribute($testSuites, 'errors'));
-      $testSuites->setAttribute('failures', static::sumDomChildsAttribute($testSuites, 'failures'));
-      $testSuites->setAttribute('time', static::sumDomChildsAttribute($testSuites, 'time'));
+        $testSuites->setAttribute('name', 'pqi');
+        $testSuites->setAttribute('errors', static::sumDomChildsAttribute($testSuites, 'errors'));
+        $testSuites->setAttribute('failures', static::sumDomChildsAttribute($testSuites, 'failures'));
+        $testSuites->setAttribute('time', static::sumDomChildsAttribute($testSuites, 'time'));
 
         $xml->appendChild($testSuites);
 

src/Rule/ComposerConfigRule.php

Doc Comments +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
     /**
      * @param string $version
      *
-     * @return mixed
+     * @return string
      */
     protected function sanitizeVersion($version)
     {

src/Rule/FilesRule.php

Doc Comments +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
 
     /**
      * @param $fileConf
-     * @param $baseDir
+     * @param string $baseDir
      * @return array
      */
     private function expectsFilesGlobExists($fileConf, $baseDir)
@@ -75,7 +75,7 @@ 
     }
 
     /**
-     * @param $filePathGlob
+     * @param string $filePathGlob
      * @param $reason
      * @return array
      *

src/Rule/GitRule.php

Indentation +7 added lines, -7 removed lines

@@ -307,14 +307,14 @@
      */
     private function explodeCommitsArrays(array $commits)
     {
-          $explodedCommits = [];
+            $explodedCommits = [];
 
-          foreach ($commits as $commit) {
-              $explodedCommit = explode('|', $commit);
-              $explodedCommit = array_combine(array_slice($this->commitFormatKeys, 0, count($explodedCommit)), $explodedCommit);
-              $explodedCommits[$explodedCommit['commitHash']] = $explodedCommit;
-          }
+            foreach ($commits as $commit) {
+                $explodedCommit = explode('|', $commit);
+                $explodedCommit = array_combine(array_slice($this->commitFormatKeys, 0, count($explodedCommit)), $explodedCommit);
+                $explodedCommits[$explodedCommit['commitHash']] = $explodedCommit;
+            }
 
-          return $explodedCommits;
+            return $explodedCommits;
     }
 }
\ No newline at end of file

Spacing +5 added lines, -5 removed lines

@@ -96,17 +96,17 @@ 
                 $commonAncestorCommitInfo = $this->getMergeBaseCommit($notMergedBranchInfo['branchName'], $stableBranch);
                 $stableBranchLastCommitInfo = $this->getBranchLastCommitInfo($stableBranch);
 
-                if ($lrAheadCommitsCount[$stableBranch] >= (int)$this->config['threshold-commits-behind']) {
+                if ($lrAheadCommitsCount[$stableBranch] >= (int) $this->config['threshold-commits-behind']) {
                     $failed = true;
                 }
 
                 $interval = $this->compareCommitInfosDatesDiff($commonAncestorCommitInfo, $stableBranchLastCommitInfo);
-                if ((int)$interval->format('%r%a') >= (int)$this->config['threshold-days-behind']) {
+                if ((int) $interval->format('%r%a') >= (int) $this->config['threshold-days-behind']) {
                     $failed = true;
                 }
 
                 if ($failed) {
-                    $message = sprintf('The branch <fg=green>%s</> is behind <fg=green>%s</> by %s commits spread through %s days.', $notMergedBranchInfo['branchName'], $stableBranch, $lrAheadCommitsCount[$stableBranch], (int)$interval->format('%r%a'));
+                    $message = sprintf('The branch <fg=green>%s</> is behind <fg=green>%s</> by %s commits spread through %s days.', $notMergedBranchInfo['branchName'], $stableBranch, $lrAheadCommitsCount[$stableBranch], (int) $interval->format('%r%a'));
                     $message .= sprintf(' <fg=green>%s</> should update the branch %s', $notMergedBranchInfo['authorName'], $notMergedBranchInfo['branchName']);
                     throw new ExpectationFailedException($notMergedBranchInfo, $message);
                 }
@@ -279,8 +279,8 @@ 
         $branchesRegex = ['^$'];
 
         if (is_array($this->config[$configKey]) && count($this->config[$configKey])) {
-            $branchesRegex = array_map(function ($element) {
-                return '\(^[ ]*'.$element.'$\)';
+            $branchesRegex = array_map(function($element) {
+                return '\(^[ ]*' . $element . '$\)';
             }, $this->config[$configKey]);
         }
 

src/Iterator/RuleFilterIterator.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      * @param \Iterator $iterator
      * @param array   $ruleNames
      */
-    public function __construct(\Iterator $iterator , array $ruleNames = [])
+    public function __construct(\Iterator $iterator, array $ruleNames = [])
     {
         parent::__construct($iterator);
         $this->ruleNames = $ruleNames;

src/Application/Output/UIHelper.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
         $output->writeln(sprintf('<error>%s: KO</error>', $rule::getRuleName()));
 
         foreach ($e->getExpectationFailedExceptions() as $expectationFailedException) {
-            $reason = ($expectationFailedException->getReason()) ? sprintf(' Reason: %s', $expectationFailedException->getReason()): '';
+            $reason = ($expectationFailedException->getReason()) ? sprintf(' Reason: %s', $expectationFailedException->getReason()) : '';
             $output->writeln(sprintf('<comment>Expectation failed: %s.%s</comment>', $expectationFailedException->getMessage(), $reason));
         }
     }

src/Rule/CurlRule.php

Doc Comments +2 added lines, -2 removed lines

@@ -74,7 +74,7 @@ 
 
     /**
      * @param  array $expectedResponse
-     * @param  array $response
+     * @param  Response $response
      *
      * @throws ExpectationFailedException
      */
@@ -97,7 +97,7 @@ 
 
     /**
      * @param  array $expectedResponse
-     * @param  array $response
+     * @param  Response $response
      *
      * @throws ExpectationFailedException
      */

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 namespace ProjectQualityInspector\Rule;
 
-use ProjectQualityInspector\Application\ProcessHelper;
 use ProjectQualityInspector\Exception\ExpectationFailedException;
 use GuzzleHttp\Psr7\Request;
 use GuzzleHttp\Psr7\Response;