Inspection of "Rename String and Void classes" - Qeti/POData - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

unknown

created 2017-02-18 23:13 UTC

Status

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -12,10 +12,8 @@
 block discarded – undo
 use POData\Providers\Metadata\ResourceTypeKind;
 use POData\Providers\Metadata\ResourcePropertyKind;
 use POData\Providers\Metadata\ResourceProperty;
-use POData\Providers\ProvidersWrapper;
 use POData\Providers\Metadata\Type\Binary;
 use POData\Providers\Metadata\Type\Boolean;
-use POData\Providers\Metadata\Type\StringType;
 use POData\Providers\Metadata\Type\DateTime;
 use POData\Common\ODataException;
 use POData\Common\Messages;

Please login to merge, or discard this patch.

src/POData/Providers/Metadata/ResourceType.php 2 patches

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -15,12 +15,10 @@
 block discarded – undo
 use POData\Providers\Metadata\Type\SByte;
 use POData\Providers\Metadata\Type\Single;
 use POData\Providers\Metadata\Type\StringType;
-use POData\Providers\Metadata\Type\TypeCode;
 use POData\Providers\Metadata\Type\EdmPrimitiveType;
 use POData\Providers\Metadata\Type\IType;
 use POData\Common\Messages;
 use POData\Common\InvalidOperationException;
-use POData\Common;
 
 /**
  * Class ResourceType

Please login to merge, or discard this patch.

Switch Indentation +96 added lines, -96 removed lines patch added patch discarded remove patch

@@ -826,102 +826,102 @@
 block discarded – undo
     public static function getPrimitiveResourceType($typeCode)
     {
         switch($typeCode) {
-        case EdmPrimitiveType::BINARY:
-            return new ResourceType(
-                new Binary(), ResourceTypeKind::PRIMITIVE, 
-                'Binary', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::BOOLEAN:
-            return new ResourceType(
-                new Boolean(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Boolean', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::BYTE:
-            return new ResourceType(
-                new Byte(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Byte', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::DATETIME:
-            return new ResourceType(
-                new DateTime(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'DateTime', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::DECIMAL:
-            return new ResourceType(
-                new Decimal(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Decimal', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::DOUBLE:
-            return new ResourceType(
-                new Double(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Double', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::GUID:
-            return new ResourceType(
-                new Guid(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Guid', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::INT16:
-            return new ResourceType(
-                new Int16(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Int16', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::INT32:
-            return new ResourceType(
-                new Int32(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Int32', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::INT64:
-            return new ResourceType(
-                new Int64(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Int64', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::SBYTE:
-            return new ResourceType(
-                new SByte(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'SByte', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::SINGLE:
-            return new ResourceType(
-                new Single(), 
-                ResourceTypeKind::PRIMITIVE, 
-                'Single', 'Edm'
-            );
-            break;
-        case EdmPrimitiveType::STRING:
-            return new ResourceType(
-                new StringType(),
-                ResourceTypeKind::PRIMITIVE, 
-                'String', 'Edm'
-            );
-            break;
-        default:
-            throw new \InvalidArgumentException(
-                Messages::commonNotValidPrimitiveEDMType(
-                    '$typeCode', 'getPrimitiveResourceType'
-                )
-            );
+            case EdmPrimitiveType::BINARY:
+                return new ResourceType(
+                    new Binary(), ResourceTypeKind::PRIMITIVE, 
+                    'Binary', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::BOOLEAN:
+                return new ResourceType(
+                    new Boolean(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Boolean', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::BYTE:
+                return new ResourceType(
+                    new Byte(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Byte', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::DATETIME:
+                return new ResourceType(
+                    new DateTime(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'DateTime', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::DECIMAL:
+                return new ResourceType(
+                    new Decimal(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Decimal', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::DOUBLE:
+                return new ResourceType(
+                    new Double(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Double', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::GUID:
+                return new ResourceType(
+                    new Guid(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Guid', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::INT16:
+                return new ResourceType(
+                    new Int16(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Int16', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::INT32:
+                return new ResourceType(
+                    new Int32(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Int32', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::INT64:
+                return new ResourceType(
+                    new Int64(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Int64', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::SBYTE:
+                return new ResourceType(
+                    new SByte(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'SByte', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::SINGLE:
+                return new ResourceType(
+                    new Single(), 
+                    ResourceTypeKind::PRIMITIVE, 
+                    'Single', 'Edm'
+                );
+                break;
+            case EdmPrimitiveType::STRING:
+                return new ResourceType(
+                    new StringType(),
+                    ResourceTypeKind::PRIMITIVE, 
+                    'String', 'Edm'
+                );
+                break;
+            default:
+                throw new \InvalidArgumentException(
+                    Messages::commonNotValidPrimitiveEDMType(
+                        '$typeCode', 'getPrimitiveResourceType'
+                    )
+                );
         }    
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

src/POData/UriProcessor/QueryProcessor/FunctionDescription.php 1 patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

@@ -6,7 +6,6 @@  discard block
 block discarded – undo
 use POData\Common\Messages;
 use POData\Common\ODataConstants;
 use POData\Providers\Metadata\Type\Null1;
-use POData\Providers\Metadata\Type\INavigationType;
 use POData\Providers\Metadata\Type\Int64;
 use POData\Providers\Metadata\Type\Int16;
 use POData\Providers\Metadata\Type\Guid;
@@ -17,10 +16,8 @@  discard block
 block discarded – undo
 use POData\Providers\Metadata\Type\Int32;
 use POData\Providers\Metadata\Type\StringType;
 use POData\Providers\Metadata\Type\Boolean;
-use POData\Providers\Metadata\Type\VoidType;
 use POData\Providers\Metadata\Type\Binary;
 use POData\Providers\Metadata\Type\IType;
-use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\ExpressionType;
 use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\AbstractExpression;
 use POData\UriProcessor\QueryProcessor\ExpressionParser\ExpressionToken;
 

Please login to merge, or discard this patch.

UriProcessor/QueryProcessor/SkipTokenParser/InternalSkipTokenInfo.php 1 patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

@@ -2,10 +2,7 @@
 block discarded – undo
 
 namespace POData\UriProcessor\QueryProcessor\SkipTokenParser;
 
-use POData\Providers\Metadata\Type\Guid;
 use POData\Providers\Metadata\Type\Null1;
-use POData\Providers\Metadata\Type\DateTime;
-use POData\Providers\Metadata\Type\StringType;
 use POData\Providers\Metadata\ResourceType;
 use POData\UriProcessor\QueryProcessor\OrderByParser\InternalOrderByInfo;
 use POData\Common\Messages;

Please login to merge, or discard this patch.

POData/UriProcessor/QueryProcessor/ExpressionParser/ExpressionParser.php 1 patch

Switch Indentation +31 added lines, -31 removed lines patch added patch discarded remove patch

@@ -363,37 +363,37 @@
 block discarded – undo
     private function _parsePrimaryStart()
     {
         switch ($this->_lexer->getCurrentToken()->Id) {
-        case ExpressionTokenId::BOOLEAN_LITERAL:
-            return $this->_parseTypedLiteral(new Boolean());
-        case ExpressionTokenId::DATETIME_LITERAL:
-            return $this->_parseTypedLiteral(new DateTime());
-        case ExpressionTokenId::DECIMAL_LITERAL:
-            return $this->_parseTypedLiteral(new Decimal());
-        case ExpressionTokenId::NULL_LITERAL:
-            return $this->_parseNullLiteral();
-        case ExpressionTokenId::IDENTIFIER:
-            return $this->_parseIdentifier();
-        case ExpressionTokenId::STRING_LITERAL:
-            return $this->_parseTypedLiteral(new StringType());
-        case ExpressionTokenId::INT64_LITERAL:
-            return $this->_parseTypedLiteral(new Int64());
-        case ExpressionTokenId::INTEGER_LITERAL:
-            return $this->_parseTypedLiteral(new Int32());
-        case ExpressionTokenId::DOUBLE_LITERAL:
-            return $this->_parseTypedLiteral(new Double());
-        case ExpressionTokenId::SINGLE_LITERAL:
-            return $this->_parseTypedLiteral(new Single());
-        case ExpressionTokenId::GUID_LITERAL:
-            return $this->_parseTypedLiteral(new Guid());
-        case ExpressionTokenId::BINARY_LITERAL:
-            throw new NotImplementedException(
-                'Support for binary is not implemented'
-            );
-            //return $this->_parseTypedLiteral(new Binary());
-        case ExpressionTokenId::OPENPARAM:
-            return $this->_parseParenExpression();
-        default:
-            throw ODataException::createSyntaxError("Expression expected.");
+            case ExpressionTokenId::BOOLEAN_LITERAL:
+                return $this->_parseTypedLiteral(new Boolean());
+            case ExpressionTokenId::DATETIME_LITERAL:
+                return $this->_parseTypedLiteral(new DateTime());
+            case ExpressionTokenId::DECIMAL_LITERAL:
+                return $this->_parseTypedLiteral(new Decimal());
+            case ExpressionTokenId::NULL_LITERAL:
+                return $this->_parseNullLiteral();
+            case ExpressionTokenId::IDENTIFIER:
+                return $this->_parseIdentifier();
+            case ExpressionTokenId::STRING_LITERAL:
+                return $this->_parseTypedLiteral(new StringType());
+            case ExpressionTokenId::INT64_LITERAL:
+                return $this->_parseTypedLiteral(new Int64());
+            case ExpressionTokenId::INTEGER_LITERAL:
+                return $this->_parseTypedLiteral(new Int32());
+            case ExpressionTokenId::DOUBLE_LITERAL:
+                return $this->_parseTypedLiteral(new Double());
+            case ExpressionTokenId::SINGLE_LITERAL:
+                return $this->_parseTypedLiteral(new Single());
+            case ExpressionTokenId::GUID_LITERAL:
+                return $this->_parseTypedLiteral(new Guid());
+            case ExpressionTokenId::BINARY_LITERAL:
+                throw new NotImplementedException(
+                    'Support for binary is not implemented'
+                );
+                //return $this->_parseTypedLiteral(new Binary());
+            case ExpressionTokenId::OPENPARAM:
+                return $this->_parseParenExpression();
+            default:
+                throw ODataException::createSyntaxError("Expression expected.");
         }
     }
 

Please login to merge, or discard this patch.

POData/UriProcessor/ResourcePathProcessor/SegmentParser/KeyDescriptor.php 1 patch

Switch Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -470,39 +470,39 @@
 block discarded – undo
     private static function _getTypeAndValidateKeyValue($value, $tokenId, &$outValue, &$outType)
     {     
         switch ($tokenId) {
-        case ExpressionTokenId::BOOLEAN_LITERAL:
-            $outType = new Boolean();
-            break;
-        case ExpressionTokenId::DATETIME_LITERAL:
-            $outType = new DateTime();
-            break;
-        case ExpressionTokenId::GUID_LITERAL:
-            $outType = new Guid();
-            break;
-        case ExpressionTokenId::STRING_LITERAL:
-            $outType = new StringType();
-            break;
-        case ExpressionTokenId::INTEGER_LITERAL:
-            $outType = new Int32();
-            break;
-        case ExpressionTokenId::DECIMAL_LITERAL:
-            $outType = new Decimal();
-            break;
-        case ExpressionTokenId::DOUBLE_LITERAL:
-            $outType = new Double();
-            break;
-        case ExpressionTokenId::INT64_LITERAL:
-            $outType = new Int64();
-            break;
-        case ExpressionTokenId::SINGLE_LITERAL:
-            $outType = new Single();
-            break;
-        case ExpressionTokenId::NULL_LITERAL:
-            $outType = new Null1();
-            break;
-        default:
-            $outType = null;
-            return false;
+            case ExpressionTokenId::BOOLEAN_LITERAL:
+                $outType = new Boolean();
+                break;
+            case ExpressionTokenId::DATETIME_LITERAL:
+                $outType = new DateTime();
+                break;
+            case ExpressionTokenId::GUID_LITERAL:
+                $outType = new Guid();
+                break;
+            case ExpressionTokenId::STRING_LITERAL:
+                $outType = new StringType();
+                break;
+            case ExpressionTokenId::INTEGER_LITERAL:
+                $outType = new Int32();
+                break;
+            case ExpressionTokenId::DECIMAL_LITERAL:
+                $outType = new Decimal();
+                break;
+            case ExpressionTokenId::DOUBLE_LITERAL:
+                $outType = new Double();
+                break;
+            case ExpressionTokenId::INT64_LITERAL:
+                $outType = new Int64();
+                break;
+            case ExpressionTokenId::SINGLE_LITERAL:
+                $outType = new Single();
+                break;
+            case ExpressionTokenId::NULL_LITERAL:
+                $outType = new Null1();
+                break;
+            default:
+                $outType = null;
+                return false;
         }
 
         if (!$outType->validate($value, $outValue)) {

Please login to merge, or discard this patch.

		@@ -363,37 +363,37 @@
		block discarded – undo
363	363	private function _parsePrimaryStart()
364	364	{
365	365	switch ($this->_lexer->getCurrentToken()->Id) {
366		- case ExpressionTokenId::BOOLEAN_LITERAL:
367		- return $this->_parseTypedLiteral(new Boolean());
368		- case ExpressionTokenId::DATETIME_LITERAL:
369		- return $this->_parseTypedLiteral(new DateTime());
370		- case ExpressionTokenId::DECIMAL_LITERAL:
371		- return $this->_parseTypedLiteral(new Decimal());
372		- case ExpressionTokenId::NULL_LITERAL:
373		- return $this->_parseNullLiteral();
374		- case ExpressionTokenId::IDENTIFIER:
375		- return $this->_parseIdentifier();
376		- case ExpressionTokenId::STRING_LITERAL:
377		- return $this->_parseTypedLiteral(new StringType());
378		- case ExpressionTokenId::INT64_LITERAL:
379		- return $this->_parseTypedLiteral(new Int64());
380		- case ExpressionTokenId::INTEGER_LITERAL:
381		- return $this->_parseTypedLiteral(new Int32());
382		- case ExpressionTokenId::DOUBLE_LITERAL:
383		- return $this->_parseTypedLiteral(new Double());
384		- case ExpressionTokenId::SINGLE_LITERAL:
385		- return $this->_parseTypedLiteral(new Single());
386		- case ExpressionTokenId::GUID_LITERAL:
387		- return $this->_parseTypedLiteral(new Guid());
388		- case ExpressionTokenId::BINARY_LITERAL:
389		- throw new NotImplementedException(
390		- 'Support for binary is not implemented'
391		- );
392		- //return $this->_parseTypedLiteral(new Binary());
393		- case ExpressionTokenId::OPENPARAM:
394		- return $this->_parseParenExpression();
395		- default:
396		- throw ODataException::createSyntaxError("Expression expected.");
	366	+ case ExpressionTokenId::BOOLEAN_LITERAL:
	367	+ return $this->_parseTypedLiteral(new Boolean());
	368	+ case ExpressionTokenId::DATETIME_LITERAL:
	369	+ return $this->_parseTypedLiteral(new DateTime());
	370	+ case ExpressionTokenId::DECIMAL_LITERAL:
	371	+ return $this->_parseTypedLiteral(new Decimal());
	372	+ case ExpressionTokenId::NULL_LITERAL:
	373	+ return $this->_parseNullLiteral();
	374	+ case ExpressionTokenId::IDENTIFIER:
	375	+ return $this->_parseIdentifier();
	376	+ case ExpressionTokenId::STRING_LITERAL:
	377	+ return $this->_parseTypedLiteral(new StringType());
	378	+ case ExpressionTokenId::INT64_LITERAL:
	379	+ return $this->_parseTypedLiteral(new Int64());
	380	+ case ExpressionTokenId::INTEGER_LITERAL:
	381	+ return $this->_parseTypedLiteral(new Int32());
	382	+ case ExpressionTokenId::DOUBLE_LITERAL:
	383	+ return $this->_parseTypedLiteral(new Double());
	384	+ case ExpressionTokenId::SINGLE_LITERAL:
	385	+ return $this->_parseTypedLiteral(new Single());
	386	+ case ExpressionTokenId::GUID_LITERAL:
	387	+ return $this->_parseTypedLiteral(new Guid());
	388	+ case ExpressionTokenId::BINARY_LITERAL:
	389	+ throw new NotImplementedException(
	390	+ 'Support for binary is not implemented'
	391	+ );
	392	+ //return $this->_parseTypedLiteral(new Binary());
	393	+ case ExpressionTokenId::OPENPARAM:
	394	+ return $this->_parseParenExpression();
	395	+ default:
	396	+ throw ODataException::createSyntaxError("Expression expected.");
397	397	}
398	398	}
399	399

		@@ -470,39 +470,39 @@
		block discarded – undo
470	470	private static function _getTypeAndValidateKeyValue($value, $tokenId, &$outValue, &$outType)
471	471	{
472	472	switch ($tokenId) {
473		- case ExpressionTokenId::BOOLEAN_LITERAL:
474		- $outType = new Boolean();
475		- break;
476		- case ExpressionTokenId::DATETIME_LITERAL:
477		- $outType = new DateTime();
478		- break;
479		- case ExpressionTokenId::GUID_LITERAL:
480		- $outType = new Guid();
481		- break;
482		- case ExpressionTokenId::STRING_LITERAL:
483		- $outType = new StringType();
484		- break;
485		- case ExpressionTokenId::INTEGER_LITERAL:
486		- $outType = new Int32();
487		- break;
488		- case ExpressionTokenId::DECIMAL_LITERAL:
489		- $outType = new Decimal();
490		- break;
491		- case ExpressionTokenId::DOUBLE_LITERAL:
492		- $outType = new Double();
493		- break;
494		- case ExpressionTokenId::INT64_LITERAL:
495		- $outType = new Int64();
496		- break;
497		- case ExpressionTokenId::SINGLE_LITERAL:
498		- $outType = new Single();
499		- break;
500		- case ExpressionTokenId::NULL_LITERAL:
501		- $outType = new Null1();
502		- break;
503		- default:
504		- $outType = null;
505		- return false;
	473	+ case ExpressionTokenId::BOOLEAN_LITERAL:
	474	+ $outType = new Boolean();
	475	+ break;
	476	+ case ExpressionTokenId::DATETIME_LITERAL:
	477	+ $outType = new DateTime();
	478	+ break;
	479	+ case ExpressionTokenId::GUID_LITERAL:
	480	+ $outType = new Guid();
	481	+ break;
	482	+ case ExpressionTokenId::STRING_LITERAL:
	483	+ $outType = new StringType();
	484	+ break;
	485	+ case ExpressionTokenId::INTEGER_LITERAL:
	486	+ $outType = new Int32();
	487	+ break;
	488	+ case ExpressionTokenId::DECIMAL_LITERAL:
	489	+ $outType = new Decimal();
	490	+ break;
	491	+ case ExpressionTokenId::DOUBLE_LITERAL:
	492	+ $outType = new Double();
	493	+ break;
	494	+ case ExpressionTokenId::INT64_LITERAL:
	495	+ $outType = new Int64();
	496	+ break;
	497	+ case ExpressionTokenId::SINGLE_LITERAL:
	498	+ $outType = new Single();
	499	+ break;
	500	+ case ExpressionTokenId::NULL_LITERAL:
	501	+ $outType = new Null1();
	502	+ break;
	503	+ default:
	504	+ $outType = null;
	505	+ return false;
506	506	}
507	507
508	508	if (!$outType->validate($value, $outValue)) {

		@@ -12,10 +12,8 @@
		block discarded – undo
12	12	use POData\Providers\Metadata\ResourceTypeKind;
13	13	use POData\Providers\Metadata\ResourcePropertyKind;
14	14	use POData\Providers\Metadata\ResourceProperty;
15		-use POData\Providers\ProvidersWrapper;
16	15	use POData\Providers\Metadata\Type\Binary;
17	16	use POData\Providers\Metadata\Type\Boolean;
18		-use POData\Providers\Metadata\Type\StringType;
19	17	use POData\Providers\Metadata\Type\DateTime;
20	18	use POData\Common\ODataException;
21	19	use POData\Common\Messages;

		@@ -15,12 +15,10 @@
		block discarded – undo
15	15	use POData\Providers\Metadata\Type\SByte;
16	16	use POData\Providers\Metadata\Type\Single;
17	17	use POData\Providers\Metadata\Type\StringType;
18		-use POData\Providers\Metadata\Type\TypeCode;
19	18	use POData\Providers\Metadata\Type\EdmPrimitiveType;
20	19	use POData\Providers\Metadata\Type\IType;
21	20	use POData\Common\Messages;
22	21	use POData\Common\InvalidOperationException;
23		-use POData\Common;
24	22
25	23	/**
26	24	* Class ResourceType

		@@ -826,102 +826,102 @@
		block discarded – undo
826	826	public static function getPrimitiveResourceType($typeCode)
827	827	{
828	828	switch($typeCode) {
829		- case EdmPrimitiveType::BINARY:
830		- return new ResourceType(
831		- new Binary(), ResourceTypeKind::PRIMITIVE,
832		- 'Binary', 'Edm'
833		- );
834		- break;
835		- case EdmPrimitiveType::BOOLEAN:
836		- return new ResourceType(
837		- new Boolean(),
838		- ResourceTypeKind::PRIMITIVE,
839		- 'Boolean', 'Edm'
840		- );
841		- break;
842		- case EdmPrimitiveType::BYTE:
843		- return new ResourceType(
844		- new Byte(),
845		- ResourceTypeKind::PRIMITIVE,
846		- 'Byte', 'Edm'
847		- );
848		- break;
849		- case EdmPrimitiveType::DATETIME:
850		- return new ResourceType(
851		- new DateTime(),
852		- ResourceTypeKind::PRIMITIVE,
853		- 'DateTime', 'Edm'
854		- );
855		- break;
856		- case EdmPrimitiveType::DECIMAL:
857		- return new ResourceType(
858		- new Decimal(),
859		- ResourceTypeKind::PRIMITIVE,
860		- 'Decimal', 'Edm'
861		- );
862		- break;
863		- case EdmPrimitiveType::DOUBLE:
864		- return new ResourceType(
865		- new Double(),
866		- ResourceTypeKind::PRIMITIVE,
867		- 'Double', 'Edm'
868		- );
869		- break;
870		- case EdmPrimitiveType::GUID:
871		- return new ResourceType(
872		- new Guid(),
873		- ResourceTypeKind::PRIMITIVE,
874		- 'Guid', 'Edm'
875		- );
876		- break;
877		- case EdmPrimitiveType::INT16:
878		- return new ResourceType(
879		- new Int16(),
880		- ResourceTypeKind::PRIMITIVE,
881		- 'Int16', 'Edm'
882		- );
883		- break;
884		- case EdmPrimitiveType::INT32:
885		- return new ResourceType(
886		- new Int32(),
887		- ResourceTypeKind::PRIMITIVE,
888		- 'Int32', 'Edm'
889		- );
890		- break;
891		- case EdmPrimitiveType::INT64:
892		- return new ResourceType(
893		- new Int64(),
894		- ResourceTypeKind::PRIMITIVE,
895		- 'Int64', 'Edm'
896		- );
897		- break;
898		- case EdmPrimitiveType::SBYTE:
899		- return new ResourceType(
900		- new SByte(),
901		- ResourceTypeKind::PRIMITIVE,
902		- 'SByte', 'Edm'
903		- );
904		- break;
905		- case EdmPrimitiveType::SINGLE:
906		- return new ResourceType(
907		- new Single(),
908		- ResourceTypeKind::PRIMITIVE,
909		- 'Single', 'Edm'
910		- );
911		- break;
912		- case EdmPrimitiveType::STRING:
913		- return new ResourceType(
914		- new StringType(),
915		- ResourceTypeKind::PRIMITIVE,
916		- 'String', 'Edm'
917		- );
918		- break;
919		- default:
920		- throw new \InvalidArgumentException(
921		- Messages::commonNotValidPrimitiveEDMType(
922		- '$typeCode', 'getPrimitiveResourceType'
923		- )
924		- );
	829	+ case EdmPrimitiveType::BINARY:
	830	+ return new ResourceType(
	831	+ new Binary(), ResourceTypeKind::PRIMITIVE,
	832	+ 'Binary', 'Edm'
	833	+ );
	834	+ break;
	835	+ case EdmPrimitiveType::BOOLEAN:
	836	+ return new ResourceType(
	837	+ new Boolean(),
	838	+ ResourceTypeKind::PRIMITIVE,
	839	+ 'Boolean', 'Edm'
	840	+ );
	841	+ break;
	842	+ case EdmPrimitiveType::BYTE:
	843	+ return new ResourceType(
	844	+ new Byte(),
	845	+ ResourceTypeKind::PRIMITIVE,
	846	+ 'Byte', 'Edm'
	847	+ );
	848	+ break;
	849	+ case EdmPrimitiveType::DATETIME:
	850	+ return new ResourceType(
	851	+ new DateTime(),
	852	+ ResourceTypeKind::PRIMITIVE,
	853	+ 'DateTime', 'Edm'
	854	+ );
	855	+ break;
	856	+ case EdmPrimitiveType::DECIMAL:
	857	+ return new ResourceType(
	858	+ new Decimal(),
	859	+ ResourceTypeKind::PRIMITIVE,
	860	+ 'Decimal', 'Edm'
	861	+ );
	862	+ break;
	863	+ case EdmPrimitiveType::DOUBLE:
	864	+ return new ResourceType(
	865	+ new Double(),
	866	+ ResourceTypeKind::PRIMITIVE,
	867	+ 'Double', 'Edm'
	868	+ );
	869	+ break;
	870	+ case EdmPrimitiveType::GUID:
	871	+ return new ResourceType(
	872	+ new Guid(),
	873	+ ResourceTypeKind::PRIMITIVE,
	874	+ 'Guid', 'Edm'
	875	+ );
	876	+ break;
	877	+ case EdmPrimitiveType::INT16:
	878	+ return new ResourceType(
	879	+ new Int16(),
	880	+ ResourceTypeKind::PRIMITIVE,
	881	+ 'Int16', 'Edm'
	882	+ );
	883	+ break;
	884	+ case EdmPrimitiveType::INT32:
	885	+ return new ResourceType(
	886	+ new Int32(),
	887	+ ResourceTypeKind::PRIMITIVE,
	888	+ 'Int32', 'Edm'
	889	+ );
	890	+ break;
	891	+ case EdmPrimitiveType::INT64:
	892	+ return new ResourceType(
	893	+ new Int64(),
	894	+ ResourceTypeKind::PRIMITIVE,
	895	+ 'Int64', 'Edm'
	896	+ );
	897	+ break;
	898	+ case EdmPrimitiveType::SBYTE:
	899	+ return new ResourceType(
	900	+ new SByte(),
	901	+ ResourceTypeKind::PRIMITIVE,
	902	+ 'SByte', 'Edm'
	903	+ );
	904	+ break;
	905	+ case EdmPrimitiveType::SINGLE:
	906	+ return new ResourceType(
	907	+ new Single(),
	908	+ ResourceTypeKind::PRIMITIVE,
	909	+ 'Single', 'Edm'
	910	+ );
	911	+ break;
	912	+ case EdmPrimitiveType::STRING:
	913	+ return new ResourceType(
	914	+ new StringType(),
	915	+ ResourceTypeKind::PRIMITIVE,
	916	+ 'String', 'Edm'
	917	+ );
	918	+ break;
	919	+ default:
	920	+ throw new \InvalidArgumentException(
	921	+ Messages::commonNotValidPrimitiveEDMType(
	922	+ '$typeCode', 'getPrimitiveResourceType'
	923	+ )
	924	+ );
925	925	}
926	926	}
927	927	}
928	928	\ No newline at end of file

		@@ -6,7 +6,6 @@ discard block
		block discarded – undo
6	6	use POData\Common\Messages;
7	7	use POData\Common\ODataConstants;
8	8	use POData\Providers\Metadata\Type\Null1;
9		-use POData\Providers\Metadata\Type\INavigationType;
10	9	use POData\Providers\Metadata\Type\Int64;
11	10	use POData\Providers\Metadata\Type\Int16;
12	11	use POData\Providers\Metadata\Type\Guid;
		@@ -17,10 +16,8 @@ discard block
		block discarded – undo
17	16	use POData\Providers\Metadata\Type\Int32;
18	17	use POData\Providers\Metadata\Type\StringType;
19	18	use POData\Providers\Metadata\Type\Boolean;
20		-use POData\Providers\Metadata\Type\VoidType;
21	19	use POData\Providers\Metadata\Type\Binary;
22	20	use POData\Providers\Metadata\Type\IType;
23		-use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\ExpressionType;
24	21	use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\AbstractExpression;
25	22	use POData\UriProcessor\QueryProcessor\ExpressionParser\ExpressionToken;
26	23

		@@ -2,10 +2,7 @@
		block discarded – undo
2	2
3	3	namespace POData\UriProcessor\QueryProcessor\SkipTokenParser;
4	4
5		-use POData\Providers\Metadata\Type\Guid;
6	5	use POData\Providers\Metadata\Type\Null1;
7		-use POData\Providers\Metadata\Type\DateTime;
8		-use POData\Providers\Metadata\Type\StringType;
9	6	use POData\Providers\Metadata\ResourceType;
10	7	use POData\UriProcessor\QueryProcessor\OrderByParser\InternalOrderByInfo;
11	8	use POData\Common\Messages;

Qeti / POData

Pull Request — master (#1)

Status

Category

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Switch Indentation +96 added lines, -96 removed lines patch added patch discarded remove patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

Unused Use Statements -3 removed lines patch added patch discarded remove patch

Switch Indentation +31 added lines, -31 removed lines patch added patch discarded remove patch

Switch Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch