PyRowMan / pheanstalk

src/Pheanstalk.php

Spacing +6 added lines, -6 removed lines

@@ -133,13 +133,13 @@ 
     {
         $status = empty($status) ? GetWorkflowInstancesDetailCommand::FILTERS : [$status];
         $instances = new ArrayCollection([]);
-        foreach($status as $stat) {
+        foreach ($status as $stat) {
             $instances[strtolower($stat)] = $this->_dispatch(new Command\GetWorkflowInstancesCommand($workflow, $stat));
 //            if ($stat === GetWorkflowInstancesCommand::FILTER_EXECUTING) {
                 /** @var ArrayCollection $workflowCollection */
                 $workflowCollection = $instances[strtolower($stat)]->get('workflow_instances');
                 if (!empty($workflowCollection)) {
-                    foreach($workflowCollection as $instance) {
+                    foreach ($workflowCollection as $instance) {
                         $this->getCurrentClass()->getWorkflowInstancesDetails($instance);
                     }
                 }
@@ -238,22 +238,22 @@ 
      */
     public function create(Workflow $workflow, $force = false): Workflow
     {
-        try{
+        try {
             $tubes = [];
             /** @var Job $job */
-            foreach($workflow->getJobs() as $job) {
+            foreach ($workflow->getJobs() as $job) {
                 /** @var Task $task */
                 foreach ($job->getTasks() as $task) {
                     $tubes = array_merge($tubes, [$task->getQueue()]);
                 }
             }
-            foreach($tubes as $tube) {
+            foreach ($tubes as $tube) {
                 if (!$this->getCurrentClass()->tubeExists($tube)) {
                     $this->getCurrentClass()->createTube(new Tube($tube, 1));
                 };
             }
             $workflow = $this->_dispatch(new Command\CreateCommand($workflow));
-        } catch(ServerDuplicateEntryException $e) {
+        } catch (ServerDuplicateEntryException $e) {
             if ($force) {
                 $workflows = $this->_dispatch(new Command\ListWorkflowsCommand());
                 $workflowToDelete = $workflows->filter(function(Workflow $listedWorkflow) use ($workflow) {

Braces +3 added lines, -2 removed lines

@@ -113,8 +113,9 @@
     public function workflowExists($name)
     {
         $workflow = $this->_dispatch(new Command\WorkflowExistsCommand($name));
-        if ($workflow instanceof Workflow)
-            return $this->getCurrentClass()->getWorkflow($workflow);
+        if ($workflow instanceof Workflow) {
+                    return $this->getCurrentClass()->getWorkflow($workflow);
+        }
         return false;
     }
 

src/Structure/Task.php

Spacing +1 added lines, -1 removed lines

@@ -199,7 +199,7 @@
         $reflection = new \ReflectionClass($this);
         $dom = new \DOMDocument("1.0", "utf-8");
         $root = $dom->createElement("task");
-        foreach($reflection->getProperties() as $property)
+        foreach ($reflection->getProperties() as $property)
         {
             $value = $this->{'get' . ucfirst($property->getName())}();
             $root->setAttribute($this->from_camel_case($property->getName()), $value);

src/Structure/WorkflowInstance.php

Spacing +2 added lines, -2 removed lines

@@ -73,9 +73,9 @@
                     $this->{$property->getName()} = $params[$snakeProperty];
             }
             if (!is_null($this->getRunningTasks()) && !is_null($this->getQueuedTasks())
-                && $this->getRunningTasks() - $this->getQueuedTasks() > 0 )
+                && $this->getRunningTasks() - $this->getQueuedTasks() > 0)
                 $this->setStatus(self::STATUS_RUNNING);
-            if (!is_null($this->getQueuedTasks()) && $this->getQueuedTasks() > 0 )
+            if (!is_null($this->getQueuedTasks()) && $this->getQueuedTasks() > 0)
                 $this->setStatus(self::STATUS_QUEUED);
             if (!is_null($this->getRetryingTasks()) && $this->getRetryingTasks() > 0)
                 $this->setStatus(self::STATUS_RETRYING);

Braces +15 added lines, -10 removed lines

@@ -69,18 +69,23 @@
         $properties = $thisObject->getProperties();
             foreach ($properties as $property) {
                 $snakeProperty = $this->from_camel_case($property->getName());
-                if (isset($params[$snakeProperty]))
-                    $this->{$property->getName()} = $params[$snakeProperty];
+                if (isset($params[$snakeProperty])) {
+                                    $this->{$property->getName()} = $params[$snakeProperty];
+                }
             }
             if (!is_null($this->getRunningTasks()) && !is_null($this->getQueuedTasks())
-                && $this->getRunningTasks() - $this->getQueuedTasks() > 0 )
-                $this->setStatus(self::STATUS_RUNNING);
-            if (!is_null($this->getQueuedTasks()) && $this->getQueuedTasks() > 0 )
-                $this->setStatus(self::STATUS_QUEUED);
-            if (!is_null($this->getRetryingTasks()) && $this->getRetryingTasks() > 0)
-                $this->setStatus(self::STATUS_RETRYING);
-            if (!is_null($this->getErrors()) && $this->getErrors() > 0)
-                $this->setStatus(self::STATUS_FAILED);
+                && $this->getRunningTasks() - $this->getQueuedTasks() > 0 ) {
+                            $this->setStatus(self::STATUS_RUNNING);
+            }
+            if (!is_null($this->getQueuedTasks()) && $this->getQueuedTasks() > 0 ) {
+                            $this->setStatus(self::STATUS_QUEUED);
+            }
+            if (!is_null($this->getRetryingTasks()) && $this->getRetryingTasks() > 0) {
+                            $this->setStatus(self::STATUS_RETRYING);
+            }
+            if (!is_null($this->getErrors()) && $this->getErrors() > 0) {
+                            $this->setStatus(self::STATUS_FAILED);
+            }
     }
 
     /**

src/Structure/Workflow.php

Spacing +1 added lines, -1 removed lines

@@ -234,7 +234,7 @@
         $root = $dom->createElement("workflow");
         $subjobs = $dom->createElement("subjobs");
         /** @var Job $job*/
-        foreach($this->getJobs() as $job) {
+        foreach ($this->getJobs() as $job) {
             $jobNode = $job->getXml()->getElementsByTagName('job')->item(0);
             $subjobs->appendChild($dom->importNode($jobNode, true));
 

src/Structure/Job.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
         $root = $dom->createElement("job");
         $tasks = $dom->createElement("tasks");
         /** @var Task $task */
-        foreach($this->getTasks() as $task) {
+        foreach ($this->getTasks() as $task) {
             $taskItem = $dom->createElement("task");
             $taskNode = $task->getXml()->getElementsByTagName('task')->item(0);
             $tasks->appendChild($dom->importNode($taskNode, true));

src/Structure/TaskInstance.php

Braces +3 added lines, -2 removed lines

@@ -39,8 +39,9 @@
         $properties = $thisObject->getProperties();
         foreach ($properties as $property) {
             $snakeProperty = $this->from_camel_case($property->getName());
-            if (isset($params[$snakeProperty]))
-                $this->{$property->getName()} = $params[$snakeProperty];
+            if (isset($params[$snakeProperty])) {
+                            $this->{$property->getName()} = $params[$snakeProperty];
+            }
         }
     }
 

src/Structure/TimeSchedule.php

Spacing +5 added lines, -5 removed lines

@@ -66,7 +66,7 @@ 
      */
     public function setSeconds(array $seconds): TimeSchedule
     {
-        if (count( $seconds ) !== count( array_filter( $seconds, 'is_numeric' )) || array_sum($seconds) > self::SUM_SUBUNIT_IN_UNIT )
+        if (count($seconds) !== count(array_filter($seconds, 'is_numeric')) || array_sum($seconds) > self::SUM_SUBUNIT_IN_UNIT)
             throw new \Exception('Wrong units of time');
         $this->seconds = $seconds;
         return $this;
@@ -87,7 +87,7 @@ 
      */
     public function setMinutes(array $minutes): TimeSchedule
     {
-        if (count( $minutes ) !== count( array_filter( $minutes, 'is_numeric' )) || array_sum($minutes) > self::SUM_SUBUNIT_IN_UNIT )
+        if (count($minutes) !== count(array_filter($minutes, 'is_numeric')) || array_sum($minutes) > self::SUM_SUBUNIT_IN_UNIT)
             throw new \Exception('Wrong units of time');
         $this->minutes = $minutes;
         return $this;
@@ -108,7 +108,7 @@ 
      */
     public function setHours(array $hours): TimeSchedule
     {
-        if (count( $hours ) !== count( array_filter( $hours, 'is_numeric' )) || array_sum($hours) > self::SUM_HOURS )
+        if (count($hours) !== count(array_filter($hours, 'is_numeric')) || array_sum($hours) > self::SUM_HOURS)
             throw new \Exception('Wrong units of time');
         $this->hours = $hours;
         return $this;
@@ -129,7 +129,7 @@ 
      */
     public function setDays(array $days): TimeSchedule
     {
-        if (count( $days ) !== count( array_filter( $days, 'is_numeric' )) || array_sum($days) > self::SUM_DAYS )
+        if (count($days) !== count(array_filter($days, 'is_numeric')) || array_sum($days) > self::SUM_DAYS)
             throw new \Exception('Wrong units of time');
         $this->days = $days;
         return $this;
@@ -150,7 +150,7 @@ 
      */
     public function setMonths(array $months): TimeSchedule
     {
-        if (count( $months ) !== count( array_filter( $months, 'is_numeric' )) || array_sum($months) > self::SUM_MONTHS )
+        if (count($months) !== count(array_filter($months, 'is_numeric')) || array_sum($months) > self::SUM_MONTHS)
         throw new \Exception('Wrong units of time');
         $this->months = $months;
         return $this;

Braces +15 added lines, -10 removed lines

@@ -66,8 +66,9 @@ 
      */
     public function setSeconds(array $seconds): TimeSchedule
     {
-        if (count( $seconds ) !== count( array_filter( $seconds, 'is_numeric' )) || array_sum($seconds) > self::SUM_SUBUNIT_IN_UNIT )
-            throw new \Exception('Wrong units of time');
+        if (count( $seconds ) !== count( array_filter( $seconds, 'is_numeric' )) || array_sum($seconds) > self::SUM_SUBUNIT_IN_UNIT ) {
+                    throw new \Exception('Wrong units of time');
+        }
         $this->seconds = $seconds;
         return $this;
     }
@@ -87,8 +88,9 @@ 
      */
     public function setMinutes(array $minutes): TimeSchedule
     {
-        if (count( $minutes ) !== count( array_filter( $minutes, 'is_numeric' )) || array_sum($minutes) > self::SUM_SUBUNIT_IN_UNIT )
-            throw new \Exception('Wrong units of time');
+        if (count( $minutes ) !== count( array_filter( $minutes, 'is_numeric' )) || array_sum($minutes) > self::SUM_SUBUNIT_IN_UNIT ) {
+                    throw new \Exception('Wrong units of time');
+        }
         $this->minutes = $minutes;
         return $this;
     }
@@ -108,8 +110,9 @@ 
      */
     public function setHours(array $hours): TimeSchedule
     {
-        if (count( $hours ) !== count( array_filter( $hours, 'is_numeric' )) || array_sum($hours) > self::SUM_HOURS )
-            throw new \Exception('Wrong units of time');
+        if (count( $hours ) !== count( array_filter( $hours, 'is_numeric' )) || array_sum($hours) > self::SUM_HOURS ) {
+                    throw new \Exception('Wrong units of time');
+        }
         $this->hours = $hours;
         return $this;
     }
@@ -129,8 +132,9 @@ 
      */
     public function setDays(array $days): TimeSchedule
     {
-        if (count( $days ) !== count( array_filter( $days, 'is_numeric' )) || array_sum($days) > self::SUM_DAYS )
-            throw new \Exception('Wrong units of time');
+        if (count( $days ) !== count( array_filter( $days, 'is_numeric' )) || array_sum($days) > self::SUM_DAYS ) {
+                    throw new \Exception('Wrong units of time');
+        }
         $this->days = $days;
         return $this;
     }
@@ -150,8 +154,9 @@ 
      */
     public function setMonths(array $months): TimeSchedule
     {
-        if (count( $months ) !== count( array_filter( $months, 'is_numeric' )) || array_sum($months) > self::SUM_MONTHS )
-        throw new \Exception('Wrong units of time');
+        if (count( $months ) !== count( array_filter( $months, 'is_numeric' )) || array_sum($months) > self::SUM_MONTHS ) {
+                throw new \Exception('Wrong units of time');
+        }
         $this->months = $months;
         return $this;
     }

src/Structure/Tube.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
     public function setDynamic($dynamic): Tube
     {
         if (!is_bool($dynamic)) {
-            if($dynamic === self::IS_NOT_DYNAMIC)
+            if ($dynamic === self::IS_NOT_DYNAMIC)
                 $dynamic = false;
             else
                 $dynamic = true;

Braces +5 added lines, -4 removed lines

@@ -100,10 +100,11 @@
     public function setDynamic($dynamic): Tube
     {
         if (!is_bool($dynamic)) {
-            if($dynamic === self::IS_NOT_DYNAMIC)
-                $dynamic = false;
-            else
-                $dynamic = true;
+            if($dynamic === self::IS_NOT_DYNAMIC) {
+                            $dynamic = false;
+            } else {
+                            $dynamic = true;
+            }
         }
         $this->dynamic = $dynamic;
         return $this;

src/Connection.php

Spacing +3 added lines, -3 removed lines

@@ -105,7 +105,7 @@ 
         }
         $xml = new \SimpleXMLElement($responseLine);
         $json = json_encode($xml);
-        $responseLine = json_decode($json,TRUE);
+        $responseLine = json_decode($json, TRUE);
         $responseName = preg_replace('#^(\S+).*$#s', '$1', $responseLine["@attributes"]['status']);
         if ($responseName === "KO") {
             $exceptionType = $responseLine['@attributes']['error-code'] ?? Response::RESPONSE_SERVER_ERROR;
@@ -192,10 +192,10 @@ 
         return $this->_socket;
     }
 
-    protected function build_query($name, $action = false, $attributes = [], $parameters = []){
+    protected function build_query($name, $action = false, $attributes = [], $parameters = []) {
         $dom = new \DOMDocument("1.0", "utf-8");
         $root = $dom->createElement($name);
-        if($action)
+        if ($action)
             $root->setAttribute('action', $action);
         foreach ($attributes as $key => $value) {
             $root->setAttribute($key, $value);

Braces +3 added lines, -2 removed lines

@@ -195,8 +195,9 @@
     protected function build_query($name, $action = false, $attributes = [], $parameters = []){
         $dom = new \DOMDocument("1.0", "utf-8");
         $root = $dom->createElement($name);
-        if($action)
-            $root->setAttribute('action', $action);
+        if($action) {
+                    $root->setAttribute('action', $action);
+        }
         foreach ($attributes as $key => $value) {
             $root->setAttribute($key, $value);
         }