PyRowMan / pheanstalk

scripts/build_phar.php

Spacing +2 added lines, -2 removed lines

@@ -1,9 +1,9 @@
 #!/usr/bin/env php
 <?php
 
-define('BASE_DIR', realpath(__DIR__.'/..'));
+define('BASE_DIR', realpath(__DIR__ . '/..'));
 define('PHAR_FILENAME', 'pheanstalk.phar');
-define('PHAR_FULLPATH', BASE_DIR.'/'.PHAR_FILENAME);
+define('PHAR_FULLPATH', BASE_DIR . '/' . PHAR_FILENAME);
 
 // ----------------------------------------
 

src/Socket/NativeSocket.php

Spacing +5 added lines, -6 removed lines

@@ -43,7 +43,7 @@ 
         }
 
         if (!$this->_socket) {
-            throw new Exception\ConnectionException($errno, $errstr." (connecting to $host:$port)");
+            throw new Exception\ConnectionException($errno, $errstr . " (connecting to $host:$port)");
         }
 
         $this->_wrapper()
@@ -101,7 +101,7 @@ 
     public function recv()
     {
         $response = "";
-        while($recv = $this->_wrapper()->fread($this->_socket, 1600)){
+        while ($recv = $this->_wrapper()->fread($this->_socket, 1600)) {
             $response .= $recv;
         }
         return $response;
@@ -123,14 +123,13 @@ 
         do {
             libxml_clear_errors();
                 $data .= isset($length) ?
-                    $this->_wrapper()->fgets($this->_socket, $length) :
-                    $this->_wrapper()->fgets($this->_socket);
+                    $this->_wrapper()->fgets($this->_socket, $length) : $this->_wrapper()->fgets($this->_socket);
             simplexml_load_string($data);
             if (!empty(libxml_get_errors()) && microtime(true) - $timer > $timeout) {
                 $this->disconnect();
                 throw new Exception\SocketException('Socket timed out!');
-            } elseif(empty(libxml_get_errors())) {
-                try{
+            } elseif (empty(libxml_get_errors())) {
+                try {
                     $xml = new \SimpleXMLElement($data);
                 } catch (\Exception $e) {
                     $error = (string) (isset($xml['error'])) ? $xml['error'] : 'Socket closed by server!';

src/Command/CreateScheduleCommand.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
         $this->workflow = $workflow;
         $this->schedule = $schedule;
         $this->onFailure = $onFailure ?? self::FAILURE_TYPE_CONTINUE;
-        $this->active = $active ?? true ;
+        $this->active = $active ?? true;
         $this->comment = $comment ?? $this->workflow->getComment();
     }
 

src/Command/TubeExistsCommand.php

Spacing +1 added lines, -1 removed lines

@@ -42,6 +42,6 @@
             return $tube->getName() === $name;
         });
 
-        return !$matchingTubes->isEmpty() ?  $matchingTubes->first() : false;
+        return !$matchingTubes->isEmpty() ? $matchingTubes->first() : false;
     }
 }

src/Command/GetWorkflowInstancesDetailCommand.php

Spacing +3 added lines, -3 removed lines

@@ -72,13 +72,13 @@
 
         $subjobs = $responseData['workflow']['subjobs'];
         $jobInstances = new ArrayCollection([]);
-        foreach($subjobs as $subjob) {
+        foreach ($subjobs as $subjob) {
             $taskInstances = new ArrayCollection([]);
-            foreach($subjob['tasks'] as $tasks) {
+            foreach ($subjob['tasks'] as $tasks) {
                 $task = $tasks['@attributes'];
 
                 if (isset($task['execution_time'])) $task['execution_time'] = new \DateTime($task['execution_time']);
-                foreach($task as $key => $val)
+                foreach ($task as $key => $val)
                     if (ctype_digit($val)) $task[$key] = (int) $task[$key];
                 $taskInstances[] = new TaskInstance($task);
             }

Braces +9 added lines, -5 removed lines

@@ -67,8 +67,9 @@ 
     public function parseResponse($responseLine, $responseData)
     {
 
-        if (!(isset($responseData['workflow'])))
-            return false;
+        if (!(isset($responseData['workflow']))) {
+                    return false;
+        }
 
         $subjobs = $responseData['workflow']['subjobs'];
         $jobInstances = new ArrayCollection([]);
@@ -77,9 +78,12 @@ 
             foreach($subjob['tasks'] as $tasks) {
                 $task = $tasks['@attributes'];
 
-                if (isset($task['execution_time'])) $task['execution_time'] = new \DateTime($task['execution_time']);
-                foreach($task as $key => $val)
-                    if (ctype_digit($val)) $task[$key] = (int) $task[$key];
+                if (isset($task['execution_time'])) {
+                    $task['execution_time'] = new \DateTime($task['execution_time']);
+                }
+                foreach($task as $key => $val) {
+                                    if (ctype_digit($val)) $task[$key] = (int) $task[$key];
+                }
                 $taskInstances[] = new TaskInstance($task);
             }
             $jobInstances[] = new JobInstance($taskInstances);

src/Command/PeekCommand.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
         $responseData = array_column($responseData, '@attributes');
         $dates = array_column($responseData, 'start_time');
         $mostRecent = [];
-        foreach($responseData as $date){
+        foreach ($responseData as $date) {
             $curDate = strtotime($date['start_time']);
             if (!isset($mostRecent['start_time']) || $curDate < strtotime($mostRecent['start_time'])) {
                 $mostRecent = $date;

Braces +3 added lines, -1 removed lines

@@ -79,7 +79,9 @@
                 $mostRecent = $date;
             }
         }
-        if (empty($responseData)) return $this->parseResponse($responseLine, $responseData);
+        if (empty($responseData)) {
+            return $this->parseResponse($responseLine, $responseData);
+        }
         return $this->_createResponse(
             Response::RESPONSE_FOUND,
             array(

src/Command/GetWorkflowCommand.php

Spacing +2 added lines, -2 removed lines

@@ -67,9 +67,9 @@
         $jobs = $workflow['workflow']['subjobs'];
         $workflow = $workflow['@attributes'] ?? $workflow;
         $jobObjects = [];
-        foreach($jobs as $job) {
+        foreach ($jobs as $job) {
             $taskObjects = [];
-            foreach($job['tasks'] as $task) {
+            foreach ($job['tasks'] as $task) {
                 $task = $task['@attributes'];
                 $taskObjects[] = new Task($task['path'], $task['queue'], $task['use-agent'], $task['user'], $task['host'], $task['output-method'], $task['parameters-mode']);
             }

src/Command/WorkflowExistsCommand.php

Spacing +1 added lines, -1 removed lines

@@ -42,6 +42,6 @@
             return $workflow->getName() === $name;
         });
 
-        return !$matchingWorkflows->isEmpty() ?  $matchingWorkflows->first() : false;
+        return !$matchingWorkflows->isEmpty() ? $matchingWorkflows->first() : false;
     }
 }

src/Command/GetWorkflowInstancesCommand.php

Spacing +4 added lines, -5 removed lines

@@ -91,20 +91,19 @@
         if (!(isset($responseData['workflow'])))
             return new ArrayCollection([]);
 
-        $instances = $responseData['workflow'] ;
+        $instances = $responseData['workflow'];
         $instances = isset($instances['tags']) ? [$instances['@attributes']] : $instances;
         $workflowInstances = new ArrayCollection([]);
-        foreach($instances as $instance) {
+        foreach ($instances as $instance) {
             $instance = $instance['@attributes'] ?? $instance;
             if (isset($instance['start_time'])) $instance['start_time'] = new \DateTime($instance['start_time']);
             if (isset($instance['end_time'])) $instance['end_time'] = new \DateTime($instance['end_time']);
-            foreach($instance as $key => $val)
+            foreach ($instance as $key => $val)
                 if (ctype_digit($val)) $instance[$key] = (int) $instance[$key];
             $workflowInstances[] = new WorkflowInstance($instance);
         }
         $collection['rows'] = (int) (isset($responseData['@attributes']['rows'])) ?
-            (int) $responseData['@attributes']['rows'] :
-            $workflowInstances->count();
+            (int) $responseData['@attributes']['rows'] : $workflowInstances->count();
         $collection['page'] = $this->page;
         $collection['workflow_instances'] = $workflowInstances;
         return new ArrayCollection($collection);

Braces +15 added lines, -8 removed lines

@@ -76,8 +76,9 @@ 
             'offset' => $offset,
             'limit' => $limit
         ];
-        if (!empty($this->workflow))
-            $filters['filter_workflow'] = $this->workflow->getName();
+        if (!empty($this->workflow)) {
+                    $filters['filter_workflow'] = $this->workflow->getName();
+        }
 
         return $filters;
     }
@@ -88,18 +89,24 @@ 
     public function parseResponse($responseLine, $responseData)
     {
 
-        if (!(isset($responseData['workflow'])))
-            return new ArrayCollection([]);
+        if (!(isset($responseData['workflow']))) {
+                    return new ArrayCollection([]);
+        }
 
         $instances = $responseData['workflow'] ;
         $instances = isset($instances['tags']) ? [$instances['@attributes']] : $instances;
         $workflowInstances = new ArrayCollection([]);
         foreach($instances as $instance) {
             $instance = $instance['@attributes'] ?? $instance;
-            if (isset($instance['start_time'])) $instance['start_time'] = new \DateTime($instance['start_time']);
-            if (isset($instance['end_time'])) $instance['end_time'] = new \DateTime($instance['end_time']);
-            foreach($instance as $key => $val)
-                if (ctype_digit($val)) $instance[$key] = (int) $instance[$key];
+            if (isset($instance['start_time'])) {
+                $instance['start_time'] = new \DateTime($instance['start_time']);
+            }
+            if (isset($instance['end_time'])) {
+                $instance['end_time'] = new \DateTime($instance['end_time']);
+            }
+            foreach($instance as $key => $val) {
+                            if (ctype_digit($val)) $instance[$key] = (int) $instance[$key];
+            }
             $workflowInstances[] = new WorkflowInstance($instance);
         }
         $collection['rows'] = (int) (isset($responseData['@attributes']['rows'])) ?