JsonLdPropertyFormatterTest::validProvider() - Code Metrics - ProjetPP/PPP-Wikidata - Measure and Improve Code Quality continuously with Scrutinizer

JsonLdPropertyFormatterTest::validProvider() A
last analyzed 2017-11-28 20:07 UTC

↳ Parent: JsonLdPropertyFormatterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	1
eloc	11
nc	1
nop	0

<?php

namespace PPP\Wikidata\ValueFormatters\JsonLd\Entity;

use PPP\Wikidata\ValueFormatters\JsonLd\JsonLdFormatterTestBase;
use ValueFormatters\FormatterOptions;
use ValueFormatters\ValueFormatter;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\Entity\PropertyId;

/**
 * @covers PPP\Wikidata\ValueFormatters\JsonLd\Entity\JsonLdPropertyFormatter
 *
 * @licence AGPLv3+
 * @author Thomas Pellissier Tanon
 */
class JsonLdPropertyFormatterTest extends JsonLdFormatterTestBase {

	/**
	 * @see JsonLdFormatterTestBase::validProvider
	 */
	public function validProvider() {
		return array(
			array(
				new Property(new PropertyId('P214'), null, 'string'),
				(object) array(
					'@type' => 'Property',
					'@id' => 'http://www.wikidata.org/entity/P214',
					'name' => 'P214'
				),
				new FormatterOptions(array(
					ValueFormatter::OPT_LANG => 'en',
					JsonLdEntityFormatter::OPT_ENTITY_BASE_URI => 'http://www.wikidata.org/entity/'
				))
			)
		);
	}

	/**
	 * @see JsonLdFormatterTestBase::getInstance
	 */
	protected function getInstance(FormatterOptions $options = null) {
		return new JsonLdPropertyFormatter(
			new JsonLdEntityFormatter($options),
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
			$options
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
		);
	}
}


1			<?php
2
3			namespace PPP\Wikidata\ValueFormatters\JsonLd\Entity;
4
5			use PPP\Wikidata\ValueFormatters\JsonLd\JsonLdFormatterTestBase;
6			use ValueFormatters\FormatterOptions;
7			use ValueFormatters\ValueFormatter;
8			use Wikibase\DataModel\Entity\Property;
9			use Wikibase\DataModel\Entity\PropertyId;
10
11			/**
12			* @covers PPP\Wikidata\ValueFormatters\JsonLd\Entity\JsonLdPropertyFormatter
13			*
14			* @licence AGPLv3+
15			* @author Thomas Pellissier Tanon
16			*/
17			class JsonLdPropertyFormatterTest extends JsonLdFormatterTestBase {
18
19			/**
20			* @see JsonLdFormatterTestBase::validProvider
21			*/
22			public function validProvider() {
23			return array(
24			array(
25			new Property(new PropertyId('P214'), null, 'string'),
26			(object) array(
27			'@type' => 'Property',
28			'@id' => 'http://www.wikidata.org/entity/P214',
29			'name' => 'P214'
30			),
31			new FormatterOptions(array(
32			ValueFormatter::OPT_LANG => 'en',
33			JsonLdEntityFormatter::OPT_ENTITY_BASE_URI => 'http://www.wikidata.org/entity/'
34			))
35			)
36			);
37			}
38
39			/**
40			* @see JsonLdFormatterTestBase::getInstance
41			*/
42			protected function getInstance(FormatterOptions $options = null) {
43			return new JsonLdPropertyFormatter(
44			new JsonLdEntityFormatter($options),
			0 ignored issues – show Bug introduced 2016-04-01 14:15 UTC by Report Bug Copy Issue Report It seems like `$options` defined by parameter `$options` on line `42` can be `null`; however, `PPP\Wikidata\ValueFormat...ormatter::__construct()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
45			$options
			0 ignored issues – show Bug introduced 2016-04-01 14:15 UTC by Report Bug Copy Issue Report It seems like `$options` defined by parameter `$options` on line `42` can be `null`; however, `PPP\Wikidata\ValueFormat...ormatter::__construct()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
46			);
47			}
48			}
49

ProjetPP / PPP-Wikidata

JsonLdPropertyFormatterTest::validProvider() A last analyzed 2017-11-28 20:07 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

JsonLdPropertyFormatterTest::validProvider() A
last analyzed 2017-11-28 20:07 UTC