PPP\Wikidata\ValueFormatters\JsonLd\Entity\JsonLdPropertyFormatterTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	validProvider()	0	16	1
A	getInstance()	0	6	1

<?php

namespace PPP\Wikidata\ValueFormatters\JsonLd\Entity;

use PPP\Wikidata\ValueFormatters\JsonLd\JsonLdFormatterTestBase;
use ValueFormatters\FormatterOptions;
use ValueFormatters\ValueFormatter;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\Entity\PropertyId;

/**
 * @covers PPP\Wikidata\ValueFormatters\JsonLd\Entity\JsonLdPropertyFormatter
 *
 * @licence AGPLv3+
 * @author Thomas Pellissier Tanon
 */
class JsonLdPropertyFormatterTest extends JsonLdFormatterTestBase {

	/**
	 * @see JsonLdFormatterTestBase::validProvider
	 */
	public function validProvider() {
		return array(
			array(
				new Property(new PropertyId('P214'), null, 'string'),
				(object) array(
					'@type' => 'Property',
					'@id' => 'http://www.wikidata.org/entity/P214',
					'name' => 'P214'
				),
				new FormatterOptions(array(
					ValueFormatter::OPT_LANG => 'en',
					JsonLdEntityFormatter::OPT_ENTITY_BASE_URI => 'http://www.wikidata.org/entity/'
				))
			)
		);
	}

	/**
	 * @see JsonLdFormatterTestBase::getInstance
	 */
	protected function getInstance(FormatterOptions $options = null) {
		return new JsonLdPropertyFormatter(
			new JsonLdEntityFormatter($options),

It seems like $options defined by parameter $options on line 42 can be null; however, PPP\Wikidata\ValueFormatters\JsonLd\Entity\JsonLdEntityFormatter::__construct() does not accept null, maybe add an additional type check?

			$options

It seems like $options defined by parameter $options on line 42 can be null; however, PPP\Wikidata\ValueFormatters\JsonLd\Entity\JsonLdPropertyFormatter::__construct() does not accept null, maybe add an additional type check?

		);
	}
}