Passed
Push — master ( 873606...f8e942 )
by Stephan
08:04
created
src/BootstrapManager.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -49,9 +49,9 @@  discard block
 block discarded – undo
49 49
 	 *
50 50
 	 * @param ModuleDefinition $moduleDefinition
51 51
 	 */
52
-	public function __construct( ModuleDefinition $moduleDefinition ) {
52
+	public function __construct(ModuleDefinition $moduleDefinition) {
53 53
 		$this->moduleDefinition = $moduleDefinition;
54
-		$this->moduleDescriptions = $this->moduleDefinition->get( 'descriptions' );
54
+		$this->moduleDescriptions = $this->moduleDefinition->get('descriptions');
55 55
 	}
56 56
 
57 57
 	/**
@@ -63,8 +63,8 @@  discard block
 block discarded – undo
63 63
 	 */
64 64
 	public static function getInstance() {
65 65
 
66
-		if ( self::$instance === null ) {
67
-			self::$instance = new self( new V4ModuleDefinition );
66
+		if (self::$instance === null) {
67
+			self::$instance = new self(new V4ModuleDefinition);
68 68
 		}
69 69
 
70 70
 		return self::$instance;
@@ -84,29 +84,29 @@  discard block
 block discarded – undo
84 84
 	 *
85 85
 	 * @param string|string[] $modules
86 86
 	 */
87
-	public function addBootstrapModule( $modules ) {
87
+	public function addBootstrapModule($modules) {
88 88
 
89 89
 		$modules = (array) $modules;
90 90
 
91
-		foreach ( $modules as $module ) {
91
+		foreach ($modules as $module) {
92 92
 
93 93
 			// if the module is known
94
-			if ( isset( $this->moduleDescriptions[ $module ] ) ) {
94
+			if (isset($this->moduleDescriptions[$module])) {
95 95
 
96
-				$description = $this->moduleDescriptions[ $module ];
96
+				$description = $this->moduleDescriptions[$module];
97 97
 
98 98
 				// prevent adding this module again; this also prevents infinite recursion in case
99 99
 				// of dependency resolution
100
-				unset( $this->moduleDescriptions[ $module ] );
100
+				unset($this->moduleDescriptions[$module]);
101 101
 
102 102
 				// first add any dependencies recursively, so they are available when the styles and
103 103
 				// scripts of $module are loaded
104
-				if ( isset( $description[ 'dependencies' ] ) ) {
105
-					$this->addBootstrapModule( $description[ 'dependencies' ] );
104
+				if (isset($description['dependencies'])) {
105
+					$this->addBootstrapModule($description['dependencies']);
106 106
 				}
107 107
 
108
-				$this->addFilesToGlobalResourceModules( 'styles', $description );
109
-				$this->addFilesToGlobalResourceModules( 'scripts', $description );
108
+				$this->addFilesToGlobalResourceModules('styles', $description);
109
+				$this->addFilesToGlobalResourceModules('scripts', $description);
110 110
 
111 111
 			}
112 112
 		}
@@ -116,11 +116,11 @@  discard block
 block discarded – undo
116 116
 	 * @param string       $filetype 'styles'|'scripts'
117 117
 	 * @param mixed[]      $description
118 118
 	 */
119
-	protected function addFilesToGlobalResourceModules ( $filetype, $description ) {
119
+	protected function addFilesToGlobalResourceModules($filetype, $description) {
120 120
 
121
-		if ( isset( $description[ $filetype ] ) ) {
121
+		if (isset($description[$filetype])) {
122 122
 
123
-			$this->adjustArrayElementOfResourceModuleDescription( $filetype, $description[ $filetype ], $filetype );
123
+			$this->adjustArrayElementOfResourceModuleDescription($filetype, $description[$filetype], $filetype);
124 124
 
125 125
 		}
126 126
 	}
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 	 * @since  4.0
132 132
 	 */
133 133
 	public function addCoreBootstrapModules() {
134
-		$this->addBootstrapModule( $this->moduleDefinition->get( 'core' ) );
134
+		$this->addBootstrapModule($this->moduleDefinition->get('core'));
135 135
 	}
136 136
 
137 137
 	/**
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 	 * @since  1.0
141 141
 	 */
142 142
 	public function addAllBootstrapModules() {
143
-		$this->addBootstrapModule( $this->moduleDefinition->get( 'optional' ) );
143
+		$this->addBootstrapModule($this->moduleDefinition->get('optional'));
144 144
 	}
145 145
 
146 146
 	/**
@@ -151,8 +151,8 @@  discard block
 block discarded – undo
151 151
 	 *
152 152
 	 * @internal param string $path
153 153
 	 */
154
-	public function addStyleFile( $path, $position = 'main' ) {
155
-		$this->adjustArrayElementOfResourceModuleDescription( 'styles', [ $path => [ 'position' => $position ] ] );
154
+	public function addStyleFile($path, $position = 'main') {
155
+		$this->adjustArrayElementOfResourceModuleDescription('styles', [$path => ['position' => $position]]);
156 156
 	}
157 157
 
158 158
 	/**
@@ -161,8 +161,8 @@  discard block
 block discarded – undo
161 161
 	 * @param string $key   the SCSS variable name
162 162
 	 * @param string $value the value to assign to the variable
163 163
 	 */
164
-	public function setScssVariable( $key, $value ) {
165
-		$this->setScssVariables( [ $key => $value ] );
164
+	public function setScssVariable($key, $value) {
165
+		$this->setScssVariables([$key => $value]);
166 166
 	}
167 167
 
168 168
 	/**
@@ -170,16 +170,16 @@  discard block
 block discarded – undo
170 170
 	 *
171 171
 	 * @param mixed[] $variables
172 172
 	 */
173
-	public function setScssVariables( $variables ) {
174
-		$this->adjustArrayElementOfResourceModuleDescription( 'variables', $variables );
173
+	public function setScssVariables($variables) {
174
+		$this->adjustArrayElementOfResourceModuleDescription('variables', $variables);
175 175
 	}
176 176
 
177 177
 	/**
178 178
 	 * @since 1.1
179 179
 	 * @param string|string[] $files
180 180
 	 */
181
-	public function addCacheTriggerFile( $files ){
182
-		$this->adjustArrayElementOfResourceModuleDescription( 'cacheTriggers', $files );
181
+	public function addCacheTriggerFile($files) {
182
+		$this->adjustArrayElementOfResourceModuleDescription('cacheTriggers', $files);
183 183
 	}
184 184
 
185 185
 	/**
@@ -187,15 +187,15 @@  discard block
 block discarded – undo
187 187
 	 * @param mixed  $value
188 188
 	 * @param string $filetype 'styles'|'scripts'
189 189
 	 */
190
-	protected function adjustArrayElementOfResourceModuleDescription( $key, $value, $filetype = 'styles' ) {
190
+	protected function adjustArrayElementOfResourceModuleDescription($key, $value, $filetype = 'styles') {
191 191
 
192
-		if (!isset($GLOBALS[ 'wgResourceModules' ][ 'ext.bootstrap.' . $filetype ][ $key ])) {
193
-			$GLOBALS[ 'wgResourceModules' ][ 'ext.bootstrap.' . $filetype ][ $key ] = [];
192
+		if (!isset($GLOBALS['wgResourceModules']['ext.bootstrap.' . $filetype][$key])) {
193
+			$GLOBALS['wgResourceModules']['ext.bootstrap.' . $filetype][$key] = [];
194 194
 		}
195 195
 
196
-		$GLOBALS[ 'wgResourceModules' ][ 'ext.bootstrap.' . $filetype ][ $key ] =
196
+		$GLOBALS['wgResourceModules']['ext.bootstrap.' . $filetype][$key] =
197 197
 			array_merge(
198
-				$GLOBALS[ 'wgResourceModules' ][ 'ext.bootstrap.' . $filetype ][ $key ],
198
+				$GLOBALS['wgResourceModules']['ext.bootstrap.' . $filetype][$key],
199 199
 				(array) $value
200 200
 			);
201 201
 	}
Please login to merge, or discard this patch.