Inspection of "fix issue with popover" - ProfessionalWiki/Bootstrap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#43)

unknown

created 2020-12-17 15:44 UTC

Status

Spacing +61 added lines, -61 removed lines patch added patch discarded remove patch

@@ -34,66 +34,66 @@  discard block
 block discarded – undo
 class V4ModuleDefinition implements ModuleDefinition {
 
 	private static $moduleDescriptions = [
-		'functions'         => [ 'styles' => [ 'functions' => [ 'position' => 'functions' ] ] ],
-		'variables'         => [ 'styles' =>
-			[ 'variables' => [ 'position' => 'variables' ] ], 'dependencies' => 'functions' ],
-		'mixins'            => [ 'styles' => 'mixins' ],
-		'root'              => [ 'styles' => 'root' ],
-		'reboot'            => [ 'styles' => 'reboot' ],
-		'type'              => [ 'styles' => 'type' ],
-		'images'            => [ 'styles' => 'images' ],
-		'code'              => [ 'styles' => 'code' ],
-		'grid'              => [ 'styles' => 'grid' ],
-		'tables'            => [ 'styles' => 'tables' ],
-		'forms'             => [ 'styles' => 'forms' ],
-		'buttons'           => [ 'styles' => 'buttons' ],
-		'transitions'       => [ 'styles' => 'transitions' ],
-		'dropdown'          => [ 'styles' =>
-			'dropdown', 'scripts' => 'dropdown.js', 'dependencies' => [ 'popper', 'js-util' ] ],
-		'button-group'      => [ 'styles' => 'button-group', 'dependencies' => [ 'buttons' ] ],
-		'input-group'       => [ 'styles' => 'input-group', 'dependencies' => [ 'forms' ] ],
-		'custom-forms'      => [ 'styles' => 'custom-forms' ],
-		'nav'               => [ 'styles' => 'nav' ],
-		'navbar'            => [ 'styles' => 'navbar' ],
-		'card'              => [ 'styles' => 'card' ],
-		'breadcrumb'        => [ 'styles' => 'breadcrumb' ],
-		'pagination'        => [ 'styles' => 'pagination' ],
-		'badge'             => [ 'styles' => 'badge' ],
-		'jumbotron'         => [ 'styles' => 'jumbotron' ],
-		'alert'             => [ 'styles' => 'alert' ],
-		'progress'          => [ 'styles' => 'progress' ],
-		'media'             => [ 'styles' => 'media' ],
-		'list-group'        => [ 'styles' => 'list-group' ],
-		'close'             => [ 'styles' => 'close' ],
-		'toasts'            => [ 'styles' =>
-			'toasts', 'scripts' => 'toast.js', 'dependencies' => 'js-util' ],
-		'modal'             => [ 'styles' => 'modal', 'scripts' => 'modal.js' ],
-		'tooltip'           => [ 'styles' => 'tooltip', 'scripts' => 'tooltip.js', 'dependencies' => [ 'popper', 'js-util' ] ],
-		'popover'           => [ 'styles' =>
-			'popover', 'scripts' => 'popover.js', 'dependencies' => [ 'popper', 'tooltip', 'js-util' ] ],
-		'carousel'          => [ 'styles' =>
-			'carousel', 'scripts' => 'carousel.js', 'dependencies' => 'js-util' ],
-		'spinners'          => [ 'styles' => 'spinners' ],
-		'utilities'         => [ 'styles' => 'utilities' ],
-		'print'             => [ 'styles' => 'print' ],
-		'active-buttons'    => [ 'scripts' => 'button.js', 'dependencies' => [ 'buttons' ] ],
-		'dismissable-alert' => [ 'scripts' => 'alert.js', 'dependencies' => [ 'alert', 'js-util' ] ],
-		'collapse'          => [ 'scripts' => 'collapse.js' ],
-		'scrollspy'         => [ 'scripts' => 'scrollspy.js', 'dependencies' => [ 'popper', 'js-util' ] ],
-		'tab'               => [ 'scripts' => 'tab.js', 'dependencies' => [ 'list-group' ] ],
-		'js-util'           => [ 'scripts' => 'util.js' ],
-		'popper'            => [ 'scripts' => 'popper.js' ],
+		'functions'         => ['styles' => ['functions' => ['position' => 'functions']]],
+		'variables'         => ['styles' =>
+			['variables' => ['position' => 'variables']], 'dependencies' => 'functions'],
+		'mixins'            => ['styles' => 'mixins'],
+		'root'              => ['styles' => 'root'],
+		'reboot'            => ['styles' => 'reboot'],
+		'type'              => ['styles' => 'type'],
+		'images'            => ['styles' => 'images'],
+		'code'              => ['styles' => 'code'],
+		'grid'              => ['styles' => 'grid'],
+		'tables'            => ['styles' => 'tables'],
+		'forms'             => ['styles' => 'forms'],
+		'buttons'           => ['styles' => 'buttons'],
+		'transitions'       => ['styles' => 'transitions'],
+		'dropdown'          => ['styles' =>
+			'dropdown', 'scripts' => 'dropdown.js', 'dependencies' => ['popper', 'js-util']],
+		'button-group'      => ['styles' => 'button-group', 'dependencies' => ['buttons']],
+		'input-group'       => ['styles' => 'input-group', 'dependencies' => ['forms']],
+		'custom-forms'      => ['styles' => 'custom-forms'],
+		'nav'               => ['styles' => 'nav'],
+		'navbar'            => ['styles' => 'navbar'],
+		'card'              => ['styles' => 'card'],
+		'breadcrumb'        => ['styles' => 'breadcrumb'],
+		'pagination'        => ['styles' => 'pagination'],
+		'badge'             => ['styles' => 'badge'],
+		'jumbotron'         => ['styles' => 'jumbotron'],
+		'alert'             => ['styles' => 'alert'],
+		'progress'          => ['styles' => 'progress'],
+		'media'             => ['styles' => 'media'],
+		'list-group'        => ['styles' => 'list-group'],
+		'close'             => ['styles' => 'close'],
+		'toasts'            => ['styles' =>
+			'toasts', 'scripts' => 'toast.js', 'dependencies' => 'js-util'],
+		'modal'             => ['styles' => 'modal', 'scripts' => 'modal.js'],
+		'tooltip'           => ['styles' => 'tooltip', 'scripts' => 'tooltip.js', 'dependencies' => ['popper', 'js-util']],
+		'popover'           => ['styles' =>
+			'popover', 'scripts' => 'popover.js', 'dependencies' => ['popper', 'tooltip', 'js-util']],
+		'carousel'          => ['styles' =>
+			'carousel', 'scripts' => 'carousel.js', 'dependencies' => 'js-util'],
+		'spinners'          => ['styles' => 'spinners'],
+		'utilities'         => ['styles' => 'utilities'],
+		'print'             => ['styles' => 'print'],
+		'active-buttons'    => ['scripts' => 'button.js', 'dependencies' => ['buttons']],
+		'dismissable-alert' => ['scripts' => 'alert.js', 'dependencies' => ['alert', 'js-util']],
+		'collapse'          => ['scripts' => 'collapse.js'],
+		'scrollspy'         => ['scripts' => 'scrollspy.js', 'dependencies' => ['popper', 'js-util']],
+		'tab'               => ['scripts' => 'tab.js', 'dependencies' => ['list-group']],
+		'js-util'           => ['scripts' => 'util.js'],
+		'popper'            => ['scripts' => 'popper.js'],
 
-		'bs-core'   => [ 'dependencies' => [ 'variables', 'mixins' ] ],
-		'bs-reboot' => [ 'dependencies' => [ 'bs-core', 'reboot' ] ],
-		'bs-grid'   => [ 'styles' => 'bootstrap-grid' ],
+		'bs-core'   => ['dependencies' => ['variables', 'mixins']],
+		'bs-reboot' => ['dependencies' => ['bs-core', 'reboot']],
+		'bs-grid'   => ['styles' => 'bootstrap-grid'],
 
-		'bs-basic'  => [ 'dependencies' => [
+		'bs-basic'  => ['dependencies' => [
 			'bs-core', 'root', 'reboot', 'type', 'images', 'code', 'grid',
 			'tables', 'transitions', 'utilities', 'print'
-		] ],
+		]],
 
-		'bs-all'    => [ 'dependencies' => [
+		'bs-all'    => ['dependencies' => [
 			'bs-core', 'root', 'reboot', 'type', 'images', 'code', 'grid',
 			'tables', 'forms', 'buttons', 'transitions', 'dropdown',
 			'button-group', 'input-group', 'custom-forms', 'nav', 'navbar',
@@ -101,15 +101,15 @@  discard block
 block discarded – undo
 			'progress', 'media', 'list-group', 'close', 'toasts', 'modal', 'tooltip',
 			'popover', 'carousel', 'spinners', 'utilities', 'print', 'active-buttons',
 			'dismissable-alert', 'collapse', 'scrollspy', 'tab', 'js-util',
-		] ],
+		]],
 
 		// TODO: Add each SCSS util separately?
 		// TODO: Add each SCSS mixin module separately?
 
 	];
 
-	private static $coreModules = [ 'bs-core' ];
-	private static $optionalModules = [ 'bs-all' ];
+	private static $coreModules = ['bs-core'];
+	private static $optionalModules = ['bs-all'];
 
 	/**
 	 * @see ModuleDefinition::get
@@ -121,8 +121,8 @@  discard block
 block discarded – undo
 	 * @return array
 	 * @throws InvalidArgumentException
 	 */
-	public function get( $key ) {
-		switch ( $key ) {
+	public function get($key) {
+		switch ($key) {
 			case 'core':
 				return self::$coreModules;
 			case 'optional':
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 				return self::$moduleDescriptions;
 		}
 
-		throw new InvalidArgumentException( 'Expected a valid key' );
+		throw new InvalidArgumentException('Expected a valid key');
 	}
 
 }

Please login to merge, or discard this patch.

		@@ -34,66 +34,66 @@ discard block
		block discarded – undo
34	34	class V4ModuleDefinition implements ModuleDefinition {
35	35
36	36	private static $moduleDescriptions = [
37		- 'functions' => [ 'styles' => [ 'functions' => [ 'position' => 'functions' ] ] ],
38		- 'variables' => [ 'styles' =>
39		- [ 'variables' => [ 'position' => 'variables' ] ], 'dependencies' => 'functions' ],
40		- 'mixins' => [ 'styles' => 'mixins' ],
41		- 'root' => [ 'styles' => 'root' ],
42		- 'reboot' => [ 'styles' => 'reboot' ],
43		- 'type' => [ 'styles' => 'type' ],
44		- 'images' => [ 'styles' => 'images' ],
45		- 'code' => [ 'styles' => 'code' ],
46		- 'grid' => [ 'styles' => 'grid' ],
47		- 'tables' => [ 'styles' => 'tables' ],
48		- 'forms' => [ 'styles' => 'forms' ],
49		- 'buttons' => [ 'styles' => 'buttons' ],
50		- 'transitions' => [ 'styles' => 'transitions' ],
51		- 'dropdown' => [ 'styles' =>
52		- 'dropdown', 'scripts' => 'dropdown.js', 'dependencies' => [ 'popper', 'js-util' ] ],
53		- 'button-group' => [ 'styles' => 'button-group', 'dependencies' => [ 'buttons' ] ],
54		- 'input-group' => [ 'styles' => 'input-group', 'dependencies' => [ 'forms' ] ],
55		- 'custom-forms' => [ 'styles' => 'custom-forms' ],
56		- 'nav' => [ 'styles' => 'nav' ],
57		- 'navbar' => [ 'styles' => 'navbar' ],
58		- 'card' => [ 'styles' => 'card' ],
59		- 'breadcrumb' => [ 'styles' => 'breadcrumb' ],
60		- 'pagination' => [ 'styles' => 'pagination' ],
61		- 'badge' => [ 'styles' => 'badge' ],
62		- 'jumbotron' => [ 'styles' => 'jumbotron' ],
63		- 'alert' => [ 'styles' => 'alert' ],
64		- 'progress' => [ 'styles' => 'progress' ],
65		- 'media' => [ 'styles' => 'media' ],
66		- 'list-group' => [ 'styles' => 'list-group' ],
67		- 'close' => [ 'styles' => 'close' ],
68		- 'toasts' => [ 'styles' =>
69		- 'toasts', 'scripts' => 'toast.js', 'dependencies' => 'js-util' ],
70		- 'modal' => [ 'styles' => 'modal', 'scripts' => 'modal.js' ],
71		- 'tooltip' => [ 'styles' => 'tooltip', 'scripts' => 'tooltip.js', 'dependencies' => [ 'popper', 'js-util' ] ],
72		- 'popover' => [ 'styles' =>
73		- 'popover', 'scripts' => 'popover.js', 'dependencies' => [ 'popper', 'tooltip', 'js-util' ] ],
74		- 'carousel' => [ 'styles' =>
75		- 'carousel', 'scripts' => 'carousel.js', 'dependencies' => 'js-util' ],
76		- 'spinners' => [ 'styles' => 'spinners' ],
77		- 'utilities' => [ 'styles' => 'utilities' ],
78		- 'print' => [ 'styles' => 'print' ],
79		- 'active-buttons' => [ 'scripts' => 'button.js', 'dependencies' => [ 'buttons' ] ],
80		- 'dismissable-alert' => [ 'scripts' => 'alert.js', 'dependencies' => [ 'alert', 'js-util' ] ],
81		- 'collapse' => [ 'scripts' => 'collapse.js' ],
82		- 'scrollspy' => [ 'scripts' => 'scrollspy.js', 'dependencies' => [ 'popper', 'js-util' ] ],
83		- 'tab' => [ 'scripts' => 'tab.js', 'dependencies' => [ 'list-group' ] ],
84		- 'js-util' => [ 'scripts' => 'util.js' ],
85		- 'popper' => [ 'scripts' => 'popper.js' ],
	37	+ 'functions' => ['styles' => ['functions' => ['position' => 'functions']]],
	38	+ 'variables' => ['styles' =>
	39	+ ['variables' => ['position' => 'variables']], 'dependencies' => 'functions'],
	40	+ 'mixins' => ['styles' => 'mixins'],
	41	+ 'root' => ['styles' => 'root'],
	42	+ 'reboot' => ['styles' => 'reboot'],
	43	+ 'type' => ['styles' => 'type'],
	44	+ 'images' => ['styles' => 'images'],
	45	+ 'code' => ['styles' => 'code'],
	46	+ 'grid' => ['styles' => 'grid'],
	47	+ 'tables' => ['styles' => 'tables'],
	48	+ 'forms' => ['styles' => 'forms'],
	49	+ 'buttons' => ['styles' => 'buttons'],
	50	+ 'transitions' => ['styles' => 'transitions'],
	51	+ 'dropdown' => ['styles' =>
	52	+ 'dropdown', 'scripts' => 'dropdown.js', 'dependencies' => ['popper', 'js-util']],
	53	+ 'button-group' => ['styles' => 'button-group', 'dependencies' => ['buttons']],
	54	+ 'input-group' => ['styles' => 'input-group', 'dependencies' => ['forms']],
	55	+ 'custom-forms' => ['styles' => 'custom-forms'],
	56	+ 'nav' => ['styles' => 'nav'],
	57	+ 'navbar' => ['styles' => 'navbar'],
	58	+ 'card' => ['styles' => 'card'],
	59	+ 'breadcrumb' => ['styles' => 'breadcrumb'],
	60	+ 'pagination' => ['styles' => 'pagination'],
	61	+ 'badge' => ['styles' => 'badge'],
	62	+ 'jumbotron' => ['styles' => 'jumbotron'],
	63	+ 'alert' => ['styles' => 'alert'],
	64	+ 'progress' => ['styles' => 'progress'],
	65	+ 'media' => ['styles' => 'media'],
	66	+ 'list-group' => ['styles' => 'list-group'],
	67	+ 'close' => ['styles' => 'close'],
	68	+ 'toasts' => ['styles' =>
	69	+ 'toasts', 'scripts' => 'toast.js', 'dependencies' => 'js-util'],
	70	+ 'modal' => ['styles' => 'modal', 'scripts' => 'modal.js'],
	71	+ 'tooltip' => ['styles' => 'tooltip', 'scripts' => 'tooltip.js', 'dependencies' => ['popper', 'js-util']],
	72	+ 'popover' => ['styles' =>
	73	+ 'popover', 'scripts' => 'popover.js', 'dependencies' => ['popper', 'tooltip', 'js-util']],
	74	+ 'carousel' => ['styles' =>
	75	+ 'carousel', 'scripts' => 'carousel.js', 'dependencies' => 'js-util'],
	76	+ 'spinners' => ['styles' => 'spinners'],
	77	+ 'utilities' => ['styles' => 'utilities'],
	78	+ 'print' => ['styles' => 'print'],
	79	+ 'active-buttons' => ['scripts' => 'button.js', 'dependencies' => ['buttons']],
	80	+ 'dismissable-alert' => ['scripts' => 'alert.js', 'dependencies' => ['alert', 'js-util']],
	81	+ 'collapse' => ['scripts' => 'collapse.js'],
	82	+ 'scrollspy' => ['scripts' => 'scrollspy.js', 'dependencies' => ['popper', 'js-util']],
	83	+ 'tab' => ['scripts' => 'tab.js', 'dependencies' => ['list-group']],
	84	+ 'js-util' => ['scripts' => 'util.js'],
	85	+ 'popper' => ['scripts' => 'popper.js'],
86	86
87		- 'bs-core' => [ 'dependencies' => [ 'variables', 'mixins' ] ],
88		- 'bs-reboot' => [ 'dependencies' => [ 'bs-core', 'reboot' ] ],
89		- 'bs-grid' => [ 'styles' => 'bootstrap-grid' ],
	87	+ 'bs-core' => ['dependencies' => ['variables', 'mixins']],
	88	+ 'bs-reboot' => ['dependencies' => ['bs-core', 'reboot']],
	89	+ 'bs-grid' => ['styles' => 'bootstrap-grid'],
90	90
91		- 'bs-basic' => [ 'dependencies' => [
	91	+ 'bs-basic' => ['dependencies' => [
92	92	'bs-core', 'root', 'reboot', 'type', 'images', 'code', 'grid',
93	93	'tables', 'transitions', 'utilities', 'print'
94		- ] ],
	94	+ ]],
95	95
96		- 'bs-all' => [ 'dependencies' => [
	96	+ 'bs-all' => ['dependencies' => [
97	97	'bs-core', 'root', 'reboot', 'type', 'images', 'code', 'grid',
98	98	'tables', 'forms', 'buttons', 'transitions', 'dropdown',
99	99	'button-group', 'input-group', 'custom-forms', 'nav', 'navbar',
		@@ -101,15 +101,15 @@ discard block
		block discarded – undo
101	101	'progress', 'media', 'list-group', 'close', 'toasts', 'modal', 'tooltip',
102	102	'popover', 'carousel', 'spinners', 'utilities', 'print', 'active-buttons',
103	103	'dismissable-alert', 'collapse', 'scrollspy', 'tab', 'js-util',
104		- ] ],
	104	+ ]],
105	105
106	106	// TODO: Add each SCSS util separately?
107	107	// TODO: Add each SCSS mixin module separately?
108	108
109	109	];
110	110
111		- private static $coreModules = [ 'bs-core' ];
112		- private static $optionalModules = [ 'bs-all' ];
	111	+ private static $coreModules = ['bs-core'];
	112	+ private static $optionalModules = ['bs-all'];
113	113
114	114	/**
115	115	* @see ModuleDefinition::get
		@@ -121,8 +121,8 @@ discard block
		block discarded – undo
121	121	* @return array
122	122	* @throws InvalidArgumentException
123	123	*/
124		- public function get( $key ) {
125		- switch ( $key ) {
	124	+ public function get($key) {
	125	+ switch ($key) {
126	126	case 'core':
127	127	return self::$coreModules;
128	128	case 'optional':
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	return self::$moduleDescriptions;
132	132	}
133	133
134		- throw new InvalidArgumentException( 'Expected a valid key' );
	134	+ throw new InvalidArgumentException('Expected a valid key');
135	135	}
136	136
137	137	}

ProfessionalWiki / Bootstrap

Pull Request — master (#43)

Status

Category

Spacing +61 added lines, -61 removed lines patch added patch discarded remove patch