ProfessionalWiki / Bootstrap

SCSS/src/ResourceLoaderSCSSModule.php

Spacing +59 added lines, -59 removed lines

@@ -73,17 +73,17 @@ 
 	 * @param string|null $localBasePath
 	 * @param string|null $remoteBasePath
 	 */
-	public function __construct( $options = [], $localBasePath = null, $remoteBasePath = null ) {
+	public function __construct($options = [], $localBasePath = null, $remoteBasePath = null) {
 
-		parent::__construct( $options, $localBasePath, $remoteBasePath );
+		parent::__construct($options, $localBasePath, $remoteBasePath);
 
-		$this->applyOptions( $options );
+		$this->applyOptions($options);
 	}
 
 	/**
 	 * @param mixed[] $options
 	 */
-	protected function applyOptions( $options ) {
+	protected function applyOptions($options) {
 
 		$mapConfigToLocalVar = [
 			'variables'      => 'variables',
@@ -91,9 +91,9 @@ 
 			'cacheTriggers' => 'cacheTriggers',
 		];
 
-		foreach ( $mapConfigToLocalVar as $config => $local ) {
-			if ( isset( $options[ $config ] ) ) {
-				$this->$local = $options[ $config ];
+		foreach ($mapConfigToLocalVar as $config => $local) {
+			if (isset($options[$config])) {
+				$this->$local = $options[$config];
 			}
 		}
 	}
@@ -105,40 +105,40 @@ 
 	 *
 	 * @return array
 	 */
-	public function getStyles( ResourceLoaderContext $context ) {
+	public function getStyles(ResourceLoaderContext $context) {
 
-		if ( $this->styleText === null ) {
+		if ($this->styleText === null) {
 
-			$this->retrieveStylesFromCache( $context );
+			$this->retrieveStylesFromCache($context);
 
-			if ( $this->styleText === null ) {
-				$this->compileStyles( $context );
+			if ($this->styleText === null) {
+				$this->compileStyles($context);
 			}
 		}
 
-		return [ 'all' => $this->styleText ];
+		return ['all' => $this->styleText];
 	}
 
 	/**
 	 * @param ResourceLoaderContext $context
 	 */
-	protected function retrieveStylesFromCache( ResourceLoaderContext $context ) {
+	protected function retrieveStylesFromCache(ResourceLoaderContext $context) {
 
 		// Try for cache hit
-		$cacheKey = $this->getCacheKey( $context );
-		$cacheResult = $this->getCache()->get( $cacheKey );
+		$cacheKey = $this->getCacheKey($context);
+		$cacheResult = $this->getCache()->get($cacheKey);
 
-		if ( is_array( $cacheResult ) ) {
+		if (is_array($cacheResult)) {
 
-			if ( $this->isCacheOutdated( $cacheResult[ 'storetime' ] ) ) {
-				wfDebug( "SCSS: Cache miss for {$this->getName()}: Cache outdated.\n", 'private' );
+			if ($this->isCacheOutdated($cacheResult['storetime'])) {
+				wfDebug("SCSS: Cache miss for {$this->getName()}: Cache outdated.\n", 'private');
 			} else {
-				$this->styleText = $cacheResult[ 'styles' ];
-				wfDebug( "SCSS: Cache hit for {$this->getName()}: Got styles from cache.\n", 'private' );
+				$this->styleText = $cacheResult['styles'];
+				wfDebug("SCSS: Cache hit for {$this->getName()}: Got styles from cache.\n", 'private');
 			}
 
 		} else {
-			wfDebug( "SCSS: Cache miss for {$this->getName()}: Styles not found in cache.\n", 'private' );
+			wfDebug("SCSS: Cache miss for {$this->getName()}: Styles not found in cache.\n", 'private');
 		}
 	}
 
@@ -147,15 +147,15 @@ 
 	 */
 	protected function getCache() {
 
-		if ( $this->cache === null ) {
-			$this->cache = ObjectCache::getInstance( $this->getCacheType() );
+		if ($this->cache === null) {
+			$this->cache = ObjectCache::getInstance($this->getCacheType());
 		}
 
 		return $this->cache;
 	}
 
 	private function getCacheType() {
-		return array_key_exists( 'egScssCacheType', $GLOBALS ) ? $GLOBALS[ 'egScssCacheType' ] : -1;
+		return array_key_exists('egScssCacheType', $GLOBALS) ? $GLOBALS['egScssCacheType'] : -1;
 	}
 
 	/**
@@ -163,7 +163,7 @@ 
 	 *
 	 * @param BagOStuff $cache
 	 */
-	public function setCache( BagOStuff $cache ) {
+	public function setCache(BagOStuff $cache) {
 		$this->cache = $cache;
 	}
 
@@ -172,18 +172,18 @@ 
 	 *
 	 * @return string
 	 */
-	protected function getCacheKey( ResourceLoaderContext $context ) {
+	protected function getCacheKey(ResourceLoaderContext $context) {
 
-		if ( $this->cacheKey === null ) {
+		if ($this->cacheKey === null) {
 
-			$styles = serialize( $this->styles );
+			$styles = serialize($this->styles);
 
 			$vars = $this->variables;
-			ksort( $vars );
-			$vars = serialize( $vars );
+			ksort($vars);
+			$vars = serialize($vars);
 
 			// have to hash the module config, else it may become too long
-			$configHash = md5( $styles . $vars );
+			$configHash = md5($styles . $vars);
 
 			$this->cacheKey = wfMemcKey(
 				'ext',
@@ -201,11 +201,11 @@ 
 	 *
 	 * @return bool
 	 */
-	protected function isCacheOutdated( $cacheStoreTime ) {
+	protected function isCacheOutdated($cacheStoreTime) {
 
-		foreach ( $this->cacheTriggers as $triggerFile ) {
+		foreach ($this->cacheTriggers as $triggerFile) {
 
-			if ( $triggerFile !== null && $cacheStoreTime < filemtime( $triggerFile ) ) {
+			if ($triggerFile !== null && $cacheStoreTime < filemtime($triggerFile)) {
 				return true;
 			}
 
@@ -217,18 +217,18 @@ 
 	/**
 	 * @param ResourceLoaderContext $context
 	 */
-	protected function compileStyles( ResourceLoaderContext $context ) {
+	protected function compileStyles(ResourceLoaderContext $context) {
 
 		$scss = new Compiler();
-		$scss->setImportPaths( $this->getLocalPath( '' ) );
+		$scss->setImportPaths($this->getLocalPath(''));
 
 		// Allows inlining of arbitrary files regardless of extension, .css in particular
 		$scss->addImportPath(
 
 			// addImportPath is declared as requiring a string param, but actually also understand callables
 			/** @scrutinizer ignore-type */
-			function ( $path ) {
-				if ( file_exists( $path ) ) {
+			function($path) {
+				if (file_exists($path)) {
 					return $path;
 				}
 				return null;
@@ -240,27 +240,27 @@ 
 
 			$imports = $this->getStyleFilesList();
 
-			foreach ( $imports as $key => $import ) {
-				$path = str_replace( [ '\\', '"' ], [ '\\\\', '\\"' ], $import );
-				$imports[ $key ] = '@import "' . $path . '";';
+			foreach ($imports as $key => $import) {
+				$path = str_replace(['\\', '"'], ['\\\\', '\\"'], $import);
+				$imports[$key] = '@import "' . $path . '";';
 			}
 
-			$scss->setVariables( $this->variables );
+			$scss->setVariables($this->variables);
 
-			$style = $scss->compile( implode( $imports ) );
+			$style = $scss->compile(implode($imports));
 
-			if ( $this->getFlip( $context ) ) {
-				$style = CSSJanus::transform( $style, true, false );
+			if ($this->getFlip($context)) {
+				$style = CSSJanus::transform($style, true, false);
 			}
 
 			$this->styleText = $style;
 
-			$this->updateCache( $context );
+			$this->updateCache($context);
 
-		} catch ( Exception $e ) {
+		} catch (Exception $e) {
 
-			$this->purgeCache( $context );
-			wfDebug( $e->getMessage() );
+			$this->purgeCache($context);
+			wfDebug($e->getMessage());
 			$this->styleText = '/* SCSS compile error: ' . $e->getMessage() . '*/';
 		}
 
@@ -269,19 +269,19 @@ 
 	/**
 	 * @param ResourceLoaderContext $context
 	 */
-	protected function updateCache( ResourceLoaderContext $context ) {
+	protected function updateCache(ResourceLoaderContext $context) {
 
 		$this->getCache()->set(
-			$this->getCacheKey( $context ),
-			[ 'styles' => $this->styleText, 'storetime' => time() ]
+			$this->getCacheKey($context),
+			['styles' => $this->styleText, 'storetime' => time()]
 		);
 	}
 
 	/**
 	 * @param ResourceLoaderContext $context
 	 */
-	protected function purgeCache( ResourceLoaderContext $context ) {
-		$this->getCache()->delete( $this->getCacheKey( $context ) );
+	protected function purgeCache(ResourceLoaderContext $context) {
+		$this->getCache()->delete($this->getCacheKey($context));
 	}
 
 	/**
@@ -295,12 +295,12 @@ 
 	 * @return array
 	 */
 	protected function getStyleFilesList() {
-		$styles = self::collateFilePathListByOption( $this->styles, 'position', 'main' );
+		$styles = self::collateFilePathListByOption($this->styles, 'position', 'main');
 		$imports = [];
 
-		foreach ( $this->styleModulePositions as $position ) {
-			if ( isset( $styles[ $position ] ) ) {
-				$imports = array_merge( $imports, $styles[ $position ] );
+		foreach ($this->styleModulePositions as $position) {
+			if (isset($styles[$position])) {
+				$imports = array_merge($imports, $styles[$position]);
 			}
 		}