MovieController::indexAction()

Complexity

Conditions	14
Paths	145

Size

Total Lines	68
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	26
CRAP Score	20.1728

Importance

Changes	7
Bugs	0	Features	1

<?php
    public function indexAction(): void
    {
        // Check there is at least one user, otherwise the whole page will crash
        if (!User::getCurrent() && !UserMapper::getDbTable()->fetchRow()) {
            throw new Exception('At least one user must exist to access this page');
        }

        $form = new Filters();
        $this->view->formFilter = $form;

        // Detect if at least one filter was submitted
        $submitted = false;
        foreach ($this->getRequest()->getParams() as $key => $filter) {
            if (preg_match('/^filter\d+$/', $key)) {
                $submitted = true;
            }
        }

        // If was submitted, try to validate values
        if ($submitted) {
            if (!$form->isValid($this->getRequest()->getParams())) {
                $this->_helper->FlashMessenger(['warning' => _tr('Filter is invalid.')]);
                $form->setDefaults([]);
            }
        } // If we submitted a quicksearch, set default values to search with any status
        elseif ($this->_getParam('search')) {
            $form->setDefaults([
                'filter1' => [
                    'user' => User::getCurrent() ? 0 : UserMapper::fetchAll()->current()->id,
                    'condition' => 'is',
                    'status' => array_merge([0], array_keys(mQueue\Model\Status::$ratings)),
                    'title' => $this->_getParam('search'),
                ],
            ]);
        } // Otherwise clear the filter
        else {
            $form->setDefaults([]);
        }

        // Gather users selected in filters
        $this->view->users = [];
        $filters = $form->getValues();
        foreach ($filters as $key => $filter) {
            if (!preg_match('/^filter\d+$/', $key)) {
                continue;
            }

            $this->view->users[$filter['user']] = UserMapper::find($filter['user']);

Accessing users on the interface Zend_View_Interface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        // If we ouput rss, we force sorting by date
        if ($this->_helper->contextSwitch()->getCurrentContext() == 'rss') {
            $this->getRequest()->setParam('sort', $filters['filter1']['withSource'] ? 'dateSearch' : 'date');
            $this->getRequest()->setParam('sortOrder', 'desc');
        }
        $this->view->permanentParams = $form->getValues();
        $this->view->filterName = $form->getValuesText();
        unset($this->view->permanentParams['addFilter']);

Accessing permanentParams on the interface Zend_View_Interface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $allowedSortingKey = ['title', 'date', 'dateSearch'];
        $usersCount = count($this->view->users);
        for ($i = 0; $i < $usersCount; ++$i) {
            $allowedSortingKey[] = 'status' . $i;
        }
        $sort = $this->_helper->createSorting('sort', $allowedSortingKey);

        // Set up the paginator: Apply pagination only if there is no special context (so it is normal html rendering)
        $this->view->paginator = $this->_helper->createPaginator(MovieMapper::getFilteredQuery($filters, $sort));
    }