MovieController

Complexity

Total Complexity

32

Size/Duplication

Total Lines	176
Duplicated Lines	0 %

Test Coverage

Coverage

42.86%

Importance

Changes	9
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
B	importAction()	0	53	10
A	init()	0	12	1
A	addAction()	0	21	4
A	viewAction()	0	12	3
C	indexAction()	0	68	14

<?php

use mQueue\Form\Filters;
use mQueue\Form\Import;
use mQueue\Model\Movie;
use mQueue\Model\MovieMapper;
use mQueue\Model\Status;
use mQueue\Model\StatusMapper;
use mQueue\Model\User;
use mQueue\Model\UserMapper;

class MovieController extends Zend_Controller_Action
{
    public function init(): void
    {
        // Init the Context Switch Action helper
        $contextSwitch = $this->_helper->contextSwitch();

        // Add the new context
        $contextSwitch->setContexts([
            'csv' => ['suffix' => 'csv'],
            'rss' => ['suffix' => 'rss'],
        ]);

        $contextSwitch->addActionContext('index', 'csv')->addActionContext('index', 'rss')->initContext();
    }

    public function indexAction(): void
    {
        // Check there is at least one user, otherwise the whole page will crash
        if (!User::getCurrent() && !UserMapper::getDbTable()->fetchRow()) {
            throw new Exception('At least one user must exist to access this page');
        }

        $form = new Filters();
        $this->view->formFilter = $form;

        // Detect if at least one filter was submitted
        $submitted = false;
        foreach ($this->getRequest()->getParams() as $key => $filter) {
            if (preg_match('/^filter\d+$/', $key)) {
                $submitted = true;
            }
        }

        // If was submitted, try to validate values
        if ($submitted) {
            if (!$form->isValid($this->getRequest()->getParams())) {
                $this->_helper->FlashMessenger(['warning' => _tr('Filter is invalid.')]);
                $form->setDefaults([]);
            }
        } // If we submitted a quicksearch, set default values to search with any status
        elseif ($this->_getParam('search')) {
            $form->setDefaults([
                'filter1' => [
                    'user' => User::getCurrent() ? 0 : UserMapper::fetchAll()->current()->id,
                    'condition' => 'is',
                    'status' => array_merge([0], array_keys(mQueue\Model\Status::$ratings)),
                    'title' => $this->_getParam('search'),
                ],
            ]);
        } // Otherwise clear the filter
        else {
            $form->setDefaults([]);
        }

        // Gather users selected in filters
        $this->view->users = [];
        $filters = $form->getValues();
        foreach ($filters as $key => $filter) {
            if (!preg_match('/^filter\d+$/', $key)) {
                continue;
            }

            $this->view->users[$filter['user']] = UserMapper::find($filter['user']);

Accessing users on the interface Zend_View_Interface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        // If we ouput rss, we force sorting by date
        if ($this->_helper->contextSwitch()->getCurrentContext() == 'rss') {
            $this->getRequest()->setParam('sort', $filters['filter1']['withSource'] ? 'dateSearch' : 'date');
            $this->getRequest()->setParam('sortOrder', 'desc');
        }
        $this->view->permanentParams = $form->getValues();
        $this->view->filterName = $form->getValuesText();
        unset($this->view->permanentParams['addFilter']);

Accessing permanentParams on the interface Zend_View_Interface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $allowedSortingKey = ['title', 'date', 'dateSearch'];
        $usersCount = count($this->view->users);
        for ($i = 0; $i < $usersCount; ++$i) {
            $allowedSortingKey[] = 'status' . $i;
        }
        $sort = $this->_helper->createSorting('sort', $allowedSortingKey);

        // Set up the paginator: Apply pagination only if there is no special context (so it is normal html rendering)
        $this->view->paginator = $this->_helper->createPaginator(MovieMapper::getFilteredQuery($filters, $sort));
    }

    public function viewAction(): void
    {
        if ($this->getRequest()->getParam('id')) {
            $this->view->movie = MovieMapper::find($this->getRequest()->getParam('id'));
        }

        if (!$this->view->movie) {

Accessing movie on the interface Zend_View_Interface suggest that you code against a concrete implementation. How about adding an instanceof check?

            throw new Exception($this->view->translate('Movie not found'));
        }

        $this->view->users = UserMapper::fetchAll();
        $this->view->movieActivity = $this->_helper->createPaginator(StatusMapper::getActivityQuery($this->view->movie));
    }

    public function addAction(): void
    {
        $request = $this->getRequest();
        $form = new \mQueue\Form\Movie();

        if ($this->_getParam('id')) {
            if ($form->isValid($request->getParams())) {
                $values = $form->getValues();
                $movie = MovieMapper::find(Movie::extractId($values['id']));

It seems like mQueue\Model\Movie::extractId($values['id']) can also be of type string; however, parameter $id of mQueue\Model\MovieMapper::find() does only seem to accept integer, maybe add an additional type check?

                if (!$movie) {

$movie is of type mQueue\Model\Movie, thus it always evaluated to true.

                    $movie = MovieMapper::getDbTable()->createRow();
                    $movie->setId($values['id']);
                    $movie->save();
                    $this->_helper->FlashMessenger(_tr('A movie was added.'));
                }

                $this->view->movies = [$movie];
            }
        }

        $this->view->form = $form;
    }

    public function importAction(): void
    {
        $request = $this->getRequest();
        $form = new Import();
        $form->setDefaults(['favoriteMinimum' => 9, 'excellentMinimum' => 7, 'okMinimum' => 5]);
        $this->view->form = $form;

        if ($this->getRequest()->isPost() && $form->isValid($request->getPost())) {

The method isPost() does not exist on Zend_Controller_Request_Abstract. It seems like you code against a sub-type of Zend_Controller_Request_Abstract such as Zend_Controller_Request_Http.

The method getPost() does not exist on Zend_Controller_Request_Abstract. It seems like you code against a sub-type of Zend_Controller_Request_Abstract such as Zend_Controller_Request_Http.

            if (User::getCurrent() == null) {
                $this->_helper->FlashMessenger(['error' => _tr('You must be logged in.')]);

                return;
            }

            $values = $form->getValues();
            $page = file_get_contents($values['url']);

            $pattern = '|<a href="/title/tt(\d{7,})/">.*</td>\s*<td.*>(\d+(\.\d)*)</td>|U';
            preg_match_all($pattern, $page, $matches);

            $movies = [];
            $matchesCount = count($matches[1]);
            for ($i = 0; $i < $matchesCount; ++$i) {
                $id = $matches[1][$i];
                $imdbRating = $matches[2][$i];

                $movie = MovieMapper::find($id);
                if (!$movie) {
                    $movie = MovieMapper::getDbTable()->createRow();
                    $movie->setId($id);
                    $movie->save();
                }

                if ($imdbRating >= $values['favoriteMinimum']) {
                    $rating = Status::Favorite;
                } elseif ($imdbRating >= $values['excellentMinimum']) {
                    $rating = Status::Excellent;
                } elseif ($imdbRating >= $values['okMinimum']) {
                    $rating = Status::Ok;
                } else {
                    $rating = Status::Bad;
                }

                $movie->setStatus(User::getCurrent(), $rating);
                $movies[] = $movie;
            }

            $count = count($movies);
            if ($count) {
                $this->_helper->FlashMessenger(_tr('Movies imported.'));
                $this->view->movies = $movies;
            } else {
                $this->_helper->FlashMessenger(['warning' => _tr('No movies found for import.')]);
            }
        }
    }
}