Completed
Push — master ( 6c1318...fd4dfb )
by Mahmoud
03:00
created
app/Containers/Authorization/Actions/AssignRoleAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
     /**
22 22
      * GetAdminRoleAction constructor.
23 23
      *
24
-     * @param \App\Containers\Authorization\Data\Repositories\AssignRoleTask $assignRoleTask
24
+     * @param AssignRoleTask $assignRoleTask
25 25
      */
26 26
     public function __construct(AssignRoleTask $assignRoleTask)
27 27
     {
Please login to merge, or discard this patch.
Containers/Authorization/UI/API/Tests/Functional/AssignUserToRoleTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use App\Containers\User\Models\User;
6 6
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
7
-use Vinkla\Hashids\Facades\Hashids;
8 7
 
9 8
 /**
10 9
  * Class AssignUserToRoleTest.
Please login to merge, or discard this patch.
Authorization/UI/API/Tests/Functional/AttachPermissionsToRoleTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use App\Containers\Authorization\Models\Permission;
6 6
 use App\Containers\Authorization\Models\Role;
7
-use App\Containers\User\Models\User;
8 7
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
9 8
 
10 9
 /**
Please login to merge, or discard this patch.
app/Containers/Authorization/Tasks/AssignRoleTask.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      */
46 46
     public function run($user, $roles)
47 47
     {
48
-        if(!$user instanceof User){
48
+        if (!$user instanceof User) {
49 49
             $user = $this->findUserByIdTask->run($user);
50 50
         }
51 51
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
                 $this->assignRole($user, $role);
55 55
             }
56 56
 
57
-        }else{
57
+        } else {
58 58
             $this->assignRole($user, $roles);
59 59
         }
60 60
 
Please login to merge, or discard this patch.
app/Containers/Authorization/Tasks/AttachPermissionsToRoleTask.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -42,13 +42,13 @@
 block discarded – undo
42 42
     {
43 43
         $role = $this->getRoleAction->run($roleName);
44 44
 
45
-        if(is_array($permissionNames)){
45
+        if (is_array($permissionNames)) {
46 46
 
47
-            foreach ($permissionNames as $permissionName){
47
+            foreach ($permissionNames as $permissionName) {
48 48
                 $role->givePermissionTo($permissionName);
49 49
             }
50 50
 
51
-        }else{
51
+        } else {
52 52
             $role->givePermissionTo($permissionNames);
53 53
         }
54 54
 
Please login to merge, or discard this patch.