Pleets / dronephp

src/Mvc/ModuleFactory.php

Braces +12 added lines, -8 removed lines

@@ -29,11 +29,13 @@ 
      */
     public static function create($module, Array $module_settings = [])
     {
-        if (empty($module))
-            throw new \RuntimeException("The module name must be specified");
+        if (empty($module)) {
+                    throw new \RuntimeException("The module name must be specified");
+        }
 
-        if (!is_string($module))
-            throw new \InvalidArgumentException("Invalid type given. string expected");
+        if (!is_string($module)) {
+                    throw new \InvalidArgumentException("Invalid type given. string expected");
+        }
 
         /*
          * Module class instantiation
@@ -44,13 +46,15 @@ 
          */
         $fqn_module = "\\" . $module . "\\Module";
 
-        if (!class_exists($fqn_module))
-            throw new Exception\ModuleNotFoundException("The module class '$fqn_module' does not exists!");
+        if (!class_exists($fqn_module)) {
+                    throw new Exception\ModuleNotFoundException("The module class '$fqn_module' does not exists!");
+        }
 
         $module = new $fqn_module($module);
 
-        if (array_key_exists('config', $module_settings) && !is_null($module_settings["config"]))
-            $module->setConfigFile($module_settings["config"]);
+        if (array_key_exists('config', $module_settings) && !is_null($module_settings["config"])) {
+                    $module->setConfigFile($module_settings["config"]);
+        }
 
         return $module;
     }

src/Mvc/View.php

Spacing +3 added lines, -3 removed lines

@@ -85,7 +85,7 @@ 
      */
     public function __construct($name, Array $parameters = [])
     {
-        $this->name  = $name;
+        $this->name = $name;
         $this->setParams($parameters);
     }
 
@@ -101,12 +101,12 @@ 
         $_view = $this->path . DIRECTORY_SEPARATOR . $this->name . '.phtml';
 
         if (!file_exists($_view))
-            throw new Exception\ViewNotFoundException("The view '" .$this->name. "' does not exists");
+            throw new Exception\ViewNotFoundException("The view '" . $this->name . "' does not exists");
 
         $contents = file_get_contents($_view);
 
         if ($contents === false)
-            throw new Exception\ViewGetContentsErrorException("The view '" .$this->name. "' does not exists");
+            throw new Exception\ViewGetContentsErrorException("The view '" . $this->name . "' does not exists");
 
         return $contents;
     }

Braces +9 added lines, -6 removed lines

@@ -100,13 +100,15 @@ 
     {
         $_view = $this->path . DIRECTORY_SEPARATOR . $this->name . '.phtml';
 
-        if (!file_exists($_view))
-            throw new Exception\ViewNotFoundException("The view '" .$this->name. "' does not exists");
+        if (!file_exists($_view)) {
+                    throw new Exception\ViewNotFoundException("The view '" .$this->name. "' does not exists");
+        }
 
         $contents = file_get_contents($_view);
 
-        if ($contents === false)
-            throw new Exception\ViewGetContentsErrorException("The view '" .$this->name. "' does not exists");
+        if ($contents === false) {
+                    throw new Exception\ViewGetContentsErrorException("The view '" .$this->name. "' does not exists");
+        }
 
         return $contents;
     }
@@ -118,8 +120,9 @@ 
      */
     public function render()
     {
-        if (count($this->getParams()))
-            extract($this->getParams(), EXTR_SKIP);
+        if (count($this->getParams())) {
+                    extract($this->getParams(), EXTR_SKIP);
+        }
 
         include $this->getContents();
     }

src/Mvc/Router.php

Spacing +5 added lines, -7 removed lines

@@ -263,11 +263,10 @@ 
         {
             foreach ($this->routes as $key => $route)
             {
-                if
-                (
-                    $route["module"]     == $this->identifiers["module"]     &&
+                if (
+                    $route["module"] == $this->identifiers["module"] &&
                     $route["controller"] == $this->identifiers["controller"] &&
-                    $route["view"]       == $this->identifiers["view"]
+                    $route["view"] == $this->identifiers["view"]
                 )
                 {
                     $module     = $route["module"];
@@ -282,9 +281,8 @@ 
 
         if (count($this->defaults) && !$match)
         {
-            if
-            (
-                !empty($this->defaults["module"])     &&
+            if (
+                !empty($this->defaults["module"]) &&
                 !empty($this->defaults["controller"]) &&
                 !empty($this->defaults["view"])
             )

Braces +40 added lines, -30 removed lines

@@ -100,8 +100,9 @@ 
      */
     public function getController()
     {
-        if (is_null($this->controller))
-            throw new \RuntimeException("No controller matched, try to match first.");
+        if (is_null($this->controller)) {
+                    throw new \RuntimeException("No controller matched, try to match first.");
+        }
 
         return $this->controller;
     }
@@ -141,8 +142,9 @@ 
 
         foreach ($identifiers as $key => $identifier)
         {
-            if (!is_string($identifier))
-                throw new \InvalidArgumentException("Invalid type given for '$key'. String expected.");
+            if (!is_string($identifier)) {
+                            throw new \InvalidArgumentException("Invalid type given for '$key'. String expected.");
+            }
         }
 
         $this->identifiers = [
@@ -167,8 +169,9 @@ 
 
         foreach ($identifiers as $key => $identifier)
         {
-            if (!is_string($identifier))
-                throw new \InvalidArgumentException("Invalid type given for '$key'. String expected.");
+            if (!is_string($identifier)) {
+                            throw new \InvalidArgumentException("Invalid type given for '$key'. String expected.");
+            }
         }
 
         $this->defaults = [
@@ -237,8 +240,9 @@ 
      */
     public function match()
     {
-        if (!is_callable($this->classNameBuilder))
-            throw \LogicException("No class name builder found");
+        if (!is_callable($this->classNameBuilder)) {
+                    throw \LogicException("No class name builder found");
+        }
 
         /*
          *  Key value pairs builder:
@@ -297,8 +301,9 @@ 
             }
         }
 
-        if (!$match)
-            throw new Exception\RouteNotFoundException("The route has not been matched");
+        if (!$match) {
+                    throw new Exception\RouteNotFoundException("The route has not been matched");
+        }
 
         $fqn_controller = call_user_func($this->classNameBuilder, $module, $controller);
 
@@ -312,17 +317,16 @@ 
             catch (Exception\MethodNotFoundException $e)
             {
                 throw new Exception\PageNotFoundException($e->getMessage(), $e->getCode(), $e);
-            }
-            catch (Exception\PrivateMethodExecutionException $e)
+            } catch (Exception\PrivateMethodExecutionException $e)
             {
                 throw new Exception\PageNotFoundException($e->getMessage(), $e->getCode(), $e);
             }
 
             # in controller terms, a view is a method
             $this->controller->setMethod($view);
+        } else {
+                    throw new Exception\ControllerNotFoundException("The control class '$fqn_controller' does not exists!");
         }
-        else
-            throw new Exception\ControllerNotFoundException("The control class '$fqn_controller' does not exists!");
     }
 
     /**
@@ -348,8 +352,9 @@ 
     {
         $key = array_keys($route);
 
-        if (count($key) > 1)
-            throw new \InvalidArgumentException("So many keys in a simple route");
+        if (count($key) > 1) {
+                    throw new \InvalidArgumentException("So many keys in a simple route");
+        }
 
         $key = array_shift($key);
 
@@ -357,15 +362,18 @@ 
 
         foreach ($identifiers as $identifier)
         {
-            if (!array_key_exists($identifier, $route[$key]))
-                throw new \InvalidArgumentException("The identifier '$identifier' does not exists in the route");
+            if (!array_key_exists($identifier, $route[$key])) {
+                            throw new \InvalidArgumentException("The identifier '$identifier' does not exists in the route");
+            }
 
-            if (!is_string($route[$key][$identifier]))
-                throw new \InvalidArgumentException("Invalid type given for '$identifier'. String expected.");
+            if (!is_string($route[$key][$identifier])) {
+                            throw new \InvalidArgumentException("Invalid type given for '$identifier'. String expected.");
+            }
         }
 
-        if (array_key_exists($key, $this->routes))
-            throw new \LogicException("The key '$key' was already defined as a route");
+        if (array_key_exists($key, $this->routes)) {
+                    throw new \LogicException("The key '$key' was already defined as a route");
+        }
 
         $this->routes = array_merge($this->routes, $route);
     }
@@ -406,10 +414,11 @@ 
         $i = 1;
         foreach ($params as $item)
         {
-            if ($i % 2 != 0)
-                $vars[] = $item;
-            else
-                $values[] = $item;
+            if ($i % 2 != 0) {
+                            $vars[] = $item;
+            } else {
+                            $values[] = $item;
+            }
             $i++;
         }
 
@@ -419,10 +428,11 @@ 
 
         for ($i = 0; $i < $vars_count; $i++)
         {
-            if (array_key_exists($i, $values))
-                $result[$vars[$i]] = $values[$i];
-            else
-                $result[$vars[$i]] = '';
+            if (array_key_exists($i, $values)) {
+                            $result[$vars[$i]] = $values[$i];
+            } else {
+                            $result[$vars[$i]] = '';
+            }
         }
 
         return $result;

src/Mvc/AbstractController.php

Braces +25 added lines, -19 removed lines

@@ -86,13 +86,14 @@ 
     {
         $method = $this->method;
 
-        if (is_null($method))
-            # This error is thrown because of 'setMethod' method has not been executed
+        if (is_null($method)) {
+                    # This error is thrown because of 'setMethod' method has not been executed
             throw new \LogicException("No method has been setted to execute!");
+        }
 
-        if (!is_null($this->module) && !$this->module->executionIsAllowed())
-            throw new Exception\MethodExecutionNotAllowedException("Method execution is not allowed");
-        else
+        if (!is_null($this->module) && !$this->module->executionIsAllowed()) {
+                    throw new Exception\MethodExecutionNotAllowedException("Method execution is not allowed");
+        } else
         {
             if (method_exists($this, $method))
             {
@@ -100,12 +101,12 @@ 
 
                 $reflection = new \ReflectionMethod($this, $method);
 
-                if (!$reflection->isPublic())
-                    throw new Exception\PrivateMethodExecutionException("The method '$method' is not public in the control class '$class'");
+                if (!$reflection->isPublic()) {
+                                    throw new Exception\PrivateMethodExecutionException("The method '$method' is not public in the control class '$class'");
+                }
 
                 return $this->$method();
-            }
-            else
+            } else
             {
                 $class = __CLASS__;
                 throw new Exception\MethodNotFoundException("The method '$method' doesn't exists in the control class '$class'");
@@ -130,8 +131,9 @@ 
      */
     public function getPost()
     {
-        if ($_SERVER['REQUEST_METHOD'] == 'POST' && empty($_POST))
-            $_POST = json_decode(file_get_contents('php://input'), true);
+        if ($_SERVER['REQUEST_METHOD'] == 'POST' && empty($_POST)) {
+                    $_POST = json_decode(file_get_contents('php://input'), true);
+        }
 
         return (array) $_POST;
     }
@@ -145,8 +147,9 @@ 
      */
     public function getJson()
     {
-        if ($_SERVER['REQUEST_METHOD'] != 'JSON')
-            throw new \LogicException("Request method is not JSON");
+        if ($_SERVER['REQUEST_METHOD'] != 'JSON') {
+                    throw new \LogicException("Request method is not JSON");
+        }
 
         $input =  file_get_contents('php://input');
         $array = explode("&", $input);
@@ -170,8 +173,9 @@ 
     public function isXmlHttpRequest()
     {
         # non standard (HTTP_X_REQUESTED_WITH is not a part of PHP)
-        if (isset($_SERVER['HTTP_X_REQUESTED_WITH']))
-            return true;
+        if (isset($_SERVER['HTTP_X_REQUESTED_WITH'])) {
+                    return true;
+        }
         return false;
     }
 
@@ -182,8 +186,9 @@ 
      */
     public function isPost()
     {
-        if ($_SERVER["REQUEST_METHOD"] == "POST")
-            return true;
+        if ($_SERVER["REQUEST_METHOD"] == "POST") {
+                    return true;
+        }
         return false;
     }
 
@@ -194,8 +199,9 @@ 
      */
     public function isGet()
     {
-        if ($_SERVER["REQUEST_METHOD"] == "GET")
-            return true;
+        if ($_SERVER["REQUEST_METHOD"] == "GET") {
+                    return true;
+        }
         return false;
     }
 }
\ No newline at end of file

src/Mvc/Application.php

Spacing +4 added lines, -4 removed lines

@@ -190,17 +190,17 @@
      */
     public function run()
     {
-        $module     = isset($_GET["module"])     ? $_GET["module"]     : null;
+        $module     = isset($_GET["module"]) ? $_GET["module"] : null;
         $controller = isset($_GET["controller"]) ? $_GET["controller"] : null;
-        $view       = isset($_GET["view"])       ? $_GET["view"]       : null;
+        $view       = isset($_GET["view"]) ? $_GET["view"] : null;
 
         $request = new  \Zend\Http\Request();
 
         # build URI
         $uri = '';
-        $uri .= !empty($module)     ? '/' . $module : "";
+        $uri .= !empty($module) ? '/' . $module : "";
         $uri .= !empty($controller) ? '/' . $controller : "";
-        $uri .= !empty($view)       ? '/' . $view : "";
+        $uri .= !empty($view) ? '/' . $view : "";
 
         if (empty($uri))
             $uri = "/";

Braces +41 added lines, -30 removed lines

@@ -99,19 +99,23 @@ 
     public function __construct(Array $config)
     {
         # start sessions
-        if (!isset($_SESSION))
-            session_start();
+        if (!isset($_SESSION)) {
+                    session_start();
+        }
 
-        if (!array_key_exists('environment', $config))
-            throw new \InvalidArgumentException("The 'environment' key was not defined");
+        if (!array_key_exists('environment', $config)) {
+                    throw new \InvalidArgumentException("The 'environment' key was not defined");
+        }
 
-        if (!array_key_exists('dev_mode', $config['environment']))
-            throw new \InvalidArgumentException("The 'dev_mode' key was not defined");
+        if (!array_key_exists('dev_mode', $config['environment'])) {
+                    throw new \InvalidArgumentException("The 'dev_mode' key was not defined");
+        }
 
         $this->devMode = $config["environment"]["dev_mode"];
 
-        if (!array_key_exists('modules', $config))
-            throw new \InvalidArgumentException("The 'modules' key was not defined");
+        if (!array_key_exists('modules', $config)) {
+                    throw new \InvalidArgumentException("The 'modules' key was not defined");
+        }
 
         $this->modules = $config["modules"];
 
@@ -125,33 +129,36 @@ 
         {
             ini_set('display_errors', 1);
             error_reporting(-1);
-        }
-        else
+        } else
         {
             ini_set('display_errors', 0);
             error_reporting(0);
         }
 
-        if (!array_key_exists('router', $config))
-            throw new \InvalidArgumentException("The 'router' key was not defined");
+        if (!array_key_exists('router', $config)) {
+                    throw new \InvalidArgumentException("The 'router' key was not defined");
+        }
 
-        if (!array_key_exists('routes', $config["router"]))
-            throw new \InvalidArgumentException("The 'routes' key was not defined");
+        if (!array_key_exists('routes', $config["router"])) {
+                    throw new \InvalidArgumentException("The 'routes' key was not defined");
+        }
 
         $this->router = new Router($config["router"]["routes"]);
 
-        if (!array_key_exists('base_path', $config['environment']))
-            throw new \InvalidArgumentException("The 'base_path' key was not defined");
+        if (!array_key_exists('base_path', $config['environment'])) {
+                    throw new \InvalidArgumentException("The 'base_path' key was not defined");
+        }
 
         $this->basePath = $config["environment"]["base_path"];
 
         # load routes from config
         foreach ($config["router"]["routes"] as $name => $route)
         {
-            if ($route instanceof \Zend\Router\Http\RouteInterface)
-                $this->router->addZendRoute($name, $route);
-            else
-                $this->router->addRoute($route);
+            if ($route instanceof \Zend\Router\Http\RouteInterface) {
+                            $this->router->addZendRoute($name, $route);
+            } else {
+                            $this->router->addRoute($route);
+            }
         }
 
         # register autoloading functions for each module
@@ -172,11 +179,13 @@ 
             {
                 $module_config_file = require($this->modulePath . "/$module/config/module.config.php");
 
-                if (!array_key_exists('router', $module_config_file))
-                    throw new \RuntimeException("The 'router' key was not defined in the config file for module '$module'");
+                if (!array_key_exists('router', $module_config_file)) {
+                                    throw new \RuntimeException("The 'router' key was not defined in the config file for module '$module'");
+                }
 
-                if (!array_key_exists('routes', $module_config_file["router"]))
-                    throw new \RuntimeException("The 'routes' key was not defined in the config file for module '$module'");
+                if (!array_key_exists('routes', $module_config_file["router"])) {
+                                    throw new \RuntimeException("The 'routes' key was not defined in the config file for module '$module'");
+                }
 
                 $this->getRouter()->addRoute($module_config_file["router"]["routes"]);
             }
@@ -202,8 +211,9 @@ 
         $uri .= !empty($controller) ? '/' . $controller : "";
         $uri .= !empty($view)       ? '/' . $view : "";
 
-        if (empty($uri))
-            $uri = "/";
+        if (empty($uri)) {
+                    $uri = "/";
+        }
 
         $request->setUri($uri);
 
@@ -219,9 +229,9 @@ 
             $view       = $params["action"];
 
             $this->router->setIdentifiers($module, $controller, $view);
+        } else {
+                    $this->router->setIdentifiers($module, $controller, $view);
         }
-        else
-            $this->router->setIdentifiers($module, $controller, $view);
 
         $this->router->match();
 
@@ -240,8 +250,9 @@ 
             {
                 $result->setPath($this->basePath . DIRECTORY_SEPARATOR . $this->modulePath . DIRECTORY_SEPARATOR . 'source/view');
 
-                if (is_null($result->getName()))
-                    $result->setView($router->getController()->getMethod());
+                if (is_null($result->getName())) {
+                                    $result->setView($router->getController()->getMethod());
+                }
 
                 $result->render();
             }

src/Mvc/AbstractModule.php

Braces +3 added lines, -2 removed lines

@@ -141,8 +141,9 @@
     {
         $_file = $this->configFile;
 
-        if (!file_exists($_file))
-            throw new \RuntimeException("The config file '$_file' does not exists");
+        if (!file_exists($_file)) {
+                    throw new \RuntimeException("The config file '$_file' does not exists");
+        }
 
         return (array) include $this->configFile;
     }

src/Loader/ClassMap.php

Braces +3 added lines, -2 removed lines

@@ -41,7 +41,8 @@
 
         $class = $path . implode(DIRECTORY_SEPARATOR, $nm) . ".php";
 
-        if (file_exists($class))
-            include $class;
+        if (file_exists($class)) {
+                    include $class;
+        }
     }
 }
\ No newline at end of file

test/Mvc/RouterTest.php

Braces +4 added lines, -8 removed lines

@@ -68,12 +68,10 @@ 
 
         try {
             $router->match();
-        }
-        catch (\Exception $e)
+        } catch (\Exception $e)
         {
             $errorObject = ($e instanceof RouteNotFoundException);
-        }
-        finally
+        } finally
         {
             $this->assertTrue($errorObject, $e->getMessage());
         }
@@ -181,12 +179,10 @@ 
 
         try {
             $router->run();
-        }
-        catch (\Exception $e)
+        } catch (\Exception $e)
         {
             $errorObject = ($e instanceof MethodExecutionNotAllowedException);
-        }
-        finally
+        } finally
         {
             $this->assertTrue($errorObject, $e->getMessage());
         }