Passed
Push — master ( 2bd104...ffa3c7 )
by Darío
03:48
created
public/index.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 date_default_timezone_set("America/Bogota");
7 7
 
8 8
 // Memory limit
9
-ini_set("memory_limit","256M");
9
+ini_set("memory_limit", "256M");
10 10
 
11 11
 // Run application
12 12
 require_once("vendor/autoload.php");
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,9 +13,9 @@
 block discarded – undo
13 13
 
14 14
 try
15 15
 {
16
-	$config = include "config/application.config.php";
17
-	$mvc = new Drone\Mvc\Application($config);
18
-	$mvc->run();
16
+    $config = include "config/application.config.php";
17
+    $mvc = new Drone\Mvc\Application($config);
18
+    $mvc->run();
19 19
 }
20 20
 # to load only the error view
21 21
 catch (Drone\Mvc\Exception\ViewNotFoundException $e)
Please login to merge, or discard this patch.
module/Auth/source/Controller/LogIn.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
             $http = new Http();
87 87
             $http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
88 88
 
89
-            die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
89
+            die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
90 90
         }
91 91
 
92 92
         $this->checkSession();
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
                 $http = new Http();
117 117
                 $http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
118 118
 
119
-                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
119
+                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
120 120
             }
121 121
 
122 122
             # STANDARD VALIDATIONS [check needed arguments]
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
                     $http = new Http();
129 129
                     $http->writeStatus($http::HTTP_BAD_REQUEST);
130 130
 
131
-                    die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
131
+                    die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
132 132
                 }
133 133
             });
134 134
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
             foreach ($errors as $errno => $error)
269 269
             {
270 270
                 $errorInformation .=
271
-                    "<strong style='color: #a94442'>".
271
+                    "<strong style='color: #a94442'>" .
272 272
                         $method
273 273
                             . "</strong>: <span style='color: #e24f4c'>{$error}</span> \n<br />";
274 274
             }
Please login to merge, or discard this patch.
Braces   +46 added lines, -36 removed lines patch added patch discarded remove patch
@@ -39,8 +39,9 @@  discard block
 block discarded – undo
39 39
      */
40 40
     private function getUserAdapter()
41 41
     {
42
-        if (!is_null($this->userAdapter))
43
-            return $this->userAdapter;
42
+        if (!is_null($this->userAdapter)) {
43
+                    return $this->userAdapter;
44
+        }
44 45
 
45 46
         $this->userAdapter = new EntityAdapter(new TableGateway(new User()));
46 47
 
@@ -52,8 +53,9 @@  discard block
 block discarded – undo
52 53
      */
53 54
     private function getUserRoleAdapter()
54 55
     {
55
-        if (!is_null($this->userRoleAdapter))
56
-            return $this->userRoleAdapter;
56
+        if (!is_null($this->userRoleAdapter)) {
57
+                    return $this->userRoleAdapter;
58
+        }
57 59
 
58 60
         $this->userRoleAdapter = new EntityAdapter(new TableGateway(new UserRole()));
59 61
 
@@ -65,8 +67,9 @@  discard block
 block discarded – undo
65 67
      */
66 68
     private function getDbUserRoleAdapter()
67 69
     {
68
-        if (!is_null($this->dbUserRoleAdapter))
69
-            return $this->dbUserRoleAdapter;
70
+        if (!is_null($this->dbUserRoleAdapter)) {
71
+                    return $this->dbUserRoleAdapter;
72
+        }
70 73
 
71 74
         $this->dbUserRoleAdapter = new EntityAdapter(new TableGateway(new DbUserRole()));
72 75
 
@@ -95,24 +98,27 @@  discard block
 block discarded – undo
95 98
          * $_SESSION["last_uri_" . $global_config["project"]["id"]] = $_SERVER["REQUEST_URI"];
96 99
          * It should be an unique session id for the app to prevent bad redirections with other projects.
97 100
          */
98
-        if (array_key_exists("last_uri_" . $global_config["project"]["id"], $_SESSION) || !empty($_SESSION["last_uri_" . $global_config["project"]["id"]]))
99
-            $location = $_SESSION["last_uri_" . $global_config["project"]["id"]];
100
-        else
101
-            $location = $this->getBasePath() . "/public/" . $config["redirect"];
101
+        if (array_key_exists("last_uri_" . $global_config["project"]["id"], $_SESSION) || !empty($_SESSION["last_uri_" . $global_config["project"]["id"]])) {
102
+                    $location = $_SESSION["last_uri_" . $global_config["project"]["id"]];
103
+        } else {
104
+                    $location = $this->getBasePath() . "/public/" . $config["redirect"];
105
+        }
102 106
 
103 107
         switch ($method)
104 108
         {
105 109
             case '_COOKIE':
106 110
 
107
-                if (array_key_exists($key, $_COOKIE) || !empty($_COOKIE[$key]))
108
-                    header("location: " . $location);
111
+                if (array_key_exists($key, $_COOKIE) || !empty($_COOKIE[$key])) {
112
+                                    header("location: " . $location);
113
+                }
109 114
 
110 115
                 break;
111 116
 
112 117
             case '_SESSION':
113 118
 
114
-                if (array_key_exists($key, $_SESSION) || !empty($_SESSION[$key]))
115
-                    header("location: " . $location);
119
+                if (array_key_exists($key, $_SESSION) || !empty($_SESSION[$key])) {
120
+                                    header("location: " . $location);
121
+                }
116 122
 
117 123
                 break;
118 124
         }
@@ -241,14 +247,14 @@  discard block
 block discarded – undo
241 247
                                 $username_str => strtoupper($post["username"])
242 248
                             ]);
243 249
 
244
-                            if (!count($rowset))
245
-                                throw new \Drone\Exception\Exception("Your user is not authorized to use this application!");
250
+                            if (!count($rowset)) {
251
+                                                            throw new \Drone\Exception\Exception("Your user is not authorized to use this application!");
252
+                            }
246 253
                         }
247 254
 
248 255
                         $auth = new Authentication("default", false);
249 256
                         $result = $auth->authenticate($post["username"], $post["password"]);
250
-                    }
251
-                    catch (\Drone\Db\Driver\Exception\ConnectionException $e)
257
+                    } catch (\Drone\Db\Driver\Exception\ConnectionException $e)
252 258
                     {
253 259
                         throw new \Drone\Exception\Exception("Wrong user or password");
254 260
                     }
@@ -261,8 +267,9 @@  discard block
 block discarded – undo
261 267
                         $username_str => $post["username"]
262 268
                     ]);
263 269
 
264
-                    if (!count($rowset))
265
-                        throw new \Drone\Exception\Exception("Username or password are incorrect");
270
+                    if (!count($rowset)) {
271
+                                            throw new \Drone\Exception\Exception("Username or password are incorrect");
272
+                    }
266 273
 
267 274
                     $user = array_shift($rowset);
268 275
 
@@ -274,23 +281,26 @@  discard block
 block discarded – undo
274 281
                             $id_field => $user->{$id_field}
275 282
                         ]);
276 283
 
277
-                        if (!count($rowset))
278
-                            throw new \Drone\Exception\Exception("Your user is not authorized to use this application!");
284
+                        if (!count($rowset)) {
285
+                                                    throw new \Drone\Exception\Exception("Your user is not authorized to use this application!");
286
+                        }
279 287
                     }
280 288
 
281 289
                     $state_field = $config["authentication"]["gateway"]["table_info"]["columns"]["state_field"];
282 290
                     $state_pending_value = $config["authentication"]["gateway"]["table_info"]["column_values"]["state_field"]["pending_email"];
283 291
 
284
-                    if ($user->{$state_field} == $state_pending_value)
285
-                        throw new \Drone\Exception\Exception("User pending of email checking");
292
+                    if ($user->{$state_field} == $state_pending_value) {
293
+                                            throw new \Drone\Exception\Exception("User pending of email checking");
294
+                    }
286 295
 
287 296
                     $securePass = $user->{$password_str};
288 297
                     $password = $post["password"];
289 298
 
290 299
                     $bcrypt = new Bcrypt();
291 300
 
292
-                    if (!$bcrypt->verify($password, $securePass))
293
-                        throw new \Drone\Exception\Exception("Username or password are incorrect");
301
+                    if (!$bcrypt->verify($password, $securePass)) {
302
+                                            throw new \Drone\Exception\Exception("Username or password are incorrect");
303
+                    }
294 304
 
295 305
                     break;
296 306
 
@@ -315,14 +325,12 @@  discard block
 block discarded – undo
315 325
 
316 326
             # SUCCESS-MESSAGE
317 327
             $data["process"] = "success";
318
-        }
319
-        catch (\Drone\Exception\Exception $e)
328
+        } catch (\Drone\Exception\Exception $e)
320 329
         {
321 330
             # ERROR-MESSAGE
322 331
             $data["process"] = "warning";
323 332
             $data["message"] = $e->getMessage();
324
-        }
325
-        catch (\Exception $e)
333
+        } catch (\Exception $e)
326 334
         {
327 335
             $file = str_replace('\\', '', __CLASS__);
328 336
             $storage = new \Drone\Exception\Storage("cache/$file.json");
@@ -337,8 +345,9 @@  discard block
 block discarded – undo
337 345
             }
338 346
 
339 347
             # errors retrived by the use of ErrorTrait
340
-            if (count($this->getErrors()))
341
-                $this->handleErrors($this->getErrors(), __METHOD__);
348
+            if (count($this->getErrors())) {
349
+                            $this->handleErrors($this->getErrors(), __METHOD__);
350
+            }
342 351
 
343 352
             $data["code"]    = $errorCode;
344 353
             $data["message"] = $e->getMessage();
@@ -374,15 +383,16 @@  discard block
 block discarded – undo
374 383
             if (!$hd || !@fwrite($hd, $errorInformation))
375 384
             {
376 385
                 # error storing are not mandatory!
386
+            } else {
387
+                            @fclose($hd);
377 388
             }
378
-            else
379
-                @fclose($hd);
380 389
 
381 390
             $config = include 'config/application.config.php';
382 391
             $dev = $config["environment"]["dev_mode"];
383 392
 
384
-            if ($dev)
385
-                echo $errorInformation;
393
+            if ($dev) {
394
+                            echo $errorInformation;
395
+            }
386 396
         }
387 397
     }
388 398
 }
389 399
\ No newline at end of file
Please login to merge, or discard this patch.
module/Auth/source/Controller/LogOut.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
             $http = new Http();
21 21
             $http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
22 22
 
23
-            die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
23
+            die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
24 24
         }
25 25
 
26 26
         $config = include 'module/Auth/config/user.config.php';
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,8 +30,9 @@
 block discarded – undo
30 30
         switch ($method)
31 31
         {
32 32
             case '_COOKIE':
33
-                if (array_key_exists($key, $_COOKIE) || !empty($_COOKIE[$key]))
34
-                    setcookie($key, $_COOKIE[$key], time() - 1, '/');
33
+                if (array_key_exists($key, $_COOKIE) || !empty($_COOKIE[$key])) {
34
+                                    setcookie($key, $_COOKIE[$key], time() - 1, '/');
35
+                }
35 36
                 break;
36 37
 
37 38
             case '_SESSION':
Please login to merge, or discard this patch.
module/Auth/source/Model/Authentication.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,9 +21,10 @@
 block discarded – undo
21 21
         $db->setDbuser($user);
22 22
         $db->setDbpass($pass);
23 23
 
24
-        if ($db->isConnected())
25
-            return $db->reconnect()
24
+        if ($db->isConnected()) {
25
+                    return $db->reconnect()
26 26
         else
27 27
             return $db->connect();
28
+        }
28 29
     }
29 30
 }
30 31
\ No newline at end of file
Please login to merge, or discard this patch.
module/Auth/lang/en.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,12 +3,12 @@
 block discarded – undo
3 3
 return [
4 4
     "Register form" => "Register form",
5 5
     "User registering" => "User registering",
6
-	"Username" => "Username",
7
-	"username" => "username",
8
-	"Email" => "Email",
9
-	"email" => "email",
10
-	"Password" => "Password",
11
-	"password" => "password",
6
+    "Username" => "Username",
7
+    "username" => "username",
8
+    "Email" => "Email",
9
+    "email" => "email",
10
+    "Password" => "Password",
11
+    "password" => "password",
12 12
     "Repeat your password" => "Repeat your password",
13 13
     "Register now" => "Register now",
14 14
     "Log in" => "Log in",
Please login to merge, or discard this patch.
module/Auth/config/module.config.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 return [
4 4
     'router' => [
5 5
         'routes' => [
6
-        	'Auth' => [
7
-        		'module' => 'Auth',
8
-        		'controller' => 'LogIn',
9
-        		'view' => 'index'
10
-        	]
6
+            'Auth' => [
7
+                'module' => 'Auth',
8
+                'controller' => 'LogIn',
9
+                'view' => 'index'
10
+            ]
11 11
         ],
12 12
     ],
13 13
     'view_manager' => [
Please login to merge, or discard this patch.
module/Utils/source/Model/Entity.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,5 +6,5 @@
 block discarded – undo
6 6
 
7 7
 class Entity extends DbEntity
8 8
 {
9
-	// general table gateway
9
+    // general table gateway
10 10
 }
11 11
\ No newline at end of file
Please login to merge, or discard this patch.
module/Utils/Module.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -7,8 +7,8 @@
 block discarded – undo
7 7
 
8 8
 class Module extends AbstractionModule
9 9
 {
10
-	public function init(AbstractionController $c)
11
-	{
12
-		// init procedures
13
-	}
10
+    public function init(AbstractionController $c)
11
+    {
12
+        // init procedures
13
+    }
14 14
 }
15 15
\ No newline at end of file
Please login to merge, or discard this patch.
module/Utils/config/module.config.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 return [
4 4
     'router' => [
5 5
         'routes' => [
6
-        	'Utils' => [
7
-        		'module' => 'Utils',
8
-        		'controller' => '',
9
-        		'view' => ''
10
-        	]
6
+            'Utils' => [
7
+                'module' => 'Utils',
8
+                'controller' => '',
9
+                'view' => ''
10
+            ]
11 11
         ],
12 12
     ],
13 13
     'view_manager' => [
Please login to merge, or discard this patch.