ImageSliderItem::getCMSFields() - Code Metrics - Inspection of "adding slider block" - Pixelneat/silverstripe-content-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (003c26)

by Pixelneat

created 2017-05-04 14:05 UTC

ImageSliderItem::getCMSFields() A

↳ Parent: ImageSliderItem

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	0

<?php

/**
 * @author    Donatas Navidonskis <[email protected]>
 * @since     2017
 * @class     ImageSliderItem
 *
 * @property int PictureID
 *
 * @method Image Picture
 */
class ImageSliderItem extends BaseSliderItem {
namespace YourVendor;

class YourClass { }

    /**
     * @var array
     * @config
     */
    private static $has_one = [

        'Picture' => 'Image',
    ];

    /**
     * @return string
     */
    public function singular_name() {
        return _t('ImageSliderItem.SINGULARNAME', 'Image slider');
    }

    /**
     * @return string
     */
    public function plural_name() {
        return _t('ImageSliderItem.PLURALNAME', 'Image sliders');
    }

    /**
     * @return \FieldList
     */
    public function getCMSFields() {
        $fields = parent::getCMSFields();
        $fields->removeByName(['Picture']);
        $fields->findOrMakeTab('Root.Media', $this->fieldLabel('Media'));

        $fields->addFieldToTab('Root.Media', $uploadField = UploadField::create('Picture', $this->fieldLabel('Picture')));

        $uploadField
            ->setAllowedMaxFileNumber(1)
            ->setAllowedFileCategories('image')
            ->setFolderName(
                sprintf('%s/Sliders', BaseBlock::config()->upload_directory)
            );

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }
}

1			<?php
2
3			/**
4			* @author Donatas Navidonskis <[email protected]>
5			* @since 2017
6			* @class ImageSliderItem
7			*
8			* @property int PictureID
9			*
10			* @method Image Picture
11			*/
12			class ImageSliderItem extends BaseSliderItem {
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-04 14:07 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
13
14			/**
15			* @var array
16			* @config
17			*/
18			private static $has_one = [
			0 ignored issues – show Comprehensibility introduced 2017-05-04 14:07 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-05-03 11:25 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19			'Picture' => 'Image',
20			];
21
22			/**
23			* @return string
24			*/
25			public function singular_name() {
26			return _t('ImageSliderItem.SINGULARNAME', 'Image slider');
27			}
28
29			/**
30			* @return string
31			*/
32			public function plural_name() {
33			return _t('ImageSliderItem.PLURALNAME', 'Image sliders');
34			}
35
36			/**
37			* @return \FieldList
38			*/
39			public function getCMSFields() {
40			$fields = parent::getCMSFields();
41			$fields->removeByName(['Picture']);
42			$fields->findOrMakeTab('Root.Media', $this->fieldLabel('Media'));
43
44			$fields->addFieldToTab('Root.Media', $uploadField = UploadField::create('Picture', $this->fieldLabel('Picture')));
45
46			$uploadField
47			->setAllowedMaxFileNumber(1)
48			->setAllowedFileCategories('image')
49			->setFolderName(
50			sprintf('%s/Sliders', BaseBlock::config()->upload_directory)
51			);
52
53			$this->extend('updateCMSFields', $fields);
54
55			return $fields;
56			}
57			}

Pixelneat / silverstripe-content-blocks

Branch — master (003c26)

ImageSliderItem::getCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like