ImageSliderItem

Complexity

Total Complexity

3

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	singular_name()	0	3	1
A	plural_name()	0	3	1
A	getCMSFields()	0	18	1

<?php

/**
 * @author    Donatas Navidonskis <donatas@navidonskis.com>
 * @since     2017
 * @class     ImageSliderItem
 *
 * @property int PictureID
 *
 * @method Image Picture
 */
class ImageSliderItem extends BaseSliderItem {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @var array
     * @config
     */
    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Picture' => 'Image',
    ];

    /**
     * @return string
     */
    public function singular_name() {
        return _t('ImageSliderItem.SINGULARNAME', 'Image slider');
    }

    /**
     * @return string
     */
    public function plural_name() {
        return _t('ImageSliderItem.PLURALNAME', 'Image sliders');
    }

    /**
     * @return \FieldList
     */
    public function getCMSFields() {
        $fields = parent::getCMSFields();
        $fields->removeByName(['Picture']);
        $fields->findOrMakeTab('Root.Media', $this->fieldLabel('Media'));

        $fields->addFieldToTab('Root.Media', $uploadField = UploadField::create('Picture', $this->fieldLabel('Picture')));

        $uploadField
            ->setAllowedMaxFileNumber(1)
            ->setAllowedFileCategories('image')
            ->setFolderName(
                sprintf('%s/Sliders', BaseBlock::config()->upload_directory)
            );

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }
}