Inspection of "[func] add test if user is logged" - Piou-piou/RibsAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 865369...be2445 )

by Anthony

created 2020-06-23 07:09 UTC

Status

Indentation +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -12,38 +12,38 @@
 block discarded – undo
 	 */
 	private $user;
 
-    /**
-     * CreateUpdateAwareListener constructor.
-     * @param TokenStorage $tokenStorage
-     */
-    public function __construct(TokenStorage $tokenStorage)
+				/**
+				 * CreateUpdateAwareListener constructor.
+				 * @param TokenStorage $tokenStorage
+				 */
+				public function __construct(TokenStorage $tokenStorage)
 	{
-        if ($tokenStorage->getToken() && is_object($tokenStorage->getToken()->getUser()) && $tokenStorage->getToken()->getUser()->getUser()) {
-            $this->user = $tokenStorage->getToken()->getUser()->getUser();
-        } else {
-            $this->user = null;
-        }
+								if ($tokenStorage->getToken() && is_object($tokenStorage->getToken()->getUser()) && $tokenStorage->getToken()->getUser()->getUser()) {
+												$this->user = $tokenStorage->getToken()->getUser()->getUser();
+								} else {
+												$this->user = null;
+								}
 	}
 	
 	public function prePersist($entity)
 	{
-	    if ($this->user) {
-            if ($entity->getCreatedBy() === null) {
-                $entity->setCreatedAt(new \DateTime());
-                $entity->setCreatedBy($this->user);
-            }
-            if ($entity->getUpdatedBy() === null) {
-                $entity->setUpdatedAt(new \DateTime());
-                $entity->setUpdatedBy($this->user);
-            }
-        }
+					if ($this->user) {
+												if ($entity->getCreatedBy() === null) {
+																$entity->setCreatedAt(new \DateTime());
+																$entity->setCreatedBy($this->user);
+												}
+												if ($entity->getUpdatedBy() === null) {
+																$entity->setUpdatedAt(new \DateTime());
+																$entity->setUpdatedBy($this->user);
+												}
+								}
 	}
 
-    public function preUpdate($entity)
-    {
-        if ($this->user) {
-            $entity->setUpdatedAt(new \DateTime());
-            $entity->setUpdatedBy($this->user);
-        }
-    }
+				public function preUpdate($entity)
+				{
+								if ($this->user) {
+												$entity->setUpdatedAt(new \DateTime());
+												$entity->setUpdatedBy($this->user);
+								}
+				}
 }

Please login to merge, or discard this patch.

Entity/UserLogs.php 1 patch

Indentation +124 added lines, -124 removed lines patch added patch discarded remove patch

@@ -13,129 +13,129 @@
 block discarded – undo
  */
 class UserLogs
 {
-    use CreatedUpdatedTrait;
-
-    /**
-     * @var integer
-     *
-     * @ORM\Column(name="id", type="integer", nullable=false)
-     * @ORM\Id
-     * @ORM\GeneratedValue(strategy="IDENTITY")
-     */
-    private $id;
-
-    /**
-     * @ORM\ManyToOne(targetEntity="PiouPiou\RibsAdminBundle\Entity\User")
-     * @ORM\JoinColumn(name="user_id", referencedColumnName="id", nullable=false)
-     */
-    private $user;
-
-    /**
-     * @var string
-     *
-     * @ORM\Column(name="method", type="string", length=255, nullable=false)
-     */
-    private $method;
-
-    /**
-     * @var string
-     *
-     * @ORM\Column(name="url", type="string", length=255, nullable=false)
-     */
-    private $url;
-
-    /**
-     * @var string
-     *
-     * @ORM\Column(name="equest_parameters", type="json", nullable=true)
-     */
-    private $request_parameters;
-
-    /**
-     * @return int
-     */
-    public function getId()
-    {
-        return $this->id;
-    }
-
-    /**
-     * @param int $id
-     */
-    public function setId($id)
-    {
-        $this->id = $id;
-    }
-
-    /**
-     * @return User
-     */
-    public function getUser(): User
-    {
-        return $this->user;
-    }
-
-    /**
-     * @param \User $user
-     */
-    public function setUser($user)
-    {
-        $this->user = $user;
-    }
-
-    /**
-     * @return string
-     */
-    public function getMethod(): string
-    {
-        return $this->method;
-    }
-
-    /**
-     * @param string $method
-     * @return UserLogs
-     */
-    public function setMethod(string $method): UserLogs
-    {
-        $this->method = $method;
-
-        return $this;
-    }
-
-    /**
-     * @return string
-     */
-    public function getUrl(): string
-    {
-        return $this->url;
-    }
-
-    /**
-     * @param string $url
-     * @return UserLogs
-     */
-    public function setUrl(string $url): UserLogs
-    {
-        $this->url = $url;
-
-        return $this;
-    }
-
-
-    public function getRequestParameters()
-    {
-        return $this->request_parameters;
-    }
-
-    /**
-     * @param $request_parameters
-     * @return UserLogs
-     */
-    public function setRequestParameters($request_parameters): UserLogs
-    {
-        $this->request_parameters = $request_parameters;
-
-        return $this;
-    }
+				use CreatedUpdatedTrait;
+
+				/**
+				 * @var integer
+				 *
+				 * @ORM\Column(name="id", type="integer", nullable=false)
+				 * @ORM\Id
+				 * @ORM\GeneratedValue(strategy="IDENTITY")
+				 */
+				private $id;
+
+				/**
+				 * @ORM\ManyToOne(targetEntity="PiouPiou\RibsAdminBundle\Entity\User")
+				 * @ORM\JoinColumn(name="user_id", referencedColumnName="id", nullable=false)
+				 */
+				private $user;
+
+				/**
+				 * @var string
+				 *
+				 * @ORM\Column(name="method", type="string", length=255, nullable=false)
+				 */
+				private $method;
+
+				/**
+				 * @var string
+				 *
+				 * @ORM\Column(name="url", type="string", length=255, nullable=false)
+				 */
+				private $url;
+
+				/**
+				 * @var string
+				 *
+				 * @ORM\Column(name="equest_parameters", type="json", nullable=true)
+				 */
+				private $request_parameters;
+
+				/**
+				 * @return int
+				 */
+				public function getId()
+				{
+								return $this->id;
+				}
+
+				/**
+				 * @param int $id
+				 */
+				public function setId($id)
+				{
+								$this->id = $id;
+				}
+
+				/**
+				 * @return User
+				 */
+				public function getUser(): User
+				{
+								return $this->user;
+				}
+
+				/**
+				 * @param \User $user
+				 */
+				public function setUser($user)
+				{
+								$this->user = $user;
+				}
+
+				/**
+				 * @return string
+				 */
+				public function getMethod(): string
+				{
+								return $this->method;
+				}
+
+				/**
+				 * @param string $method
+				 * @return UserLogs
+				 */
+				public function setMethod(string $method): UserLogs
+				{
+								$this->method = $method;
+
+								return $this;
+				}
+
+				/**
+				 * @return string
+				 */
+				public function getUrl(): string
+				{
+								return $this->url;
+				}
+
+				/**
+				 * @param string $url
+				 * @return UserLogs
+				 */
+				public function setUrl(string $url): UserLogs
+				{
+								$this->url = $url;
+
+								return $this;
+				}
+
+
+				public function getRequestParameters()
+				{
+								return $this->request_parameters;
+				}
+
+				/**
+				 * @param $request_parameters
+				 * @return UserLogs
+				 */
+				public function setRequestParameters($request_parameters): UserLogs
+				{
+								$this->request_parameters = $request_parameters;
+
+								return $this;
+				}
 }
 

Please login to merge, or discard this patch.

Service/UserLog.php 1 patch

Indentation +35 added lines, -35 removed lines patch added patch discarded remove patch

@@ -9,43 +9,43 @@
 block discarded – undo
 
 class UserLog
 {
-    /**
-     * @var TokenStorageInterface
-     */
-    private $token_storage;
+				/**
+				 * @var TokenStorageInterface
+				 */
+				private $token_storage;
 
-    /**
-     * @var EntityManagerInterface a
-     */
-    private $em;
+				/**
+				 * @var EntityManagerInterface a
+				 */
+				private $em;
 
-    public function __construct(TokenStorageInterface $token_storage, EntityManagerInterface $em)
-    {
-        $this->token_storage = $token_storage;
-        $this->em = $em;
-    }
+				public function __construct(TokenStorageInterface $token_storage, EntityManagerInterface $em)
+				{
+								$this->token_storage = $token_storage;
+								$this->em = $em;
+				}
 
-    /**
-     * @param RequestEvent $request_event
-     */
-    public function onKernelRequest(RequestEvent $request_event)
-    {
-        if ($request_event->isMasterRequest()) {
-            $user = null;
-            if ($this->token_storage->getToken() && is_object($this->token_storage->getToken()->getUser()) && $this->token_storage->getToken()->getUser()->getUser()) {
-                $user = $this->token_storage->getToken()->getUser()->getUser();
-            }
-            $request = $request_event->getRequest();
+				/**
+				 * @param RequestEvent $request_event
+				 */
+				public function onKernelRequest(RequestEvent $request_event)
+				{
+								if ($request_event->isMasterRequest()) {
+												$user = null;
+												if ($this->token_storage->getToken() && is_object($this->token_storage->getToken()->getUser()) && $this->token_storage->getToken()->getUser()->getUser()) {
+																$user = $this->token_storage->getToken()->getUser()->getUser();
+												}
+												$request = $request_event->getRequest();
 
-            if ($user) {
-                $user_log = new UserLogs();
-                $user_log->setMethod($request->getMethod());
-                $user_log->setUser($user);
-                $user_log->setUrl($request->get("_route"));
-                $user_log->setRequestParameters($request->request->all());
-                $this->em->persist($user_log);
-                $this->em->flush();
-            }
-        }
-    }
+												if ($user) {
+																$user_log = new UserLogs();
+																$user_log->setMethod($request->getMethod());
+																$user_log->setUser($user);
+																$user_log->setUrl($request->get("_route"));
+																$user_log->setRequestParameters($request->request->all());
+																$this->em->persist($user_log);
+																$this->em->flush();
+												}
+								}
+				}
 }

Please login to merge, or discard this patch.

		@@ -12,38 +12,38 @@
		block discarded – undo
12	12	*/
13	13	private $user;
14	14
15		- /**
16		- * CreateUpdateAwareListener constructor.
17		- * @param TokenStorage $tokenStorage
18		- */
19		- public function __construct(TokenStorage $tokenStorage)
	15	+ /**
	16	+ * CreateUpdateAwareListener constructor.
	17	+ * @param TokenStorage $tokenStorage
	18	+ */
	19	+ public function __construct(TokenStorage $tokenStorage)
20	20	{
21		- if ($tokenStorage->getToken() && is_object($tokenStorage->getToken()->getUser()) && $tokenStorage->getToken()->getUser()->getUser()) {
22		- $this->user = $tokenStorage->getToken()->getUser()->getUser();
23		- } else {
24		- $this->user = null;
25		- }
	21	+ if ($tokenStorage->getToken() && is_object($tokenStorage->getToken()->getUser()) && $tokenStorage->getToken()->getUser()->getUser()) {
	22	+ $this->user = $tokenStorage->getToken()->getUser()->getUser();
	23	+ } else {
	24	+ $this->user = null;
	25	+ }
26	26	}
27	27
28	28	public function prePersist($entity)
29	29	{
30		- if ($this->user) {
31		- if ($entity->getCreatedBy() === null) {
32		- $entity->setCreatedAt(new \DateTime());
33		- $entity->setCreatedBy($this->user);
34		- }
35		- if ($entity->getUpdatedBy() === null) {
36		- $entity->setUpdatedAt(new \DateTime());
37		- $entity->setUpdatedBy($this->user);
38		- }
39		- }
	30	+ if ($this->user) {
	31	+ if ($entity->getCreatedBy() === null) {
	32	+ $entity->setCreatedAt(new \DateTime());
	33	+ $entity->setCreatedBy($this->user);
	34	+ }
	35	+ if ($entity->getUpdatedBy() === null) {
	36	+ $entity->setUpdatedAt(new \DateTime());
	37	+ $entity->setUpdatedBy($this->user);
	38	+ }
	39	+ }
40	40	}
41	41
42		- public function preUpdate($entity)
43		- {
44		- if ($this->user) {
45		- $entity->setUpdatedAt(new \DateTime());
46		- $entity->setUpdatedBy($this->user);
47		- }
48		- }
	42	+ public function preUpdate($entity)
	43	+ {
	44	+ if ($this->user) {
	45	+ $entity->setUpdatedAt(new \DateTime());
	46	+ $entity->setUpdatedBy($this->user);
	47	+ }
	48	+ }
49	49	}

		@@ -13,129 +13,129 @@
		block discarded – undo
13	13	*/
14	14	class UserLogs
15	15	{
16		- use CreatedUpdatedTrait;
17		-
18		- /**
19		- * @var integer
20		- *
21		- * @ORM\Column(name="id", type="integer", nullable=false)
22		- * @ORM\Id
23		- * @ORM\GeneratedValue(strategy="IDENTITY")
24		- */
25		- private $id;
26		-
27		- /**
28		- * @ORM\ManyToOne(targetEntity="PiouPiou\RibsAdminBundle\Entity\User")
29		- * @ORM\JoinColumn(name="user_id", referencedColumnName="id", nullable=false)
30		- */
31		- private $user;
32		-
33		- /**
34		- * @var string
35		- *
36		- * @ORM\Column(name="method", type="string", length=255, nullable=false)
37		- */
38		- private $method;
39		-
40		- /**
41		- * @var string
42		- *
43		- * @ORM\Column(name="url", type="string", length=255, nullable=false)
44		- */
45		- private $url;
46		-
47		- /**
48		- * @var string
49		- *
50		- * @ORM\Column(name="equest_parameters", type="json", nullable=true)
51		- */
52		- private $request_parameters;
53		-
54		- /**
55		- * @return int
56		- */
57		- public function getId()
58		- {
59		- return $this->id;
60		- }
61		-
62		- /**
63		- * @param int $id
64		- */
65		- public function setId($id)
66		- {
67		- $this->id = $id;
68		- }
69		-
70		- /**
71		- * @return User
72		- */
73		- public function getUser(): User
74		- {
75		- return $this->user;
76		- }
77		-
78		- /**
79		- * @param \User $user
80		- */
81		- public function setUser($user)
82		- {
83		- $this->user = $user;
84		- }
85		-
86		- /**
87		- * @return string
88		- */
89		- public function getMethod(): string
90		- {
91		- return $this->method;
92		- }
93		-
94		- /**
95		- * @param string $method
96		- * @return UserLogs
97		- */
98		- public function setMethod(string $method): UserLogs
99		- {
100		- $this->method = $method;
101		-
102		- return $this;
103		- }
104		-
105		- /**
106		- * @return string
107		- */
108		- public function getUrl(): string
109		- {
110		- return $this->url;
111		- }
112		-
113		- /**
114		- * @param string $url
115		- * @return UserLogs
116		- */
117		- public function setUrl(string $url): UserLogs
118		- {
119		- $this->url = $url;
120		-
121		- return $this;
122		- }
123		-
124		-
125		- public function getRequestParameters()
126		- {
127		- return $this->request_parameters;
128		- }
129		-
130		- /**
131		- * @param $request_parameters
132		- * @return UserLogs
133		- */
134		- public function setRequestParameters($request_parameters): UserLogs
135		- {
136		- $this->request_parameters = $request_parameters;
137		-
138		- return $this;
139		- }
	16	+ use CreatedUpdatedTrait;
	17	+
	18	+ /**
	19	+ * @var integer
	20	+ *
	21	+ * @ORM\Column(name="id", type="integer", nullable=false)
	22	+ * @ORM\Id
	23	+ * @ORM\GeneratedValue(strategy="IDENTITY")
	24	+ */
	25	+ private $id;
	26	+
	27	+ /**
	28	+ * @ORM\ManyToOne(targetEntity="PiouPiou\RibsAdminBundle\Entity\User")
	29	+ * @ORM\JoinColumn(name="user_id", referencedColumnName="id", nullable=false)
	30	+ */
	31	+ private $user;
	32	+
	33	+ /**
	34	+ * @var string
	35	+ *
	36	+ * @ORM\Column(name="method", type="string", length=255, nullable=false)
	37	+ */
	38	+ private $method;
	39	+
	40	+ /**
	41	+ * @var string
	42	+ *
	43	+ * @ORM\Column(name="url", type="string", length=255, nullable=false)
	44	+ */
	45	+ private $url;
	46	+
	47	+ /**
	48	+ * @var string
	49	+ *
	50	+ * @ORM\Column(name="equest_parameters", type="json", nullable=true)
	51	+ */
	52	+ private $request_parameters;
	53	+
	54	+ /**
	55	+ * @return int
	56	+ */
	57	+ public function getId()
	58	+ {
	59	+ return $this->id;
	60	+ }
	61	+
	62	+ /**
	63	+ * @param int $id
	64	+ */
	65	+ public function setId($id)
	66	+ {
	67	+ $this->id = $id;
	68	+ }
	69	+
	70	+ /**
	71	+ * @return User
	72	+ */
	73	+ public function getUser(): User
	74	+ {
	75	+ return $this->user;
	76	+ }
	77	+
	78	+ /**
	79	+ * @param \User $user
	80	+ */
	81	+ public function setUser($user)
	82	+ {
	83	+ $this->user = $user;
	84	+ }
	85	+
	86	+ /**
	87	+ * @return string
	88	+ */
	89	+ public function getMethod(): string
	90	+ {
	91	+ return $this->method;
	92	+ }
	93	+
	94	+ /**
	95	+ * @param string $method
	96	+ * @return UserLogs
	97	+ */
	98	+ public function setMethod(string $method): UserLogs
	99	+ {
	100	+ $this->method = $method;
	101	+
	102	+ return $this;
	103	+ }
	104	+
	105	+ /**
	106	+ * @return string
	107	+ */
	108	+ public function getUrl(): string
	109	+ {
	110	+ return $this->url;
	111	+ }
	112	+
	113	+ /**
	114	+ * @param string $url
	115	+ * @return UserLogs
	116	+ */
	117	+ public function setUrl(string $url): UserLogs
	118	+ {
	119	+ $this->url = $url;
	120	+
	121	+ return $this;
	122	+ }
	123	+
	124	+
	125	+ public function getRequestParameters()
	126	+ {
	127	+ return $this->request_parameters;
	128	+ }
	129	+
	130	+ /**
	131	+ * @param $request_parameters
	132	+ * @return UserLogs
	133	+ */
	134	+ public function setRequestParameters($request_parameters): UserLogs
	135	+ {
	136	+ $this->request_parameters = $request_parameters;
	137	+
	138	+ return $this;
	139	+ }
140	140	}
141	141

		@@ -9,43 +9,43 @@
		block discarded – undo
9	9
10	10	class UserLog
11	11	{
12		- /**
13		- * @var TokenStorageInterface
14		- */
15		- private $token_storage;
	12	+ /**
	13	+ * @var TokenStorageInterface
	14	+ */
	15	+ private $token_storage;
16	16
17		- /**
18		- * @var EntityManagerInterface a
19		- */
20		- private $em;
	17	+ /**
	18	+ * @var EntityManagerInterface a
	19	+ */
	20	+ private $em;
21	21
22		- public function __construct(TokenStorageInterface $token_storage, EntityManagerInterface $em)
23		- {
24		- $this->token_storage = $token_storage;
25		- $this->em = $em;
26		- }
	22	+ public function __construct(TokenStorageInterface $token_storage, EntityManagerInterface $em)
	23	+ {
	24	+ $this->token_storage = $token_storage;
	25	+ $this->em = $em;
	26	+ }
27	27
28		- /**
29		- * @param RequestEvent $request_event
30		- */
31		- public function onKernelRequest(RequestEvent $request_event)
32		- {
33		- if ($request_event->isMasterRequest()) {
34		- $user = null;
35		- if ($this->token_storage->getToken() && is_object($this->token_storage->getToken()->getUser()) && $this->token_storage->getToken()->getUser()->getUser()) {
36		- $user = $this->token_storage->getToken()->getUser()->getUser();
37		- }
38		- $request = $request_event->getRequest();
	28	+ /**
	29	+ * @param RequestEvent $request_event
	30	+ */
	31	+ public function onKernelRequest(RequestEvent $request_event)
	32	+ {
	33	+ if ($request_event->isMasterRequest()) {
	34	+ $user = null;
	35	+ if ($this->token_storage->getToken() && is_object($this->token_storage->getToken()->getUser()) && $this->token_storage->getToken()->getUser()->getUser()) {
	36	+ $user = $this->token_storage->getToken()->getUser()->getUser();
	37	+ }
	38	+ $request = $request_event->getRequest();
39	39
40		- if ($user) {
41		- $user_log = new UserLogs();
42		- $user_log->setMethod($request->getMethod());
43		- $user_log->setUser($user);
44		- $user_log->setUrl($request->get("_route"));
45		- $user_log->setRequestParameters($request->request->all());
46		- $this->em->persist($user_log);
47		- $this->em->flush();
48		- }
49		- }
50		- }
	40	+ if ($user) {
	41	+ $user_log = new UserLogs();
	42	+ $user_log->setMethod($request->getMethod());
	43	+ $user_log->setUser($user);
	44	+ $user_log->setUrl($request->get("_route"));
	45	+ $user_log->setRequestParameters($request->request->all());
	46	+ $this->em->persist($user_log);
	47	+ $this->em->flush();
	48	+ }
	49	+ }
	50	+ }
51	51	}

Piou-piou / RibsAdminBundle

Push — master ( 865369...be2445 )

Status

Category

Indentation +27 added lines, -27 removed lines patch added patch discarded remove patch

Indentation +124 added lines, -124 removed lines patch added patch discarded remove patch

Indentation +35 added lines, -35 removed lines patch added patch discarded remove patch