SettlementsDatabaseQuery::addressLevel() - Code Metrics - Phrlog/GeoFixer - Measure and Improve Code Quality continuously with Scrutinizer

SettlementsDatabaseQuery::addressLevel() A
last analyzed 2018-02-14 10:32 UTC

↳ Parent: SettlementsDatabaseQuery

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

namespace GeoFixer\models\queries;

/**
 * Class SettlementsDatabaseQuery
 *
 * @package GeoFixer\models\queries
 */
class SettlementsDatabaseQuery extends AbstractDatabaseQuery
{
    /**
     * SettlementsDatabaseQuery constructor.
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Получаем города и поселения
     *
     * @return $this
     */
    public function getSettlements()
    {
        $this->db = $this->db->select([self::FIAS_CODE, self::TITLE, self::KLADR_CODE])->from('fias_address_object');

        return $this;
    }

    /**
     * Address level равен городу или поселению
     *
     * @param bool $full_settlements
     *
     * @return $this
     */
    public function addressLevel($full_settlements = false)
    {
        if ($full_settlements == false) {

            $this->db = $this->db->andWhere(['address_level' => self::CITY]);
        } else {
            $this->db = $this->db->andWhere(['OR' => [['address_level' => self::CITY], ['address_level' => self::SETTLEMENT]]]);
        }

        return $this;
    }
}


1		<?php
2
3		namespace GeoFixer\models\queries;
4
5		/**
6		* Class SettlementsDatabaseQuery
7		*
8		* @package GeoFixer\models\queries
9		*/
10		class SettlementsDatabaseQuery extends AbstractDatabaseQuery
11		{
12		/**
13		* SettlementsDatabaseQuery constructor.
14		*/
15	14	public function __construct()
16		{
17	14	parent::__construct();
18	14	}
19
20		/**
21		* Получаем города и поселения
22		*
23		* @return $this
24		*/
25	14	public function getSettlements()
26		{
27	14	$this->db = $this->db->select([self::FIAS_CODE, self::TITLE, self::KLADR_CODE])->from('fias_address_object');
28
29	14	return $this;
30		}
31
32		/**
33		* Address level равен городу или поселению
34		*
35		* @param bool $full_settlements
36		*
37		* @return $this
38		*/
39	14	public function addressLevel($full_settlements = false)
40		{
41	14	if ($full_settlements == false) {
		0 ignored issues – show Coding Style Best Practice introduced 2017-06-19 14:50 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
42	9	$this->db = $this->db->andWhere(['address_level' => self::CITY]);
43	9	} else {
44	5	$this->db = $this->db->andWhere(['OR' => [['address_level' => self::CITY], ['address_level' => self::SETTLEMENT]]]);
45		}
46
47	14	return $this;
48		}
49		}
50

Phrlog / GeoFixer

SettlementsDatabaseQuery::addressLevel() A last analyzed 2018-02-14 10:32 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

SettlementsDatabaseQuery::addressLevel() A
last analyzed 2018-02-14 10:32 UTC