GeoFixer\models\queries\SettlementsDatabaseQuery

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getSettlements()	0	6	1
A	addressLevel()	0	10	2

<?php

namespace GeoFixer\models\queries;

/**
 * Class SettlementsDatabaseQuery
 *
 * @package GeoFixer\models\queries
 */
class SettlementsDatabaseQuery extends AbstractDatabaseQuery
{
    /**
     * SettlementsDatabaseQuery constructor.
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Получаем города и поселения
     *
     * @return $this
     */
    public function getSettlements()
    {
        $this->db = $this->db->select([self::FIAS_CODE, self::TITLE, self::KLADR_CODE])->from('fias_address_object');

        return $this;
    }

    /**
     * Address level равен городу или поселению
     *
     * @param bool $full_settlements
     *
     * @return $this
     */
    public function addressLevel($full_settlements = false)
    {
        if ($full_settlements == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $this->db = $this->db->andWhere(['address_level' => self::CITY]);
        } else {
            $this->db = $this->db->andWhere(['OR' => [['address_level' => self::CITY], ['address_level' => self::SETTLEMENT]]]);
        }

        return $this;
    }
}