PartFire / MangoPayBundle

DependencyInjection/PartFireMangoPayExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
     }
 }

Models/Adapters/UserQuery.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
         Logger $logger,
         UserTranslator $userTranslator
     ) {
-        parent::__construct($clientId, $clientPassword, $baseUrl,$mangoPayApi, $logger);
+        parent::__construct($clientId, $clientPassword, $baseUrl, $mangoPayApi, $logger);
         $this->userTranslator = $userTranslator;
     }
 

Command/HookListCommand.php

Unused Use Statements -8 removed lines

@@ -16,19 +16,11 @@
 
 namespace PartFire\MangoPayBundle\Command;
 
-use Fruitful\IdentityCheckBundle\Entity\IdentityCheck;
-use Fruitful\IdentityCheckBundle\Entity\Repository\IdentityCheckFactoryRepository;
-use Fruitful\IdentityCheckBundle\Event\IdentityCheckUpdateEvent;
 use PartFire\CommonBundle\Services\Output\Cli\ConsoleOutput;
 use PartFire\MangoPayBundle\Services\Hook;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
-use Symfony\Component\Console\Input\InputArgument;
-use Symfony\Component\Console\Input\InputDefinition;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\EventDispatcher\EventDispatcher;
-use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 class HookListCommand extends ContainerAwareCommand
 {

Models/DTOs/UserNatural.php

Indentation +2 added lines, -2 removed lines

@@ -40,8 +40,8 @@
     }
 
         /**
-     * @return mixed
-     */
+         * @return mixed
+         */
     public function getFirstName()
     {
         return $this->firstName;

Services/HookHandleService.php

Unused Use Statements -2 removed lines

@@ -14,8 +14,6 @@
 
 namespace PartFire\MangoPayBundle\Services;
 
-use Composer\EventDispatcher\Event;
-use Fruitful\FFConstants;
 use PartFire\CommonBundle\Services\Output\CommonOutputInterface;
 use PartFire\MangoPayBundle\Entity\Hook;
 use PartFire\MangoPayBundle\Entity\Repository\HookRepository;

Spacing +3 added lines, -3 removed lines

@@ -87,7 +87,7 @@ 
     {
         $output->info(count($this->getAllNewWebhooks()) . " new hooks to check");
 
-        foreach($this->getAllNewWebhooks() as $webHook) {
+        foreach ($this->getAllNewWebhooks() as $webHook) {
             $output->infoid(" Processing hook ID " . $webHook->getResourceId() . " - Action Type = " . $webHook->getEventType());
             try {
                 $this->processWebhook($webHook, $output);
@@ -104,7 +104,7 @@ 
         if (MangoPayConstants::isEventTypeOk($hook->getEventType())) {
 
         } else {
-            $errMsg = "Received webhook from MangoPay *" . $hook->getEventType() ."*, which is unknown. Firing event anyway \n ```" . json_encode($hook->getRawHookData()) . "```";
+            $errMsg = "Received webhook from MangoPay *" . $hook->getEventType() . "*, which is unknown. Firing event anyway \n ```" . json_encode($hook->getRawHookData()) . "```";
             $commonOutput->error($errMsg);
             $this->sendErrorMessage(
                 $errMsg,
@@ -236,7 +236,7 @@ 
         return $this->mangoPayRepositoryFactory->saveAndGetEntity($hook);
     }
 
-    private function getIdentityCheckReportByOnfidoReportId(OnfidoHookQueue $onfidoHookQueue) : ?IdentityCheckReport
+    private function getIdentityCheckReportByOnfidoReportId(OnfidoHookQueue $onfidoHookQueue) : ? IdentityCheckReport
     {
         return $this->mangoPayRepositoryFactory->getIdentityCheckReport()->findOneByOnfidoReportId(
             $onfidoHookQueue->getResourceId()

Command/HookCreateAllCommand.php

Unused Use Statements -8 removed lines

@@ -14,20 +14,12 @@
 
 namespace PartFire\MangoPayBundle\Command;
 
-use Fruitful\IdentityCheckBundle\Entity\IdentityCheck;
-use Fruitful\IdentityCheckBundle\Entity\Repository\IdentityCheckFactoryRepository;
-use Fruitful\IdentityCheckBundle\Event\IdentityCheckUpdateEvent;
 use PartFire\CommonBundle\Services\Output\Cli\ConsoleOutput;
 use PartFire\MangoPayBundle\MangoPayConstants;
 use PartFire\MangoPayBundle\Services\Hook;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
-use Symfony\Component\Console\Input\InputArgument;
-use Symfony\Component\Console\Input\InputDefinition;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\EventDispatcher\EventDispatcher;
-use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 class HookCreateAllCommand extends ContainerAwareCommand
 {

Command/HookUpdateAllCommand.php

Unused Use Statements -8 removed lines

@@ -14,19 +14,11 @@
 
 namespace PartFire\MangoPayBundle\Command;
 
-use Fruitful\IdentityCheckBundle\Entity\IdentityCheck;
-use Fruitful\IdentityCheckBundle\Entity\Repository\IdentityCheckFactoryRepository;
-use Fruitful\IdentityCheckBundle\Event\IdentityCheckUpdateEvent;
 use PartFire\CommonBundle\Services\Output\Cli\ConsoleOutput;
 use PartFire\MangoPayBundle\Services\Hook;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
-use Symfony\Component\Console\Input\InputArgument;
-use Symfony\Component\Console\Input\InputDefinition;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\EventDispatcher\EventDispatcher;
-use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 class HookUpdateAllCommand extends ContainerAwareCommand
 {

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
         $responses = [];
 
         $hookItems = $this->getHookService()->list();
-        foreach($hookItems as $hook) {
+        foreach ($hookItems as $hook) {
             $hookId = $hook->Id;
             $this->output->infoid("Updating Hook ID " . $hookId . " with " . $url);
             try {

Models/Adapters/HookQuery.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         Logger $logger
 
     ) {
-        parent::__construct($clientId, $clientPassword, $baseUrl,$mangoPayApi, $logger);
+        parent::__construct($clientId, $clientPassword, $baseUrl, $mangoPayApi, $logger);
     }
 
     public function list()

MangoPayConstants.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
     // Hook Variables
     // https://docs.mangopay.com/endpoints/v2.01/hooks#e246_the-hook-object
     const       HOOK_EVENT_TYPE                     = "EventType";
-    const       HOOK_RESOURCE_ID                    = "RessourceId";  // Known spelling mistake in MangoPay Api
+    const       HOOK_RESOURCE_ID                    = "RessourceId"; // Known spelling mistake in MangoPay Api
     const       HOOK_DATE                           = "Date";
 
     // Event types

Doc Comments +3 added lines

@@ -329,6 +329,9 @@
         return self::isEventType("PREAUTHORIZATION_", $eventType);
     }
 
+    /**
+     * @param string $compareToEvent
+     */
     private static function isEventType($compareToEvent, $eventName)
     {
         $compareToEventLength = strlen($compareToEvent);