Failed Conditions
Pull Request — develop (#490)
by
unknown
65:34
created
tests/PhpSpreadsheetTests/Functional/DrawingImageHyperlinkTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
     /**
22 22
      * @throws \PhpOffice\PhpSpreadsheet\Exception
23 23
      */
24
-    public function testDrawingImageHyperlinkTest(){
24
+    public function testDrawingImageHyperlinkTest() {
25 25
 
26 26
         $spreadsheet = new Spreadsheet();
27 27
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
         $gdImage = @imagecreatetruecolor(120, 20) or die('Cannot Initialize new GD image stream');
32 32
         $textColor = imagecolorallocate($gdImage, 255, 255, 255);
33
-        imagestring($gdImage, 1, 5, 5,  'Created with PhpSpreadsheet', $textColor);
33
+        imagestring($gdImage, 1, 5, 5, 'Created with PhpSpreadsheet', $textColor);
34 34
 
35 35
         $drawing = new MemoryDrawing();
36 36
         $drawing->setName('In-Memory image 1');
@@ -42,14 +42,14 @@  discard block
 block discarded – undo
42 42
         );
43 43
         $drawing->setMimeType(MemoryDrawing::MIMETYPE_DEFAULT);
44 44
         $drawing->setHeight(36);
45
-        $hyperLink  = new Hyperlink(self::BASE_URL,'test image');
45
+        $hyperLink = new Hyperlink(self::BASE_URL, 'test image');
46 46
         $drawing->setHyperlink($hyperLink);
47 47
         $drawing->setWorksheet($aSheet);
48 48
 
49 49
         $reloadedSpreadsheet = $this->writeAndReload($spreadsheet, 'Xlsx');
50 50
 
51
-        foreach ($reloadedSpreadsheet->getActiveSheet()->getDrawingCollection() as $pDrawing){
52
-            self::assertEquals(self::BASE_URL , $pDrawing->getHyperlink()->getUrl(), 'functional test drawing hyperlink');
51
+        foreach ($reloadedSpreadsheet->getActiveSheet()->getDrawingCollection() as $pDrawing) {
52
+            self::assertEquals(self::BASE_URL, $pDrawing->getHyperlink()->getUrl(), 'functional test drawing hyperlink');
53 53
         }
54 54
     }
55 55
 }
56 56
\ No newline at end of file
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xlsx/Drawing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -187,10 +187,10 @@
 block discarded – undo
187 187
             $objWriter->writeAttribute('descr', $pDrawing->getDescription());
188 188
 
189 189
             //a:hlinkClick
190
-            if($pHlinkClickId >= 0) {
190
+            if ($pHlinkClickId >= 0) {
191 191
                 $objWriter->startElement('a:hlinkClick');
192
-                $objWriter->writeAttribute('xmlns:r','http://schemas.openxmlformats.org/officeDocument/2006/relationships');
193
-                $objWriter->writeAttribute('r:id','rId' . $pHlinkClickId );
192
+                $objWriter->writeAttribute('xmlns:r', 'http://schemas.openxmlformats.org/officeDocument/2006/relationships');
193
+                $objWriter->writeAttribute('r:id', 'rId' . $pHlinkClickId);
194 194
                 $objWriter->endElement();
195 195
             }
196 196
 
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xlsx/Rels.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -304,7 +304,7 @@
 block discarded – undo
304 304
                     '../media/' . str_replace(' ', '', $drawing->getIndexedFilename())
305 305
                 );
306 306
 
307
-                if(!empty($drawing->getHyperlink()->getUrl())){
307
+                if (!empty($drawing->getHyperlink()->getUrl())) {
308 308
                     ++$i;
309 309
                     $this->writeRelationship(
310 310
                         $objWriter,
Please login to merge, or discard this patch.