Completed
Pull Request — develop (#142)
by Dominik
24:13
created
src/PhpSpreadsheet/Chart/Properties.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -136,6 +136,11 @@  discard block
 block discarded – undo
136 136
         return (string) 100 - $alpha . '000';
137 137
     }
138 138
 
139
+    /**
140
+     * @param string $color
141
+     * @param integer $alpha
142
+     * @param string $type
143
+     */
139 144
     protected function setColorProperties($color, $alpha, $type)
140 145
     {
141 146
         return [
@@ -145,6 +150,9 @@  discard block
 block discarded – undo
145 150
         ];
146 151
     }
147 152
 
153
+    /**
154
+     * @param string $array_kay_selector
155
+     */
148 156
     protected function getLineStyleArrowSize($array_selector, $array_kay_selector)
149 157
     {
150 158
         $sizes = [
@@ -162,6 +170,9 @@  discard block
 block discarded – undo
162 170
         return $sizes[$array_selector][$array_kay_selector];
163 171
     }
164 172
 
173
+    /**
174
+     * @param integer $shadow_presets_option
175
+     */
165 176
     protected function getShadowPresetsMap($shadow_presets_option)
166 177
     {
167 178
         $presets_options = [
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/Trend/BestFit.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -316,6 +316,10 @@
 block discarded – undo
316 316
         return $this->yBestFitValues;
317 317
     }
318 318
 
319
+    /**
320
+     * @param double $sumY2
321
+     * @param boolean $const
322
+     */
319 323
     protected function calculateGoodnessOfFit($sumX, $sumY, $sumX2, $sumY2, $sumXY, $meanX, $meanY, $const)
320 324
     {
321 325
         $SSres = $SScov = $SScor = $SStot = $SSsex = 0.0;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/AutoFilter.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -567,6 +567,11 @@
 block discarded – undo
567 567
         return ['method' => 'filterTestInCustomDataSet', 'arguments' => ['filterRules' => $ruleValues, 'join' => AutoFilter\Column::AUTOFILTER_COLUMN_JOIN_AND]];
568 568
     }
569 569
 
570
+    /**
571
+     * @param integer $columnID
572
+     * @param integer $startRow
573
+     * @param string $ruleType
574
+     */
570 575
     private function calculateTopTenValue($columnID, $startRow, $endRow, $ruleType, $ruleValue)
571 576
     {
572 577
         $range = $columnID . $startRow . ':' . $columnID . $endRow;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Chart/Renderer/JpGraph.php 1 patch
Doc Comments   +62 added lines patch added patch discarded remove patch
@@ -60,6 +60,9 @@  discard block
 block discarded – undo
60 60
 
61 61
     private static $plotMark = 0;
62 62
 
63
+    /**
64
+     * @param string $markerID
65
+     */
63 66
     private function formatPointMarker($seriesPlot, $markerID)
64 67
     {
65 68
         $plotMarkKeys = array_keys(self::$markSet);
@@ -87,6 +90,9 @@  discard block
 block discarded – undo
87 90
         return $seriesPlot;
88 91
     }
89 92
 
93
+    /**
94
+     * @param integer $labelCount
95
+     */
90 96
     private function formatDataSetLabels($groupID, $datasetLabels, $labelCount, $rotation = '')
91 97
     {
92 98
         $datasetLabelFormatCode = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotCategoryByIndex(0)->getFormatCode();
@@ -116,6 +122,9 @@  discard block
 block discarded – undo
116 122
         return $datasetLabels;
117 123
     }
118 124
 
125
+    /**
126
+     * @param integer $seriesCount
127
+     */
119 128
     private function percentageSumCalculation($groupID, $seriesCount)
120 129
     {
121 130
         //    Adjust our values to a percentage value across all series in the group
@@ -146,6 +155,9 @@  discard block
 block discarded – undo
146 155
         return $dataValues;
147 156
     }
148 157
 
158
+    /**
159
+     * @param \PhpOffice\PhpSpreadsheet\Chart\Title $captionElement
160
+     */
149 161
     private function getCaption($captionElement)
150 162
     {
151 163
         //    Read any caption
@@ -253,6 +265,9 @@  discard block
 block discarded – undo
253 265
         $this->renderTitle();
254 266
     }
255 267
 
268
+    /**
269
+     * @param integer $groupID
270
+     */
256 271
     private function renderPlotLine($groupID, $filled = false, $combination = false, $dimensions = '2d')
257 272
     {
258 273
         $grouping = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotGrouping();
@@ -316,6 +331,9 @@  discard block
 block discarded – undo
316 331
         $this->graph->Add($groupPlot);
317 332
     }
318 333
 
334
+    /**
335
+     * @param integer $groupID
336
+     */
319 337
     private function renderPlotBar($groupID, $dimensions = '2d')
320 338
     {
321 339
         $rotation = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotDirection();
@@ -400,6 +418,10 @@  discard block
 block discarded – undo
400 418
         $this->graph->Add($groupPlot);
401 419
     }
402 420
 
421
+    /**
422
+     * @param integer $groupID
423
+     * @param boolean $bubble
424
+     */
403 425
     private function renderPlotScatter($groupID, $bubble)
404 426
     {
405 427
         $grouping = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotGrouping();
@@ -445,6 +467,9 @@  discard block
 block discarded – undo
445 467
         }
446 468
     }
447 469
 
470
+    /**
471
+     * @param integer $groupID
472
+     */
448 473
     private function renderPlotRadar($groupID)
449 474
     {
450 475
         $radarStyle = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotStyle();
@@ -483,6 +508,9 @@  discard block
 block discarded – undo
483 508
         }
484 509
     }
485 510
 
511
+    /**
512
+     * @param integer $groupID
513
+     */
486 514
     private function renderPlotContour($groupID)
487 515
     {
488 516
         $contourStyle = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotStyle();
@@ -503,6 +531,9 @@  discard block
 block discarded – undo
503 531
         $this->graph->Add($seriesPlot);
504 532
     }
505 533
 
534
+    /**
535
+     * @param integer $groupID
536
+     */
506 537
     private function renderPlotStock($groupID)
507 538
     {
508 539
         $seriesCount = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotSeriesCount();
@@ -542,6 +573,9 @@  discard block
 block discarded – undo
542 573
         $this->graph->Add($seriesPlot);
543 574
     }
544 575
 
576
+    /**
577
+     * @param integer $groupCount
578
+     */
545 579
     private function renderAreaChart($groupCount, $dimensions = '2d')
546 580
     {
547 581
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_line.php';
@@ -553,6 +587,9 @@  discard block
 block discarded – undo
553 587
         }
554 588
     }
555 589
 
590
+    /**
591
+     * @param integer $groupCount
592
+     */
556 593
     private function renderLineChart($groupCount, $dimensions = '2d')
557 594
     {
558 595
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_line.php';
@@ -564,6 +601,9 @@  discard block
 block discarded – undo
564 601
         }
565 602
     }
566 603
 
604
+    /**
605
+     * @param integer $groupCount
606
+     */
567 607
     private function renderBarChart($groupCount, $dimensions = '2d')
568 608
     {
569 609
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_bar.php';
@@ -575,6 +615,9 @@  discard block
 block discarded – undo
575 615
         }
576 616
     }
577 617
 
618
+    /**
619
+     * @param integer $groupCount
620
+     */
578 621
     private function renderScatterChart($groupCount)
579 622
     {
580 623
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_scatter.php';
@@ -588,6 +631,9 @@  discard block
 block discarded – undo
588 631
         }
589 632
     }
590 633
 
634
+    /**
635
+     * @param integer $groupCount
636
+     */
591 637
     private function renderBubbleChart($groupCount)
592 638
     {
593 639
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_scatter.php';
@@ -599,6 +645,9 @@  discard block
 block discarded – undo
599 645
         }
600 646
     }
601 647
 
648
+    /**
649
+     * @param integer $groupCount
650
+     */
602 651
     private function renderPieChart($groupCount, $dimensions = '2d', $doughnut = false, $multiplePlots = false)
603 652
     {
604 653
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_pie.php';
@@ -675,6 +724,9 @@  discard block
 block discarded – undo
675 724
         }
676 725
     }
677 726
 
727
+    /**
728
+     * @param integer $groupCount
729
+     */
678 730
     private function renderRadarChart($groupCount)
679 731
     {
680 732
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_radar.php';
@@ -686,6 +738,9 @@  discard block
 block discarded – undo
686 738
         }
687 739
     }
688 740
 
741
+    /**
742
+     * @param integer $groupCount
743
+     */
689 744
     private function renderStockChart($groupCount)
690 745
     {
691 746
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_stock.php';
@@ -697,6 +752,10 @@  discard block
 block discarded – undo
697 752
         }
698 753
     }
699 754
 
755
+    /**
756
+     * @param integer $groupCount
757
+     * @param string|null $dimensions
758
+     */
700 759
     private function renderContourChart($groupCount, $dimensions)
701 760
     {
702 761
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_contour.php';
@@ -708,6 +767,9 @@  discard block
 block discarded – undo
708 767
         }
709 768
     }
710 769
 
770
+    /**
771
+     * @param integer $groupCount
772
+     */
711 773
     private function renderCombinationChart($groupCount, $dimensions, $outputDestination)
712 774
     {
713 775
         require_once \PhpOffice\PhpSpreadsheet\Settings::getChartRendererPath() . 'jpgraph_line.php';
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xlsx.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -140,8 +140,8 @@
 block discarded – undo
140 140
         }
141 141
 
142 142
         $hashTablesArray = ['stylesConditionalHashTable', 'fillHashTable', 'fontHashTable',
143
-                                  'bordersHashTable', 'numFmtHashTable', 'drawingHashTable',
144
-                                  'styleHashTable',
143
+                                    'bordersHashTable', 'numFmtHashTable', 'drawingHashTable',
144
+                                    'styleHashTable',
145 145
                                 ];
146 146
 
147 147
         // Set HashTable variables
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Worksheet.php 2 patches
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1147,14 +1147,14 @@
 block discarded – undo
1147 1147
 
1148 1148
         // Pack the main data stream
1149 1149
         $data = pack('vvvv', $row1, $row2, $col1, $col2) .
1150
-                          $unknown1 .
1151
-                          $link_type .
1152
-                          $unknown2 .
1153
-                          $up_count .
1154
-                          $dir_short_len .
1155
-                          $dir_short .
1156
-                          $unknown3 .
1157
-                          $stream_len; /*.
1150
+                            $unknown1 .
1151
+                            $link_type .
1152
+                            $unknown2 .
1153
+                            $up_count .
1154
+                            $dir_short_len .
1155
+                            $dir_short .
1156
+                            $unknown3 .
1157
+                            $stream_len; /*.
1158 1158
                           $dir_long_len .
1159 1159
                           $unknown4     .
1160 1160
                           $dir_long     .
Please login to merge, or discard this patch.
Doc Comments   +9 added lines, -7 removed lines patch added patch discarded remove patch
@@ -223,10 +223,12 @@  discard block
 block discarded – undo
223 223
      * @param int &$str_unique Total number of unique strings
224 224
      * @param array &$str_table String Table
225 225
      * @param array &$colors Colour Table
226
-     * @param mixed $parser The formula parser created for the Workbook
226
+     * @param Parser $parser The formula parser created for the Workbook
227 227
      * @param bool $preCalculateFormulas Flag indicating whether formulas should be calculated or just written
228 228
      * @param string $phpSheet The worksheet to write
229 229
      * @param \PhpOffice\PhpSpreadsheet\Worksheet $phpSheet
230
+     * @param integer $str_total
231
+     * @param integer $str_unique
230 232
      */
231 233
     public function __construct(&$str_total, &$str_unique, &$str_table, &$colors, $parser, $preCalculateFormulas, $phpSheet)
232 234
     {
@@ -624,7 +626,7 @@  discard block
 block discarded – undo
624 626
      * @param int $row Zero indexed row
625 627
      * @param int $col Zero indexed column
626 628
      * @param float $num The number to write
627
-     * @param mixed $xfIndex The optional XF format
629
+     * @param integer $xfIndex The optional XF format
628 630
      *
629 631
      * @return int
630 632
      */
@@ -733,7 +735,7 @@  discard block
 block discarded – undo
733 735
      * @param int $row Zero indexed row
734 736
      * @param int $col Zero indexed column
735 737
      * @param string $str The string to write
736
-     * @param mixed $xfIndex The XF format index for the cell
738
+     * @param integer $xfIndex The XF format index for the cell
737 739
      *
738 740
      * @return int
739 741
      */
@@ -800,7 +802,7 @@  discard block
 block discarded – undo
800 802
      *
801 803
      * @param int $row Zero indexed row
802 804
      * @param int $col Zero indexed column
803
-     * @param mixed $xfIndex The XF format index
805
+     * @param integer $xfIndex The XF format index
804 806
      */
805 807
     public function writeBlank($row, $col, $xfIndex)
806 808
     {
@@ -847,7 +849,7 @@  discard block
 block discarded – undo
847 849
      * @param int $row Zero indexed row
848 850
      * @param int $col Zero indexed column
849 851
      * @param string $formula The formula text string
850
-     * @param mixed $xfIndex The XF format index
852
+     * @param integer $xfIndex The XF format index
851 853
      * @param mixed $calculatedValue Calculated value
852 854
      *
853 855
      * @return int
@@ -2327,8 +2329,8 @@  discard block
 block discarded – undo
2327 2329
      * @param mixed $bitmap The bitmap filename or GD-image resource
2328 2330
      * @param int $x the horizontal position (offset) of the image inside the cell
2329 2331
      * @param int $y the vertical position (offset) of the image inside the cell
2330
-     * @param float $scale_x The horizontal scale
2331
-     * @param float $scale_y The vertical scale
2332
+     * @param integer $scale_x The horizontal scale
2333
+     * @param integer $scale_y The vertical scale
2332 2334
      */
2333 2335
     public function insertBitmap($row, $col, $bitmap, $x = 0, $y = 0, $scale_x = 1, $scale_y = 1)
2334 2336
     {
Please login to merge, or discard this patch.
docs/Examples/Calculations/DateTime/TIME.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 $testDates = [[3, 15],        [13, 15],    [15, 15, 15],    [3, 15, 30],
34 34
                     [15, 15, 15],    [5],        [9, 15, 0],        [9, 15, -1],
35 35
                     [13, -14, -15],    [0, 0, -1],
36
-                  ];
36
+                    ];
37 37
 $testDateCount = count($testDates);
38 38
 
39 39
 $worksheet->fromArray($testDates, null, 'A1', true);
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
     $worksheet->setCellValue('E' . $row, '=D' . $row);
44 44
 }
45 45
 $worksheet->getStyle('E1:E' . $testDateCount)
46
-          ->getNumberFormat()
47
-          ->setFormatCode('hh:mm:ss');
46
+            ->getNumberFormat()
47
+            ->setFormatCode('hh:mm:ss');
48 48
 
49 49
 echo '<hr />';
50 50
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@
 block discarded – undo
30 30
 $worksheet = $spreadsheet->getActiveSheet();
31 31
 
32 32
 // Add some data
33
-$testDates = [[3, 15],        [13, 15],    [15, 15, 15],    [3, 15, 30],
34
-                    [15, 15, 15],    [5],        [9, 15, 0],        [9, 15, -1],
35
-                    [13, -14, -15],    [0, 0, -1],
33
+$testDates = [[3, 15], [13, 15], [15, 15, 15], [3, 15, 30],
34
+                    [15, 15, 15], [5], [9, 15, 0], [9, 15, -1],
35
+                    [13, -14, -15], [0, 0, -1],
36 36
                   ];
37 37
 $testDateCount = count($testDates);
38 38
 
Please login to merge, or discard this patch.
docs/Examples/Calculations/DateTime/DATEVALUE.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
                     '2012-Oct-31',        '5th November',    'January 1st',        'April 2012',
35 35
                     '17-03',            '03-2012',        '29 Feb 2011',        '03-05-07',
36 36
                     '03-MAY-07',        '03-13-07',
37
-                  ];
37
+                    ];
38 38
 $testDateCount = count($testDates);
39 39
 
40 40
 for ($row = 1; $row <= $testDateCount; ++$row) {
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
 }
45 45
 
46 46
 $worksheet->getStyle('C1:C' . $testDateCount)
47
-          ->getNumberFormat()
48
-          ->setFormatCode('yyyy-mmm-dd');
47
+            ->getNumberFormat()
48
+            ->setFormatCode('yyyy-mmm-dd');
49 49
 
50 50
 echo '<hr />';
51 51
 
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -30,10 +30,10 @@
 block discarded – undo
30 30
 $worksheet = $spreadsheet->getActiveSheet();
31 31
 
32 32
 // Add some data
33
-$testDates = ['26 March 2012',    '29 Feb 2012',    'April 1, 2012',    '25/12/2012',
34
-                    '2012-Oct-31',        '5th November',    'January 1st',        'April 2012',
35
-                    '17-03',            '03-2012',        '29 Feb 2011',        '03-05-07',
36
-                    '03-MAY-07',        '03-13-07',
33
+$testDates = ['26 March 2012', '29 Feb 2012', 'April 1, 2012', '25/12/2012',
34
+                    '2012-Oct-31', '5th November', 'January 1st', 'April 2012',
35
+                    '17-03', '03-2012', '29 Feb 2011', '03-05-07',
36
+                    '03-MAY-07', '03-13-07',
37 37
                   ];
38 38
 $testDateCount = count($testDates);
39 39
 
Please login to merge, or discard this patch.
docs/Examples/Calculations/DateTime/TIMEVALUE.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
 // Add some data
33 33
 $testDates = ['3:15',    '13:15',    '15:15:15',    '3:15 AM',    '3:15 PM',    '5PM',    '9:15AM',    '13:15AM',
34
-                  ];
34
+                    ];
35 35
 $testDateCount = count($testDates);
36 36
 
37 37
 for ($row = 1; $row <= $testDateCount; ++$row) {
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
 }
42 42
 
43 43
 $worksheet->getStyle('C1:C' . $testDateCount)
44
-          ->getNumberFormat()
45
-          ->setFormatCode('hh:mm:ss');
44
+            ->getNumberFormat()
45
+            ->setFormatCode('hh:mm:ss');
46 46
 
47 47
 echo '<hr />';
48 48
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 $worksheet = $spreadsheet->getActiveSheet();
31 31
 
32 32
 // Add some data
33
-$testDates = ['3:15',    '13:15',    '15:15:15',    '3:15 AM',    '3:15 PM',    '5PM',    '9:15AM',    '13:15AM',
33
+$testDates = ['3:15', '13:15', '15:15:15', '3:15 AM', '3:15 PM', '5PM', '9:15AM', '13:15AM',
34 34
                   ];
35 35
 $testDateCount = count($testDates);
36 36
 
Please login to merge, or discard this patch.