View GitHub Repository PhpSpreadsheet

Schedule Inspection
Subscribe
Passed
Pull Request — master (#1962)
by Adrien
08:30 queued 18s
created
Status
Category
Toggle Patches
src/PhpSpreadsheet/Worksheet/BaseDrawing.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -137,8 +137,7 @@
 
 block discarded – undo
137 137 
         $this->rotation = 0;
138 138 
         $this->shadow = new Drawing\Shadow();
139 139
140 
-        // Set image index
141 
-        ++self::$imageCounter;
140 
+        // Set image index++self::$imageCounter;
142 141 
         $this->imageIndex = self::$imageCounter;
143 142 
     }
144 143
Please login to merge, or discard this patch.
tests/data/Calculation/Calculation.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -35,13 +35,13 @@
 
 block discarded – undo
35 35 
     $set6 = [0, $dataArray3, '=IF(A1+B1>3,C1,0)', 'E5'];
36 36
37 37 
     $dataArray4 = [
38 
-        ['noflag',    0, 0],
39 
-        [127000,    0, 0],
40 
-        [10000,  0.03, 0],
41 
-        [20000,  0.06, 0],
42 
-        [40000,  0.09, 0],
43 
-        [70000,  0.12, 0],
44 
-        [90000,  0.03, 0],
38 
+        ['noflag', 0, 0],
39 
+        [127000, 0, 0],
40 
+        [10000, 0.03, 0],
41 
+        [20000, 0.06, 0],
42 
+        [40000, 0.09, 0],
43 
+        [70000, 0.12, 0],
44 
+        [90000, 0.03, 0],
45 45 
     ];
46 46 
     $formula2 = '=IF(A1="flag",IF(A2<10, 0) + IF(A3<10000, 0))';
47 47 
     $set7 = [false, $dataArray4, $formula2, 'E5'];
Please login to merge, or discard this patch.
tests/data/Calculation/MathTrig/MMULT.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -17,8 +17,8 @@  discard block
 
 block discarded – undo
17 17 
     ],
18 18 
     [
19 19 
         [
20 
-            [30,  36,  42],
21 
-            [66,  81,  96],
20 
+            [30, 36, 42],
21 
+            [66, 81, 96],
22 22 
             [102, 126, 150],
23 23 
         ],
24 24 
         [
 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62 
     ],
63 63 
     [
64 64 
         [
65 
-            [62.00,  49.46],
65 
+            [62.00, 49.46],
66 66 
             [176.40, 144.50],
67 67 
         ],
68 68 
         [
Please login to merge, or discard this patch.
tests/data/Calculation/LookupRef/LOOKUP.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -1,7 +1,7 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 3 
 return [
4 
-    [ // Office reference example #1
4 
+    [// Office reference example #1
5 5 
         'orange',
6 6 
         4.19,
7 7 
         [
 
@@ -19,7 +19,7 @@  discard block
 
 block discarded – undo
19 19 
             ['blue'],
20 20 
         ],
21 21 
     ],
22 
-    [ // Office reference example #2
22 
+    [// Office reference example #2
23 23 
         'yellow',
24 24 
         5.75,
25 25 
         [
 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37 
             ['blue'],
38 38 
         ],
39 39 
     ],
40 
-    [ // Office reference example #3
40 
+    [// Office reference example #3
41 41 
         'blue',
42 42 
         7.66,
43 43 
         [
 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
             ['blue'],
56 56 
         ],
57 57 
     ],
58 
-    [ // Office reference example #4
58 
+    [// Office reference example #4
59 59 
         '#N/A',
60 60 
         0,
61 61 
         [
 
@@ -73,7 +73,7 @@  discard block
 
 block discarded – undo
73 73 
             ['blue'],
74 74 
         ],
75 75 
     ],
76 
-    [ // Array form test
76 
+    [// Array form test
77 77 
         'orange',
78 78 
         4.2,
79 79 
         [
Please login to merge, or discard this patch.
tests/data/Calculation/LookupRef/MATCH.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -94,7 +94,7 @@
 
 block discarded – undo
94 94 
         [8, 8, 3, 2],
95 95 
         -1,
96 96 
     ],
97 
-    [ // Default matchtype
97 
+    [// Default matchtype
98 98 
         4, // Expected
99 99 
         4, // Input
100 100 
         [2, 0, 0, 3],
Please login to merge, or discard this patch.
tests/data/Calculation/MathTrig/MINVERSE.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch 
@@ -3,9 +3,9 @@  discard block
 
 block discarded – undo
3 3 
 return [
4 4 
     [
5 5 
         [
6 
-            [0.147222222222222,    -0.14444444444444399,   0.063888888888888898],
7 
-            [-0.061111111111111102,  0.022222222222222199,  0.105555555555556],
8 
-            [-0.0194444444444444,    0.18888888888888899,  -0.102777777777778],
6 
+            [0.147222222222222, -0.14444444444444399, 0.063888888888888898],
7 
+            [-0.061111111111111102, 0.022222222222222199, 0.105555555555556],
8 
+            [-0.0194444444444444, 0.18888888888888899, -0.102777777777778],
9 9 
         ],
10 10 
         [
11 11 
             [8, 1, 6],
 
@@ -16,7 +16,7 @@  discard block
 
 block discarded – undo
16 16 
     [
17 17 
         [
18 18 
             [4, -1],
19 
-            [2,  0],
19 
+            [2, 0],
20 20 
         ],
21 21 
         [
22 22 
             [0.0, 0.5],
 
@@ -25,28 +25,28 @@  discard block
 
 block discarded – undo
25 25 
     ],
26 26 
     [
27 27 
         [
28 
-            [1, 2,  1],
28 
+            [1, 2, 1],
29 29 
             [3, 4, -1],
30 
-            [0, 2,  0],
30 
+            [0, 2, 0],
31 31 
         ],
32 32 
         [
33 
-            [0.25,  0.25, -0.75],
34 
-            [0.00,  0.00,  0.50],
33 
+            [0.25, 0.25, -0.75],
34 
+            [0.00, 0.00, 0.50],
35 35 
             [0.75, -0.25, -0.25],
36 36 
         ],
37 37 
     ],
38 38 
     [
39 39 
         [
40 
-            [-0.4545454545455, 1.8181818181818,  0.2727272727273, -0.4545454545455],
40 
+            [-0.4545454545455, 1.8181818181818, 0.2727272727273, -0.4545454545455],
41 41 
             [-0.4545454545455, 1.8181818181818, -0.7272727272727, -0.4545454545455],
42 
-            [0.9090909090909, 1.3636363636364,  0.4545454545455,  0.9090909090909],
43 
-            [2.2727272727273, 0.9090909090909,  5.6363636363636,  3.2727272727273],
42 
+            [0.9090909090909, 1.3636363636364, 0.4545454545455, 0.9090909090909],
43 
+            [2.2727272727273, 0.9090909090909, 5.6363636363636, 3.2727272727273],
44 44 
         ],
45 45 
         [
46 
-            [3.2, -4.8,  2.8, -1.0],
47 
-            [0.2,  0.2,  0.2,  0.0],
48 
-            [1.0, -1.0,  0.0,  0.0],
49 
-            [-4.0,  5.0, -2.0,  1.0],
46 
+            [3.2, -4.8, 2.8, -1.0],
47 
+            [0.2, 0.2, 0.2, 0.0],
48 
+            [1.0, -1.0, 0.0, 0.0],
49 
+            [-4.0, 5.0, -2.0, 1.0],
50 50 
         ],
51 51 
     ],
52 52 
     [
 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
             [3, 4],
56 56 
         ],
57 57 
         [
58 
-            [-2.0,  1.0],
58 
+            [-2.0, 1.0],
59 59 
             [1.5, -0.5],
60 60 
         ],
61 61 
     ],
 
@@ -67,8 +67,8 @@  discard block
 
 block discarded – undo
67 67 
         ],
68 68 
         [
69 69 
             [-2, 1, 0],
70 
-            [1.3333333333333299,  -0.33333333333332998, -0.33333333333332998],
71 
-            [0.33333333333332998, -0.33333333333332998,  0.66666666666666996],
70 
+            [1.3333333333333299, -0.33333333333332998, -0.33333333333332998],
71 
+            [0.33333333333332998, -0.33333333333332998, 0.66666666666666996],
72 72 
         ],
73 73 
     ],
74 74 
     [
 
@@ -77,7 +77,7 @@  discard block
 
 block discarded – undo
77 77 
             [4, 5],
78 78 
         ],
79 79 
         [
80 
-            [-2.5,  1.5],
80 
+            [-2.5, 1.5],
81 81 
             [2.0, -1.0],
82 82 
         ],
83 83 
     ],
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
             [7, 9],
88 88 
         ],
89 89 
         [
90 
-            [-0.81818181818181801,  0.72727272727272696],
90 
+            [-0.81818181818181801, 0.72727272727272696],
91 91 
             [0.63636363636363602, -0.45454545454545497],
92 92 
         ],
93 93 
     ],
 
@@ -98,7 +98,7 @@  discard block
 
 block discarded – undo
98 98 
         ],
99 99 
         [
100 100 
             [0.054112554112554001, -0.084415584415584],
101 
-            [-0.018398268398268001,  0.048701298701299002],
101 
+            [-0.018398268398268001, 0.048701298701299002],
102 102 
         ],
103 103 
     ],
104 104 
     [
 
@@ -107,14 +107,14 @@  discard block
 
 block discarded – undo
107 107 
             [2, 1],
108 108 
         ],
109 109 
         [
110 
-            [-0.5,  1.0],
110 
+            [-0.5, 1.0],
111 111 
             [1.0, -1.0],
112 112 
         ],
113 113 
     ],
114 114 
     [
115 115 
         '#VALUE!', // Not Square
116 116 
         [
117 
-            [-0.5,  1.0, 1.5],
117 
+            [-0.5, 1.0, 1.5],
118 118 
             [1.0, -1.0, 2.0],
119 119 
         ],
120 120 
     ],
Please login to merge, or discard this patch.
tests/data/Calculation/MathTrig/MDETERM.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch 
@@ -51,7 +51,7 @@  discard block
 
 block discarded – undo
51 51 
     [
52 52 
         1.81,
53 53 
         [
54 
-            [0.20,  1.0],
54 
+            [0.20, 1.0],
55 55 
             [0.35, 10.8],
56 56 
         ],
57 57 
     ],
 
@@ -73,17 +73,17 @@  discard block
 
 block discarded – undo
73 73 
     [
74 74 
         88,
75 75 
         [
76 
-            [1, 3,  8, 5],
77 
-            [1, 3,  6, 1],
78 
-            [1, 1,  1, 0],
76 
+            [1, 3, 8, 5],
77 
+            [1, 3, 6, 1],
78 
+            [1, 1, 1, 0],
79 79 
             [7, 3, 10, 2],
80 80 
         ],
81 81 
     ],
82 82 
     [
83 83 
         1,
84 84 
         [
85 
-            [3,  6, 1],
86 
-            [1,  1, 0],
85 
+            [3, 6, 1],
86 
+            [1, 1, 0],
87 87 
             [3, 10, 2],
88 88 
         ],
89 89 
     ],
 
@@ -104,25 +104,25 @@  discard block
 
 block discarded – undo
104 104 
     [
105 105 
         '#VALUE!', // null in array
106 106 
         [
107 
-            [0.20,  1.00, -0.90],
108 
-            [0.35, 10.80,  4.00],
109 
-            [-3.15,  5.00,  null],
107 
+            [0.20, 1.00, -0.90],
108 
+            [0.35, 10.80, 4.00],
109 
+            [-3.15, 5.00, null],
110 110 
         ],
111 111 
     ],
112 112 
     [
113 113 
         '#VALUE!', // string in array
114 114 
         [
115 
-            [0.20,  1.00, -0.90],
116 
-            [0.35, 10.80,  '="4.00"'],
117 
-            [-3.15,  5.00, 6.00],
115 
+            [0.20, 1.00, -0.90],
116 
+            [0.35, 10.80, '="4.00"'],
117 
+            [-3.15, 5.00, 6.00],
118 118 
         ],
119 119 
     ],
120 120 
     [
121 121 
         '#VALUE!', // string in array
122 122 
         [
123 
-            [0.20,  1.00, -0.90],
124 
-            [0.35, 10.80,  'Y'],
125 
-            [-3.15,  5.00, 6.00],
123 
+            [0.20, 1.00, -0.90],
124 
+            [0.35, 10.80, 'Y'],
125 
+            [-3.15, 5.00, 6.00],
126 126 
         ],
127 127 
     ],
128 128 
     [
Please login to merge, or discard this patch.
PhpSpreadsheetTests/Calculation/Functions/MathTrig/MovedFunctionsTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -43,11 +43,11 @@
 
 block discarded – undo
43 43 
         self::assertEquals(1, MathTrig::MDETERM([1]));
44 44 
         self::assertEquals(
45 45 
             [[2, 2], [2, 1]],
46 
-            MathTrig::MINVERSE([[-0.5,  1.0], [1.0, -1.0]])
46 
+            MathTrig::MINVERSE([[-0.5, 1.0], [1.0, -1.0]])
47 47 
         );
48 48 
         self::assertEquals(
49 49 
             [[23], [53]],
50 
-            MathTrig::MMULT([[1,  2], [3, 4]], [[7], [8]])
50 
+            MathTrig::MMULT([[1, 2], [3, 4]], [[7], [8]])
51 51 
         );
52 52 
         self::assertEquals(6, MathTrig::MROUND(7.3, 3));
53 53 
         self::assertEquals(1, MathTrig::MULTINOMIAL(1));
Please login to merge, or discard this patch.