Completed
Pull Request — develop (#533)
by
unknown
78:57 queued 15:44
created
src/PhpSpreadsheet/Reader/Xlsx.php 3 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1243,15 +1243,15 @@
 block discarded – undo
1243 1243
                                 if (isset ($xmlSheet->extLst, $xmlSheet->extLst->ext, $xmlSheet->extLst->ext['uri'])
1244 1244
                                 && $xmlSheet->extLst->ext['uri'] == "{CCE6A557-97BC-4b89-ADB6-D9C93CAAB3DF}" )
1245 1245
                                 {
1246
-                                  // retreive MS extension data to create a node that matches expectations.
1247
-                                  foreach ($xmlSheet->extLst->ext->children('x14', TRUE)->dataValidations->dataValidation as $item)
1248
-                                  {
1246
+                                    // retreive MS extension data to create a node that matches expectations.
1247
+                                    foreach ($xmlSheet->extLst->ext->children('x14', TRUE)->dataValidations->dataValidation as $item)
1248
+                                    {
1249 1249
                                     $node = $xmlSheet->dataValidations->addChild('dataValidation');
1250 1250
                                     foreach ($item->attributes() as $attr)
1251
-                                      $node->addAttribute($attr->getName(), $attr);
1251
+                                        $node->addAttribute($attr->getName(), $attr);
1252 1252
                                     $node->addAttribute('sqref', $item->children('xm',TRUE)->sqref);
1253 1253
                                     $node->addChild('formula1', $item->formula1->children('xm',TRUE)->f);
1254
-                                  }
1254
+                                    }
1255 1255
                                 }
1256 1256
 
1257 1257
                                 foreach ($xmlSheet->dataValidations->dataValidation as $dataValidation) {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1241,7 +1241,7 @@  discard block
 block discarded – undo
1241 1241
                             if ($xmlSheet && $xmlSheet->dataValidations && !$this->readDataOnly) {
1242 1242
                                 // handle Microsoft extension if present
1243 1243
                                 if (isset ($xmlSheet->extLst, $xmlSheet->extLst->ext, $xmlSheet->extLst->ext['uri'])
1244
-                                && $xmlSheet->extLst->ext['uri'] == "{CCE6A557-97BC-4b89-ADB6-D9C93CAAB3DF}" )
1244
+                                && $xmlSheet->extLst->ext['uri'] == "{CCE6A557-97BC-4b89-ADB6-D9C93CAAB3DF}")
1245 1245
                                 {
1246 1246
                                   // retreive MS extension data to create a node that matches expectations.
1247 1247
                                   foreach ($xmlSheet->extLst->ext->children('x14', TRUE)->dataValidations->dataValidation as $item)
@@ -1249,8 +1249,8 @@  discard block
 block discarded – undo
1249 1249
                                     $node = $xmlSheet->dataValidations->addChild('dataValidation');
1250 1250
                                     foreach ($item->attributes() as $attr)
1251 1251
                                       $node->addAttribute($attr->getName(), $attr);
1252
-                                    $node->addAttribute('sqref', $item->children('xm',TRUE)->sqref);
1253
-                                    $node->addChild('formula1', $item->formula1->children('xm',TRUE)->f);
1252
+                                    $node->addAttribute('sqref', $item->children('xm', TRUE)->sqref);
1253
+                                    $node->addChild('formula1', $item->formula1->children('xm', TRUE)->f);
1254 1254
                                   }
1255 1255
                                 }
1256 1256
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1247,8 +1247,9 @@
 block discarded – undo
1247 1247
                                   foreach ($xmlSheet->extLst->ext->children('x14', TRUE)->dataValidations->dataValidation as $item)
1248 1248
                                   {
1249 1249
                                     $node = $xmlSheet->dataValidations->addChild('dataValidation');
1250
-                                    foreach ($item->attributes() as $attr)
1251
-                                      $node->addAttribute($attr->getName(), $attr);
1250
+                                    foreach ($item->attributes() as $attr) {
1251
+                                                                          $node->addAttribute($attr->getName(), $attr);
1252
+                                    }
1252 1253
                                     $node->addAttribute('sqref', $item->children('xm',TRUE)->sqref);
1253 1254
                                     $node->addChild('formula1', $item->formula1->children('xm',TRUE)->f);
1254 1255
                                   }
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/Calculation.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3804,8 +3804,9 @@
 block discarded – undo
3804 3804
                     $pCell->attach($pCellParent);
3805 3805
                     $this->debugLog->writeDebugLog('Evaluation Result for named range ', $namedRange, ' is ', $this->showTypeDetails($cellValue));
3806 3806
                     $stack->push('Named Range', $cellValue, $namedRange);
3807
-                    if ($cellValue === Functions::REF())
3808
-                        $this->formulaErrorDetails[] = $stack->last();
3807
+                    if ($cellValue === Functions::REF()) {
3808
+                                            $this->formulaErrorDetails[] = $stack->last();
3809
+                    }
3809 3810
                 } else {
3810 3811
                     return $this->raiseFormulaError("undefined variable '$token'");
3811 3812
                 }
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/Worksheet.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -553,11 +553,11 @@
 block discarded – undo
553 553
         $this->drawingCollection = new \ArrayObject();
554 554
     }
555 555
 
556
-     /**
557
-     * Get collection of charts.
558
-     *
559
-     * @return Chart[]
560
-     */
556
+        /**
557
+         * Get collection of charts.
558
+         *
559
+         * @return Chart[]
560
+         */
561 561
     public function getChartCollection()
562 562
     {
563 563
         return $this->chartCollection;
Please login to merge, or discard this patch.