Completed
Pull Request — master (#15)
by Kevin
01:46
created
src/AbstractClient.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
         $clientOptions = ['timeout', 'proxy'];
72 72
 
73 73
         // Only allow turning off ssl verification is it's for a proxy
74
-        if (! empty($options['proxy'])) {
74
+        if (!empty($options['proxy'])) {
75 75
             $clientOptions[] = 'verify';
76 76
         }
77 77
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
      * Return the list of options that can be passed to the HttpClient
64 64
      *
65 65
      * @param  array $options
66
-     * @return array
66
+     * @return string[]
67 67
      */
68 68
     protected function getAllowedClientOptions(array $options)
69 69
     {
Please login to merge, or discard this patch.
src/Console/ApiListCommand.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     protected function askApiKey(InputInterface $input, OutputInterface $output)
82 82
     {
83 83
         $question = (new Question('Enter API key: '))
84
-            ->setValidator(function ($answer) {
84
+            ->setValidator(function($answer) {
85 85
                 if (is_null($answer)) {
86 86
                     throw new \InvalidArgumentException("API key can't be null.");
87 87
                 }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     protected function askSecretKey(InputInterface $input, OutputInterface $output)
104 104
     {
105 105
         $question = (new Question('Enter secret key: '))
106
-            ->setValidator(function ($answer) {
106
+            ->setValidator(function($answer) {
107 107
                 if (is_null($answer)) {
108 108
                     throw new \InvalidArgumentException("Secret key can't be null.");
109 109
                 }
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
             $listFile .= "    '$name' => array(\n";
145 145
             $listFile .= "        'description' => '$description',\n";
146
-            $listFile .= "        'isasync'     => " . ($isAsync ? "true" : "false") . ",\n";
146
+            $listFile .= "        'isasync'     => ".($isAsync ? "true" : "false").",\n";
147 147
             $listFile .= "        'params'      => array(\n";
148 148
 
149 149
             foreach ($api['params'] as $param) {
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                 $listFile .= "            '$paramName' => array(\n";
156 156
                 $listFile .= "                'description' => '$paramDescription',\n";
157 157
                 $listFile .= "                'type'        => '$paramType',\n";
158
-                $listFile .= "                'required'    => " . ($paramRequired ? "true" : "false") . ",\n";
158
+                $listFile .= "                'required'    => ".($paramRequired ? "true" : "false").",\n";
159 159
                 $listFile .= "            ),\n";
160 160
             }
161 161
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 
168 168
         $listFile .= ");\n";
169 169
 
170
-        file_put_contents(__DIR__ . '/../../cache/api_list.php', $listFile);
170
+        file_put_contents(__DIR__.'/../../cache/api_list.php', $listFile);
171 171
 
172 172
         $progress->finish();
173 173
     }
Please login to merge, or discard this patch.
src/Console/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
      */
35 35
     public function getHelp()
36 36
     {
37
-        return self::$logo . parent::getHelp();
37
+        return self::$logo.parent::getHelp();
38 38
     }
39 39
 
40 40
     /**
Please login to merge, or discard this patch.
src/Util/UrlHelpersTrait.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php namespace PCextreme\Cloudstack\Util;
2 2
 
3 3
 use InvalidArgumentException;
4
-use PCextreme\Cloudstack\Exception\ClientException;
5 4
 
6 5
 trait UrlHelpersTrait
7 6
 {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         $method  = $this->getCommandMethod($command);
36 36
         $query   = $this->enableSso()->getCommandQuery($params);
37 37
 
38
-        return $this->urlClient . '?loginUrl=' . urlencode($query);
38
+        return $this->urlClient.'?loginUrl='.urlencode($query);
39 39
     }
40 40
 
41 41
     /**
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         ];
87 87
 
88 88
         $base = $this->urlConsole;
89
-        $query  = $this->getCommandQuery($params);
89
+        $query = $this->getCommandQuery($params);
90 90
 
91 91
         return $this->appendQuery($base, $query);
92 92
     }
Please login to merge, or discard this patch.
src/Client.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
         if (!empty($missing)) {
137 137
             throw new InvalidArgumentException(
138
-                'Required options not defined: ' . implode(', ', array_keys($missing))
138
+                'Required options not defined: '.implode(', ', array_keys($missing))
139 139
             );
140 140
         }
141 141
     }
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 
276 276
         // To prevent the signature from being escaped we simply append
277 277
         // the signature to the previously build query.
278
-        return $query . '&signature=' . $signature;
278
+        return $query.'&signature='.$signature;
279 279
     }
280 280
 
281 281
     /**
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
     public function getApiList()
291 291
     {
292 292
         if (is_null($this->apiList)) {
293
-            $path = __DIR__ . '/../cache/api_list.php';
293
+            $path = __DIR__.'/../cache/api_list.php';
294 294
 
295 295
             if (!file_exists($path)) {
296 296
                 throw new RuntimeException(
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
         $query = trim($query, '?&');
328 328
 
329 329
         if ($query) {
330
-            return $url . '?' . $query;
330
+            return $url.'?'.$query;
331 331
         }
332 332
 
333 333
         return $url;
@@ -343,14 +343,14 @@  discard block
 block discarded – undo
343 343
     {
344 344
         // We need to modify the nested array keys to get them accepted by Cloudstack.
345 345
         // For example 'details[0][key]' should resolve to 'details[0].key'.
346
-        array_walk($params, function (&$value, $key) {
346
+        array_walk($params, function(&$value, $key) {
347 347
             if (is_array($value)) {
348 348
                 $parsedParams = [];
349 349
 
350 350
                 foreach ($value as $index => $entry) {
351 351
                     $parsedParams[] = [
352
-                        $key . '[' . $index . ']' . '.key' => $entry['key'],
353
-                        $key . '[' . $index . ']' . '.value' => $entry['value'],
352
+                        $key.'['.$index.']'.'.key' => $entry['key'],
353
+                        $key.'['.$index.']'.'.value' => $entry['value'],
354 354
                     ];
355 355
                 }
356 356
 
@@ -362,8 +362,8 @@  discard block
 block discarded – undo
362 362
         // to encode the values, but we can't encode the keys. This would otherwise
363 363
         // compromise the signature. Therefore we can't use http_build_query().
364 364
         $queryParams = $this->flattenParams($params);
365
-        array_walk($queryParams, function (&$value, $key) {
366
-            $value = $key . '=' . rawurlencode($value);
365
+        array_walk($queryParams, function(&$value, $key) {
366
+            $value = $key.'='.rawurlencode($value);
367 367
         });
368 368
 
369 369
         return implode('&', $queryParams);
Please login to merge, or discard this patch.