Completed
Push — master ( adc836...85a2ca )
by Kevin
03:35
created
src/AbstractClient.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
      * Return the list of options that can be passed to the HttpClient
65 65
      *
66 66
      * @param  array  $options
67
-     * @return array
67
+     * @return string[]
68 68
      */
69 69
     protected function getAllowedClientOptions(array $options)
70 70
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
         $clientOptions = ['timeout', 'proxy'];
72 72
 
73 73
         // Only allow turning off ssl verification is it's for a proxy
74
-        if (! empty($options['proxy'])) {
74
+        if (!empty($options['proxy'])) {
75 75
             $clientOptions[] = 'verify';
76 76
         }
77 77
 
Please login to merge, or discard this patch.
src/Console/ApiListCommand.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     protected function askApiKey(InputInterface $input, OutputInterface $output)
82 82
     {
83 83
         $question = (new Question('Enter API key: '))
84
-            ->setValidator(function ($answer) {
84
+            ->setValidator(function($answer) {
85 85
                 if (is_null($answer)) {
86 86
                     throw new \InvalidArgumentException("API key can't be null.");
87 87
                 }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     protected function askSecretKey(InputInterface $input, OutputInterface $output)
104 104
     {
105 105
         $question = (new Question('Enter secret key: '))
106
-            ->setValidator(function ($answer) {
106
+            ->setValidator(function($answer) {
107 107
                 if (is_null($answer)) {
108 108
                     throw new \InvalidArgumentException("Secret key can't be null.");
109 109
                 }
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
             $listFile .= "    '$name' => array(\n";
145 145
             $listFile .= "        'description' => '$description',\n";
146
-            $listFile .= "        'isasync'     => " . ($isAsync ? "true" : "false") . ",\n";
146
+            $listFile .= "        'isasync'     => ".($isAsync ? "true" : "false").",\n";
147 147
             $listFile .= "        'params'      => array(\n";
148 148
 
149 149
             foreach ($api['params'] as $param) {
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                 $listFile .= "            '$paramName' => array(\n";
156 156
                 $listFile .= "                'description' => '$paramDescription',\n";
157 157
                 $listFile .= "                'type'        => '$paramType',\n";
158
-                $listFile .= "                'required'    => " . ($paramRequired ? "true" : "false") . ",\n";
158
+                $listFile .= "                'required'    => ".($paramRequired ? "true" : "false").",\n";
159 159
                 $listFile .= "            ),\n";
160 160
             }
161 161
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 
168 168
         $listFile .= ");\n";
169 169
 
170
-        file_put_contents(__DIR__ . '/../../cache/api_list.php', $listFile);
170
+        file_put_contents(__DIR__.'/../../cache/api_list.php', $listFile);
171 171
 
172 172
         $progress->finish();
173 173
     }
Please login to merge, or discard this patch.
src/Console/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
      */
35 35
     public function getHelp()
36 36
     {
37
-        return self::$logo . parent::getHelp();
37
+        return self::$logo.parent::getHelp();
38 38
     }
39 39
 
40 40
     /**
Please login to merge, or discard this patch.
src/Util/UrlHelpersTrait.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php namespace PCextreme\Cloudstack\Util;
2 2
 
3 3
 use InvalidArgumentException;
4
-use PCextreme\Cloudstack\Exception\ClientException;
5 4
 
6 5
 trait UrlHelpersTrait
7 6
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
         ];
53 53
 
54 54
         $base = $this->urlConsole;
55
-        $query  = $this->getCommandQuery($params);
55
+        $query = $this->getCommandQuery($params);
56 56
 
57 57
         return $this->appendQuery($base, $query);
58 58
     }
Please login to merge, or discard this patch.
src/Client.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
     {
134 134
         $missing = array_diff_key(array_flip($this->getRequiredOptions()), $options);
135 135
 
136
-        if (! empty($missing)) {
136
+        if (!empty($missing)) {
137 137
             throw new InvalidArgumentException(
138
-                'Required options not defined: ' . implode(', ', array_keys($missing))
138
+                'Required options not defined: '.implode(', ', array_keys($missing))
139 139
             );
140 140
         }
141 141
     }
@@ -163,14 +163,14 @@  discard block
 block discarded – undo
163 163
     {
164 164
         $apiList = $this->getApiList();
165 165
 
166
-        if (! array_key_exists($command, $apiList)) {
166
+        if (!array_key_exists($command, $apiList)) {
167 167
             throw new RuntimeException(
168 168
                 "Call to unsupported API command [{$command}], this call is not present in the API list."
169 169
             );
170 170
         }
171 171
 
172 172
         foreach ($apiList[$command]['params'] as $key => $value) {
173
-            if (! array_key_exists($key, $options) && (bool) $value['required']) {
173
+            if (!array_key_exists($key, $options) && (bool) $value['required']) {
174 174
                 throw new InvalidArgumentException(
175 175
                     "Missing argument [{$key}] for command [{$command}] must be of type [{$value['type']}]."
176 176
                 );
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
 
268 268
         // To prevent the signature from being escaped we simply append
269 269
         // the signature to the previously build query.
270
-        return $query . '&signature=' . $signature;
270
+        return $query.'&signature='.$signature;
271 271
     }
272 272
 
273 273
     /**
@@ -282,9 +282,9 @@  discard block
 block discarded – undo
282 282
     public function getApiList()
283 283
     {
284 284
         if (is_null($this->apiList)) {
285
-            $path = __DIR__ . '/../cache/api_list.php';
285
+            $path = __DIR__.'/../cache/api_list.php';
286 286
 
287
-            if (! file_exists($path)) {
287
+            if (!file_exists($path)) {
288 288
                 throw new RuntimeException(
289 289
                     "Cloudstack Client API list not found. This file needs to be generated before using the client."
290 290
                 );
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
         $query = trim($query, '?&');
320 320
 
321 321
         if ($query) {
322
-            return $url . '?' . $query;
322
+            return $url.'?'.$query;
323 323
         }
324 324
 
325 325
         return $url;
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     {
336 336
         // We need to modify the nested array keys to get them accepted by Cloudstack.
337 337
         // For example 'details[0][key]' should resolve to 'details[0].key'.
338
-        array_walk($params, function (&$value, $key) {
338
+        array_walk($params, function(&$value, $key) {
339 339
             if (is_array($value)) {
340 340
                 $parsedParams = [];
341 341
 
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
         $result = [];
367 367
 
368 368
         foreach ($params as $key => $value) {
369
-            if (! is_array($value)) {
369
+            if (!is_array($value)) {
370 370
                 $result[$key] = $value;
371 371
             } else {
372 372
                 $result = array_merge($result, static::flattenParams($value));
Please login to merge, or discard this patch.