PBXg33k / php-music-info

src/MusicInfo.php

Doc Comments +2 added lines, -2 removed lines

@@ -173,7 +173,7 @@ 
 
     /**
      * @param $key
-     * @return IMusicService|null
+     * @return BaseService|null
      */
     public function getService($key)
     {
@@ -215,7 +215,7 @@ 
     }
 
     /**
-     * @return IMusicService
+     * @return BaseService|null
      */
     public function getPreferredService()
     {

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Pbxg33k\MusicInfo\Model\IMusicService;
 use Pbxg33k\MusicInfo\Service\BaseService;
 use Pbxg33k\Traits\PropertyTrait;
-use Symfony\Component\Config\FileLocator;
 
 class MusicInfo
 {

Spacing +19 added lines, -19 removed lines

@@ -48,9 +48,9 @@ 
             new Client($config['defaults']['guzzle'])
         );
 
-        if(isset($config['services'])) {
-            foreach($config['services'] as $service) {
-                if(!isset($config['init_services'])) {
+        if (isset($config['services'])) {
+            foreach ($config['services'] as $service) {
+                if (!isset($config['init_services'])) {
                     $config['init_services'] = null;
                 }
                 $this->loadService($service, $config['init_services']);
@@ -93,19 +93,19 @@ 
      */
     public function loadService($service, $init = false)
     {
-        $fqcn = implode('\\',['Pbxg33k', 'MusicInfo', 'Service', $service, 'Service']);
-        if(class_exists($fqcn)) {
+        $fqcn = implode('\\', ['Pbxg33k', 'MusicInfo', 'Service', $service, 'Service']);
+        if (class_exists($fqcn)) {
             /** @var IMusicService $client */
             $client = new $fqcn();
             $client->setConfig($this->mergeConfig($service));
             $client->setClient($this->getClient());
-            if($init == true) {
+            if ($init == true) {
                 $client->init();
             }
             $this->addService($client, $service);
             return $service;
         } else {
-            throw new \Exception('Service class does not exist: '.$service.' ('.$fqcn.')');
+            throw new \Exception('Service class does not exist: ' . $service . ' (' . $fqcn . ')');
         }
     }
 
@@ -118,7 +118,7 @@ 
     public function mergeConfig($service)
     {
         $service = strtolower($service);
-        if(isset($this->config['service_configuration'][$service])) {
+        if (isset($this->config['service_configuration'][$service])) {
             $config = array_merge(
                 $this->config['defaults'],
                 $this->config['service_configuration'][$service]
@@ -139,7 +139,7 @@ 
      */
     public function loadServices($initialize = false)
     {
-        foreach($this->supportedServices as $service) {
+        foreach ($this->supportedServices as $service) {
             $this->loadService($service, $initialize);
         }
 
@@ -172,7 +172,7 @@ 
     public function getService($key)
     {
         $key = strtolower($key);
-        if(isset($this->services[$key])) {
+        if (isset($this->services[$key])) {
             return $this->initializeService($this->services[$key]);
         } else {
             return null;
@@ -187,7 +187,7 @@ 
      */
     public function initializeService(BaseService $service)
     {
-        if(!$service->isInitialized()) {
+        if (!$service->isInitialized()) {
             $service->init();
         }
         
@@ -201,7 +201,7 @@ 
      */
     public function removeService($key)
     {
-        if(isset($this->services[$key])) {
+        if (isset($this->services[$key])) {
             unset($this->services[$key]);
         }
 
@@ -229,26 +229,26 @@ 
     public function doSearch($argument, $type, $servicesArg = null)
     {
         $services = [];
-        if(null === $servicesArg) {
+        if (null === $servicesArg) {
             $services = $this->getServices();
-        } elseif(is_array($servicesArg)) {
-            foreach($servicesArg as $service) {
-                if(is_string($service) && $loadedService = $this->getService($service)) {
+        } elseif (is_array($servicesArg)) {
+            foreach ($servicesArg as $service) {
+                if (is_string($service) && $loadedService = $this->getService($service)) {
                     $services[$service] = $loadedService;
                 } else {
                     throw new \Exception(sprintf('Service (%s) cannot be found', $service));
                 }
             }
-        } elseif(is_string($servicesArg) && $loadedService = $this->getService($servicesArg)) {
+        } elseif (is_string($servicesArg) && $loadedService = $this->getService($servicesArg)) {
             $services[$servicesArg] = $loadedService;
         }
 
         $results = [];
 
-        foreach($services as $serviceKey => $service) {
+        foreach ($services as $serviceKey => $service) {
             $methodName = $this->getMethodName($type);
 
-            if(!method_exists($service, $methodName)) {
+            if (!method_exists($service, $methodName)) {
                 throw new \Exception(sprintf('Method (%s) not found in %s', $methodName, get_class($service)));
             }
 

src/DependencyInjection/MusicInfoExtension.php

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 namespace Pbxg33k\MusicInfo\DependencyInjection;
 
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
-use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\Config\FileLocator;
 
 class MusicInfoExtension extends Extension
 {

src/Service/Spotify/Endpoint/Artist.php

Spacing +2 added lines, -2 removed lines

@@ -127,8 +127,8 @@
     public function transformCollection($raw)
     {
         $collection = new ArrayCollection();
-        if(is_object($raw) && isset($raw->artists)) {
-            foreach($raw->artists->items as $artist) {
+        if (is_object($raw) && isset($raw->artists)) {
+            foreach ($raw->artists->items as $artist) {
                 $collection->add($this->transformSingle($artist));
             }
 

src/Service/VocaDB/Endpoint/Artist.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     public function transformCollection($raw)
     {
         $collection = new ArrayCollection();
-        foreach($raw->collection as $artist)
+        foreach ($raw->collection as $artist)
         {
             $collection->add($this->transformSingle($artist));
         }

Braces +1 added lines, -2 removed lines

@@ -77,8 +77,7 @@
     public function transformCollection($raw)
     {
         $collection = new ArrayCollection();
-        foreach($raw->collection as $artist)
-        {
+        foreach($raw->collection as $artist) {
             $collection->add($this->transformSingle($artist));
         }