PAYONE-GmbH / magento-2

Helper/Toolkit.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
      *
      * @param  string   $sText
      * @param  string   $aSubstitutionArray
-     * @param  int|bool $iMaxLength
+     * @param  integer $iMaxLength
      * @return string
      */
     public function handleSubstituteReplacement($sText, $aSubstitutionArray, $iMaxLength = false)

Test/Unit/Controller/Adminhtml/Config/Export/IndexTest.php

Unused Use Statements -3 removed lines

@@ -29,10 +29,7 @@
 use Payone\Core\Controller\Adminhtml\Config\Export\Index as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Backend\App\Action\Context;
-use Magento\Framework\View\Result\PageFactory;
-use Magento\Framework\View\Result\Page;
 use Magento\Framework\View\Page\Config;
-use Magento\Framework\View\Page\Title;
 use Magento\Framework\AuthorizationInterface;
 use Payone\Core\Model\Config\Export;
 use Magento\Framework\Controller\Result\RawFactory;

Test/Unit/Controller/Onepage/DebitTest.php

Unused Use Statements -2 removed lines

@@ -29,10 +29,8 @@
 use Magento\Quote\Model\Quote;
 use Payone\Core\Controller\Onepage\Debit as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Checkout\Model\Session;
 use Magento\Framework\App\Action\Context;
-use Magento\Customer\Model\Session as CustomerSession;
 use Payone\Core\Model\Api\Request\Managemandate;
 use Magento\Framework\View\Result\PageFactory;
 use Magento\Checkout\Model\Type\Onepage;

Test/Unit/Controller/Onepage/RedirectTest.php

Unused Use Statements -2 removed lines

@@ -28,10 +28,8 @@
 
 use Payone\Core\Controller\Onepage\Redirect as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Checkout\Model\Session;
 use Magento\Framework\App\Action\Context;
-use Magento\Customer\Model\Session as CustomerSession;
 use Magento\Store\App\Response\Redirect as RedirectResponse;
 use Magento\Framework\App\Console\Response;
 use Magento\Framework\UrlInterface;

Test/Unit/Controller/Onepage/ReturnedTest.php

Unused Use Statements -2 removed lines

@@ -28,10 +28,8 @@
 
 use Payone\Core\Controller\Onepage\Returned as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Checkout\Model\Session;
 use Magento\Framework\App\Action\Context;
-use Magento\Customer\Model\Session as CustomerSession;
 use Magento\Store\App\Response\Redirect as RedirectResponse;
 use Magento\Framework\App\Console\Response;
 use Magento\Framework\App\ResponseInterface;

Test/Unit/Controller/Paypal/ExpressTest.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 
 use Payone\Core\Controller\Paypal\Express as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Framework\Controller\Result\Redirect;
 use Magento\Checkout\Model\Session;
 use Magento\Framework\Controller\ResultFactory;

Test/Unit/Controller/Paypal/ReturnedTest.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 
 use Payone\Core\Controller\Paypal\Returned as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Framework\Controller\Result\Redirect;
 use Magento\Checkout\Model\Session;
 use Payone\Core\Model\Paypal\ReturnHandler;

Test/Unit/Observer/CheckoutSubmitBeforeTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -237,7 +237,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject
+     * @return Observer
      */
     private function getExecuteObserver()
     {

Unused Use Statements -1 removed lines

@@ -38,7 +38,6 @@
 use Magento\Payment\Model\InfoInterface;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Event\Observer;
-use Magento\Store\Model\ScopeInterface;
 use Payone\Core\Test\Unit\BaseTestCase;
 use Payone\Core\Model\Test\PayoneObjectManager;
 

Controller/Adminhtml/Config/Export/Index.php

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
                 $sXml = $this->configExport->generateConfigExportXml();
                 if ($sXml !== false) {
                     $oResultRaw->setHeader("Content-Type", "text/xml; charset=\"utf8\"", true);
-                    $oResultRaw->setHeader("Content-Disposition", "attachment; filename=\"payone_config_export" . date('Y-m-d H-i-s') . "_" . md5($sXml) . ".xml\"", true);
+                    $oResultRaw->setHeader("Content-Disposition", "attachment; filename=\"payone_config_export".date('Y-m-d H-i-s')."_".md5($sXml).".xml\"", true);
                     $oResultRaw->setContents($sXml);
                 }
             } catch (\Exception $e) {