@@ -228,6 +228,9 @@  | 
                                                    ||
| 228 | 228 | return $str;  | 
                                                        
| 229 | 229 | }  | 
                                                        
| 230 | 230 | |
| 231 | +/**  | 
                                                        |
| 232 | + * @param string $str  | 
                                                        |
| 233 | + */  | 
                                                        |
| 231 | 234 | function lf2crlf($str)  | 
                                                        
| 232 | 235 |  { | 
                                                        
| 233 | 236 |      return mb_ereg_replace("\r\r\n", "\r\n", mb_ereg_replace("\n", "\r\n", $str)); | 
                                                        
@@ -28,6 +28,9 @@ discard block  | 
                                                    ||
| 28 | 28 | $this->translator = $this->initTranslator($translator);  | 
                                                        
| 29 | 29 | }  | 
                                                        
| 30 | 30 | |
| 31 | + /**  | 
                                                        |
| 32 | + * @param boolean $request  | 
                                                        |
| 33 | + */  | 
                                                        |
| 31 | 34 | private function initRequest($request)  | 
                                                        
| 32 | 35 |      { | 
                                                        
| 33 | 36 |          if ($request) { | 
                                                        
@@ -37,6 +40,9 @@ discard block  | 
                                                    ||
| 37 | 40 | return new RequestHttp();  | 
                                                        
| 38 | 41 | }  | 
                                                        
| 39 | 42 | |
| 43 | + /**  | 
                                                        |
| 44 | + * @param boolean $translator  | 
                                                        |
| 45 | + */  | 
                                                        |
| 40 | 46 | private function initTranslator($translator)  | 
                                                        
| 41 | 47 |      { | 
                                                        
| 42 | 48 |          if ($translator) { | 
                                                        
@@ -355,7 +355,7 @@  | 
                                                    ||
| 355 | 355 | // return array();  | 
                                                        
| 356 | 356 | // Logic Error - log types are still valid when no NEW logs are allowed for the cache.  | 
                                                        
| 357 | 357 | // (Would e.g. block admin logs and log-type restoring for locked caches.)  | 
                                                        
| 358 | - return get_cache_log_types($this->getCacheId(), $this->getType()); // depends on userid  | 
                                                        |
| 358 | + return get_cache_log_types($this->getCacheId(), $this->getType()); // depends on userid  | 
                                                        |
| 359 | 359 | }  | 
                                                        
| 360 | 360 | |
| 361 | 361 | public static function isDuplicate($cacheId, $userId, $logType, $logDate, $logText)  | 
                                                        
@@ -29,7 +29,7 @@ discard block  | 
                                                    ||
| 29 | 29 | // number of points in the polygon  | 
                                                        
| 30 | 30 | $n = count($polygon);  | 
                                                        
| 31 | 31 | $poly1 = $polygon[0];  | 
                                                        
| 32 | -        for ($i = 1; $i <= $n; $i ++) { | 
                                                        |
| 32 | +        for ($i = 1; $i <= $n; $i++) { | 
                                                        |
| 33 | 33 |              $poly1XY = explode(' ', $poly1); | 
                                                        
| 34 | 34 | $poly1x = $poly1XY[0];  | 
                                                        
| 35 | 35 | $poly1y = $poly1XY[1];  | 
                                                        
@@ -44,7 +44,7 @@ discard block  | 
                                                    ||
| 44 | 44 |                          if ($poly1y != $poly2y) { | 
                                                        
| 45 | 45 | $xinters = ($py - $poly1y) * ($poly2x - $poly1x) / ($poly2y - $poly1y) + $poly1x;  | 
                                                        
| 46 | 46 |                              if ($poly1x == $poly2x || $px <= $xinters) { | 
                                                        
| 47 | - $counter ++;  | 
                                                        |
| 47 | + $counter++;  | 
                                                        |
| 48 | 48 | }  | 
                                                        
| 49 | 49 | }  | 
                                                        
| 50 | 50 | }  | 
                                                        
@@ -59,7 +59,7 @@  | 
                                                    ||
| 59 | 59 | $to_page = min($last_page, max($first_page, $current_page - $lrspan) + $this->max_pages_shown - 1);  | 
                                                        
| 60 | 60 | $from_page = max($first_page, $to_page - $this->max_pages_shown + 1);  | 
                                                        
| 61 | 61 | |
| 62 | -            for ($page = $from_page; $page <= $to_page; $page ++) { | 
                                                        |
| 62 | +            for ($page = $from_page; $page <= $to_page; $page++) { | 
                                                        |
| 63 | 63 |                  if ($page == $current_page) { | 
                                                        
| 64 | 64 | $pages[$page] = false;  | 
                                                        
| 65 | 65 |                  } else { | 
                                                        
@@ -21,7 +21,7 @@ discard block  | 
                                                    ||
| 21 | 21 |       * Use {page} in link_url als placeholder for the selected page number | 
                                                        
| 22 | 22 |       * and/or {offset} for the 0-based data offset of the selected page. | 
                                                        
| 23 | 23 | *  | 
                                                        
| 24 | - * @param $link_url  | 
                                                        |
| 24 | + * @param string $link_url  | 
                                                        |
| 25 | 25 | * @param int $min_pages_shown  | 
                                                        
| 26 | 26 | * @param int $max_pages_shown  | 
                                                        
| 27 | 27 | */  | 
                                                        
@@ -38,8 +38,8 @@ discard block  | 
                                                    ||
| 38 | 38 | }  | 
                                                        
| 39 | 39 | |
| 40 | 40 | /**  | 
                                                        
| 41 | - * @param $current_page  | 
                                                        |
| 42 | - * @param $total_pages  | 
                                                        |
| 41 | + * @param double $current_page  | 
                                                        |
| 42 | + * @param double $total_pages  | 
                                                        |
| 43 | 43 | * @param bool $page_size  | 
                                                        
| 44 | 44 | */  | 
                                                        
| 45 | 45 | public function make_from_pagenr($current_page, $total_pages, $page_size = false)  | 
                                                        
@@ -110,7 +110,7 @@ discard block  | 
                                                    ||
| 110 | 110 | |
| 111 | 111 | /**  | 
                                                        
| 112 | 112 | * @param $page  | 
                                                        
| 113 | - * @param $page_size  | 
                                                        |
| 113 | + * @param boolean $page_size  | 
                                                        |
| 114 | 114 | *  | 
                                                        
| 115 | 115 | * @return string  | 
                                                        
| 116 | 116 | */  | 
                                                        
@@ -7,34 +7,34 @@  | 
                                                    ||
| 7 | 7 | * Common error messages  | 
                                                        
| 8 | 8 | ***************************************************************************/  | 
                                                        
| 9 | 9 | |
| 10 | - define('ERROR_UNKNOWN', 1000); | 
                                                        |
| 11 | - define('ERROR_TEMPLATE_NOT_FOUND', 1001); | 
                                                        |
| 12 | - define('ERROR_COMPILATION_FAILED', 1002); | 
                                                        |
| 13 | - define('ERROR_NO_ACCESS', 1003); | 
                                                        |
| 14 | - define('ERROR_INVALID_OPERATION', 1004); | 
                                                        |
| 15 | - define('ERROR_LOGIN_REQUIRED', 1005); | 
                                                        |
| 16 | - define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006); | 
                                                        |
| 17 | - define('ERROR_NO_COOKIES', 1007); | 
                                                        |
| 18 | - define('ERROR_ALREADY_LOGGEDIN', 1008); | 
                                                        |
| 19 | - define('ERROR_USER_NOT_ACTIVE', 1009); | 
                                                        |
| 20 | - define('ERROR_USER_NO_EMAIL', 1010); | 
                                                        |
| 21 | - define('ERROR_CACHE_NOT_PUBLISHED', 1011); | 
                                                        |
| 22 | - define('ERROR_CACHE_LOCKED', 1012); | 
                                                        |
| 10 | +    define('ERROR_UNKNOWN', 1000); | 
                                                        |
| 11 | +    define('ERROR_TEMPLATE_NOT_FOUND', 1001); | 
                                                        |
| 12 | +    define('ERROR_COMPILATION_FAILED', 1002); | 
                                                        |
| 13 | +    define('ERROR_NO_ACCESS', 1003); | 
                                                        |
| 14 | +    define('ERROR_INVALID_OPERATION', 1004); | 
                                                        |
| 15 | +    define('ERROR_LOGIN_REQUIRED', 1005); | 
                                                        |
| 16 | +    define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006); | 
                                                        |
| 17 | +    define('ERROR_NO_COOKIES', 1007); | 
                                                        |
| 18 | +    define('ERROR_ALREADY_LOGGEDIN', 1008); | 
                                                        |
| 19 | +    define('ERROR_USER_NOT_ACTIVE', 1009); | 
                                                        |
| 20 | +    define('ERROR_USER_NO_EMAIL', 1010); | 
                                                        |
| 21 | +    define('ERROR_CACHE_NOT_PUBLISHED', 1011); | 
                                                        |
| 22 | +    define('ERROR_CACHE_LOCKED', 1012); | 
                                                        |
| 23 | 23 | |
| 24 | - define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013); | 
                                                        |
| 25 | - define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014); | 
                                                        |
| 26 | - define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015); | 
                                                        |
| 24 | +    define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013); | 
                                                        |
| 25 | +    define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014); | 
                                                        |
| 26 | +    define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015); | 
                                                        |
| 27 | 27 | |
| 28 | - define('ERROR_DB_COULD_NOT_RECONNECT', 1016); | 
                                                        |
| 29 | - define('ERROR_DB_NO_ROOT', 1017); | 
                                                        |
| 28 | +    define('ERROR_DB_COULD_NOT_RECONNECT', 1016); | 
                                                        |
| 29 | +    define('ERROR_DB_NO_ROOT', 1017); | 
                                                        |
| 30 | 30 | |
| 31 | - define('ERROR_USER_NOT_EXISTS', 1018); | 
                                                        |
| 32 | - define('ERROR_CACHE_NOT_EXISTS', 1019); | 
                                                        |
| 33 | - define('ERROR_CACHELOG_NOT_EXISTS', 1020); | 
                                                        |
| 34 | - define('ERROR_PICTURE_NOT_EXISTS', 1021); | 
                                                        |
| 31 | +    define('ERROR_USER_NOT_EXISTS', 1018); | 
                                                        |
| 32 | +    define('ERROR_CACHE_NOT_EXISTS', 1019); | 
                                                        |
| 33 | +    define('ERROR_CACHELOG_NOT_EXISTS', 1020); | 
                                                        |
| 34 | +    define('ERROR_PICTURE_NOT_EXISTS', 1021); | 
                                                        |
| 35 | 35 | |
| 36 | - define('ERROR_UPLOAD_ERR_NO_FILE', 1022); | 
                                                        |
| 37 | - define('ERROR_UPLOAD_ERR_SIZE', 1023); | 
                                                        |
| 38 | - define('ERROR_UPLOAD_ERR_TYPE', 1024); | 
                                                        |
| 39 | - define('ERROR_UPLOAD_UNKNOWN', 1025); | 
                                                        |
| 40 | - define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026); | 
                                                        |
| 36 | +    define('ERROR_UPLOAD_ERR_NO_FILE', 1022); | 
                                                        |
| 37 | +    define('ERROR_UPLOAD_ERR_SIZE', 1023); | 
                                                        |
| 38 | +    define('ERROR_UPLOAD_ERR_TYPE', 1024); | 
                                                        |
| 39 | +    define('ERROR_UPLOAD_UNKNOWN', 1025); | 
                                                        |
| 40 | +    define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026); | 
                                                        |
@@ -74,7 +74,7 @@  | 
                                                    ||
| 74 | 74 | break;  | 
                                                        
| 75 | 75 | }  | 
                                                        
| 76 | 76 | $command['result'][] = $r;  | 
                                                        
| 77 | - $c ++;  | 
                                                        |
| 77 | + $c++;  | 
                                                        |
| 78 | 78 | }  | 
                                                        
| 79 | 79 | sql_free_result($rs);  | 
                                                        
| 80 | 80 | |
@@ -29,12 +29,12 @@  | 
                                                    ||
| 29 | 29 | }  | 
                                                        
| 30 | 30 | |
| 31 | 31 |  switch ($action) { | 
                                                        
| 32 | - case 'addignore':  | 
                                                        |
| 33 | -        sql("INSERT IGNORE INTO `cache_ignore` (`cache_id`, `user_id`) VALUES ('&1', '&2')", $cache_id, $login->userid); | 
                                                        |
| 34 | - break;  | 
                                                        |
| 35 | - case 'removeignore':  | 
                                                        |
| 36 | -        sql("DELETE FROM `cache_ignore` WHERE `cache_id`='&1' AND `user_id`='&2'", $cache_id, $login->userid); | 
                                                        |
| 37 | - break;  | 
                                                        |
| 32 | + case 'addignore':  | 
                                                        |
| 33 | +            sql("INSERT IGNORE INTO `cache_ignore` (`cache_id`, `user_id`) VALUES ('&1', '&2')", $cache_id, $login->userid); | 
                                                        |
| 34 | + break;  | 
                                                        |
| 35 | + case 'removeignore':  | 
                                                        |
| 36 | +            sql("DELETE FROM `cache_ignore` WHERE `cache_id`='&1' AND `user_id`='&2'", $cache_id, $login->userid); | 
                                                        |
| 37 | + break;  | 
                                                        |
| 38 | 38 | }  | 
                                                        
| 39 | 39 | |
| 40 | 40 | // clear cached map result, so that the change directly appears on the map  | 
                                                        
@@ -14,8 +14,7 @@  | 
                                                    ||
| 14 | 14 | $tpl->caching = true;  | 
                                                        
| 15 | 15 | $tpl->cache_lifetime = 3600;  | 
                                                        
| 16 | 16 | |
| 17 | -$country = isset($_REQUEST['usercountry']) ? $_REQUEST['usercountry'] :  | 
                                                        |
| 18 | - (isset($_REQUEST['country']) ? $_REQUEST['country'] : $opt['page']['main_country']);  | 
                                                        |
| 17 | +$country = isset($_REQUEST['usercountry']) ? $_REQUEST['usercountry'] : (isset($_REQUEST['country']) ? $_REQUEST['country'] : $opt['page']['main_country']);  | 
                                                        |
| 19 | 18 | |
| 20 | 19 |  if (!$tpl->is_cached()) { | 
                                                        
| 21 | 20 | $newCaches = array();  |