OpencachingDeutschland / oc-server3

htdocs/lib/clicompatbase.inc.php

Doc Comments +3 added lines, -3 removed lines

@@ -422,7 +422,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param $value
- * @return false|string
+ * @return string
  */
 function sql_escape($value)
 {
@@ -436,7 +436,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param $value
- * @return false|mixed|string
+ * @return string
  */
 function sql_escape_backtick($value)
 {
@@ -547,7 +547,7 @@ 
 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
- * @param $rs
+ * @param resource $rs
  * @return array
  */
 function sql_fetch_row($rs)

htdocs/lib2/db.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -1279,7 +1279,7 @@
 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
- * @param $f
+ * @param resource $f
  * @param resource $rs
  * @param $table
  * @param bool $truncate

htdocs/adminreports.php

Spacing +6 added lines, -6 removed lines

@@ -24,10 +24,10 @@ 
 /** @var Connection $connection */
 $connection = AppKernel::Container()->get(Connection::class);
 
-$id = (int) isset($_REQUEST['id']) ? $_REQUEST['id'] : 0;
-$rId = (int) isset($_REQUEST['rid']) ? $_REQUEST['rid'] : 0;
-$cacheId = (int) isset($_REQUEST['cacheid']) ? $_REQUEST['cacheid'] : 0;
-$ownerId = (int) isset($_REQUEST['ownerid']) ? $_REQUEST['ownerid'] : 0;
+$id = (int)isset($_REQUEST['id']) ? $_REQUEST['id'] : 0;
+$rId = (int)isset($_REQUEST['rid']) ? $_REQUEST['rid'] : 0;
+$cacheId = (int)isset($_REQUEST['cacheid']) ? $_REQUEST['cacheid'] : 0;
+$ownerId = (int)isset($_REQUEST['ownerid']) ? $_REQUEST['ownerid'] : 0;
 
 $reportData = $connection
     ->fetchAssoc(
@@ -37,8 +37,8 @@ 
         ['id' => $rId]
     );
 
-$reporterId = (int) $reportData['userid'];
-$adminId = (int) $reportData['adminid'];
+$reporterId = (int)$reportData['userid'];
+$adminId = (int)$reportData['adminid'];
 $age = $reportData['age'];
 
 if (isset($_REQUEST['savecomment'])) {

htdocs/lib2/login.class.php

Spacing +10 added lines, -10 removed lines

@@ -15,13 +15,13 @@ 
 
 use OcLegacy\Util\PasswordCrypt;
 
-define('LOGIN_UNKNOWN_ERROR', -1);     // unknown error occurred
-define('LOGIN_OK', 0);                 // login succeeded
-define('LOGIN_BADUSERPW', 1);          // bad username or password
-define('LOGIN_TOOMUCHLOGINS', 2);      // too many logins in short time
-define('LOGIN_USERNOTACTIVE', 3);      // the userAccount locked
+define('LOGIN_UNKNOWN_ERROR', -1); // unknown error occurred
+define('LOGIN_OK', 0); // login succeeded
+define('LOGIN_BADUSERPW', 1); // bad username or password
+define('LOGIN_TOOMUCHLOGINS', 2); // too many logins in short time
+define('LOGIN_USERNOTACTIVE', 3); // the userAccount locked
 define('LOGIN_EMPTY_USERPASSWORD', 4); // given username/password was empty
-define('LOGIN_LOGOUT_OK', 5);          // logout was successful
+define('LOGIN_LOGOUT_OK', 5); // logout was successful
 
 // login times in seconds
 define('LOGIN_TIME', 60 * 60);
@@ -69,7 +69,7 @@ 
 
         // TODO good input evaluation
         if ($cookie->is_set('userid') && $cookie->is_set('username')) {
-            $this->userid = (int) $cookie->get('userid');
+            $this->userid = (int)$cookie->get('userid');
             $this->username = $cookie->get('username');
             $this->permanent = (($cookie->get('permanent') + 0) == 1);
             $this->lastlogin = $cookie->get('lastlogin');
@@ -100,7 +100,7 @@ 
     public function pStoreCookie()
     {
         global $cookie;
-        $cookie->set('userid', (int) $this->userid);
+        $cookie->set('userid', (int)$this->userid);
         $cookie->set('username', $this->username);
         $cookie->set('permanent', ($this->permanent === true ? 1 : 0));
         $cookie->set('lastlogin', $this->lastlogin);
@@ -297,7 +297,7 @@ 
                     $rUser['user_id'],
                     ($permanent != false ? 1 : 0)
                 );
-                $this->userid = (int) $rUser['user_id'];
+                $this->userid = (int)$rUser['user_id'];
                 $this->username = $rUser['username'];
                 $this->permanent = $permanent;
                 $this->lastlogin = date('Y-m-d H:i:s');
@@ -343,7 +343,7 @@ 
             );
             if ($rUser = sql_fetch_assoc($rs)) {
                 $this->username = $rUser['username'];
-                $this->userid = (int) $rUser['user_id'];
+                $this->userid = (int)$rUser['user_id'];
                 $this->admin = $rUser['admin'];
                 $this->verified = true;
                 sqlf("UPDATE `user` SET `user`.`last_login`=NOW() WHERE `user`.`user_id`='&1'", $this->userid);