AbstractController::setContainer() - Code Metrics - Inspection of "Feature/symfony integration" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#346)

by Mirko

created 2016-06-07 21:40 UTC

AbstractController::setContainer() A

↳ Parent: AbstractController

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	11
rs	9.4285

<?php

namespace AppBundle\Controller;

use AppBundle\Legacy\Traits\LegacyTemplateTrait;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\DependencyInjection\ContainerInterface;

class AbstractController extends Controller
{
    use LegacyTemplateTrait;

    /**
     * Sets the container.
     *
     * There is no container available in the constructor of a controller, so we override setContainer() and use this
     *
     * @param \Symfony\Component\DependencyInjection\ContainerInterface|null $container A ContainerInterface instance or null.
     *
     * @return void
     */
    public function setContainer(ContainerInterface $container = null)
    {
        parent::setContainer($container);

        $requestStack = $container->get('request_stack');
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
        /** @var \Symfony\Component\HttpFoundation\Request $masterRequest */
        $masterRequest = $requestStack->getMasterRequest();
        if ($masterRequest) {
            $this->setTarget($masterRequest->getUri());
        }
    }

    /**
     * @param string $message
     *
     * @return void
     */
    protected function addErrorMessage($message)
    {
        $this->addFlash('error', $message);
    }

    /**
     * @param string $message
     *
     * @return void
     */
    protected function addSuccessMessage($message)
    {
        $this->addFlash('success', $message);
    }

    /**
     * @param string $message
     *
     * @return void
     */
    protected function addInfoMessage($message)
    {
        $this->addFlash('info', $message);
    }
}


1			<?php
2
3			namespace AppBundle\Controller;
4
5			use AppBundle\Legacy\Traits\LegacyTemplateTrait;
6			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7			use Symfony\Component\DependencyInjection\ContainerInterface;
8
9			class AbstractController extends Controller
10			{
11			use LegacyTemplateTrait;
12
13			/**
14			* Sets the container.
15			*
16			* There is no container available in the constructor of a controller, so we override setContainer() and use this
17			*
18			* @param \Symfony\Component\DependencyInjection\ContainerInterface\|null $container A ContainerInterface instance or null.
19			*
20			* @return void
21			*/
22			public function setContainer(ContainerInterface $container = null)
23			{
24			parent::setContainer($container);
25
26			$requestStack = $container->get('request_stack');
			0 ignored issues – show Bug introduced 2016-06-07 21:48 UTC by Report Bug Copy Issue Report It seems like `$container` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
27			/** @var \Symfony\Component\HttpFoundation\Request $masterRequest */
28			$masterRequest = $requestStack->getMasterRequest();
29			if ($masterRequest) {
30			$this->setTarget($masterRequest->getUri());
31			}
32			}
33
34			/**
35			* @param string $message
36			*
37			* @return void
38			*/
39			protected function addErrorMessage($message)
40			{
41			$this->addFlash('error', $message);
42			}
43
44			/**
45			* @param string $message
46			*
47			* @return void
48			*/
49			protected function addSuccessMessage($message)
50			{
51			$this->addFlash('success', $message);
52			}
53
54			/**
55			* @param string $message
56			*
57			* @return void
58			*/
59			protected function addInfoMessage($message)
60			{
61			$this->addFlash('info', $message);
62			}
63			}
64

OpencachingDeutschland / oc-server3

Pull Request — master (#346)

AbstractController::setContainer() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like