AppBundle\Controller\AbstractController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setContainer()	0	11	2
A	addErrorMessage()	0	4	1
A	addSuccessMessage()	0	4	1
A	addInfoMessage()	0	4	1

<?php

namespace AppBundle\Controller;

use AppBundle\Legacy\Traits\LegacyTemplateTrait;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\DependencyInjection\ContainerInterface;

class AbstractController extends Controller
{
    use LegacyTemplateTrait;

    /**
     * Sets the container.
     *
     * There is no container available in the constructor of a controller, so we override setContainer() and use this
     *
     * @param \Symfony\Component\DependencyInjection\ContainerInterface|null $container A ContainerInterface instance or null.
     *
     * @return void
     */
    public function setContainer(ContainerInterface $container = null)
    {
        parent::setContainer($container);

        $requestStack = $container->get('request_stack');

It seems like $container is not always an object, but can also be of type null. Maybe add an additional type check?

        /** @var \Symfony\Component\HttpFoundation\Request $masterRequest */
        $masterRequest = $requestStack->getMasterRequest();
        if ($masterRequest) {
            $this->setTarget($masterRequest->getUri());
        }
    }

    /**
     * @param string $message
     *
     * @return void
     */
    protected function addErrorMessage($message)
    {
        $this->addFlash('error', $message);
    }

    /**
     * @param string $message
     *
     * @return void
     */
    protected function addSuccessMessage($message)
    {
        $this->addFlash('success', $message);
    }

    /**
     * @param string $message
     *
     * @return void
     */
    protected function addInfoMessage($message)
    {
        $this->addFlash('info', $message);
    }
}