Inspection of "Merge pull request #867 from fraggle-DE/OCC-135_ad..." - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( ffe605...8efd8c )

by Thomas

created 2022-04-04 18:58 UTC

Status

Indentation +67 added lines, -67 removed lines patch added patch discarded remove patch

@@ -186,9 +186,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/searchedCaches.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'foundCaches' => $fetchedCaches
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'foundCaches' => $fetchedCaches
+                                                        ]
         );
     }
 
@@ -209,9 +209,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/reportedCaches.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'reportedCaches_by_id' => $fetchedReports
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'reportedCaches_by_id' => $fetchedReports
+                                                        ]
         );
     }
 
@@ -231,10 +231,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCaches.html.twig', [
-                                                       'supportCachesForm' => $formSearch->createView(),
-                                                       'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
-                                                       'bonusCaches_by_id' => $fetchedBonuscaches
-                                                   ]
+                                                        'supportCachesForm' => $formSearch->createView(),
+                                                        'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
+                                                        'bonusCaches_by_id' => $fetchedBonuscaches
+                                                    ]
         );
     }
 
@@ -256,10 +256,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCachesAssignment.html.twig', [
-                                                                 'supportCachesForm' => $formSearch->createView(),
-                                                                 'bonus_Cache' => $wpID,
-                                                                 'caches_by_owner' => $fetchedOwnerCaches
-                                                             ]
+                                                                    'supportCachesForm' => $formSearch->createView(),
+                                                                    'bonus_Cache' => $wpID,
+                                                                    'caches_by_owner' => $fetchedOwnerCaches
+                                                                ]
         );
     }
 
@@ -286,10 +286,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCachesAssignment.html.twig', [
-                                                                 'supportCachesForm' => $formSearch->createView(),
-                                                                 'bonus_Cache' => $toBonusCache,
-                                                                 'caches_by_owner' => $fetchedOwnerCaches
-                                                             ]
+                                                                    'supportCachesForm' => $formSearch->createView(),
+                                                                    'bonus_Cache' => $toBonusCache,
+                                                                    'caches_by_owner' => $fetchedOwnerCaches
+                                                                ]
         );
     }
 
@@ -397,10 +397,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'SQLFlexForm' => $formSQLFlex->createView(),
-                                                           'suppSQLqueryFlex' => $fetchedInformation
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'SQLFlexForm' => $formSQLFlex->createView(),
+                                                            'suppSQLqueryFlex' => $fetchedInformation
+                                                        ]
         );
     }
 
@@ -531,16 +531,16 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/occ.html.twig', [
-                                               'supportCachesForm' => $formSearch->createView(),
-                                               'supportCommentFormUser' => $formCommentUser->createView(),
-                                               'supportCommentFormCache' => $formCommentCache->createView(),
-                                               'occ_cache_data' => $fetchedCacheData,
-                                               'occ_cache_comments' => $fetchedCacheComments,
-                                               'occ_cache_infos' => $fetchedCacheInfos,
-                                               'occ_user_data' => $fetchedUserData,
-                                               'occ_user_comments' => $fetchedUserComments,
-                                               'occ_user_relations' => $fetchedUserRelations
-                                           ]
+                                                'supportCachesForm' => $formSearch->createView(),
+                                                'supportCommentFormUser' => $formCommentUser->createView(),
+                                                'supportCommentFormCache' => $formCommentCache->createView(),
+                                                'occ_cache_data' => $fetchedCacheData,
+                                                'occ_cache_comments' => $fetchedCacheComments,
+                                                'occ_cache_infos' => $fetchedCacheInfos,
+                                                'occ_user_data' => $fetchedUserData,
+                                                'occ_user_comments' => $fetchedUserComments,
+                                                'occ_user_relations' => $fetchedUserRelations
+                                            ]
         );
     }
 
@@ -669,10 +669,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/userDetails.html.twig', [
-                                                       'supportCachesForm' => $formSearch->createView(),
-                                                       'supportUserAccountActions' => $formActions->createView(),
-                                                       'user_account_details' => $fetchedUserDetails
-                                                   ]
+                                                        'supportCachesForm' => $formSearch->createView(),
+                                                        'supportUserAccountActions' => $formActions->createView(),
+                                                        'user_account_details' => $fetchedUserDetails
+                                                    ]
         );
     }
 
@@ -764,9 +764,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery1' => $qb->execute()->fetchAll()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery1' => $qb->execute()->fetchAll()
+                                                        ]
         );
     }
 
@@ -791,9 +791,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery2' => $qb->execute()->fetchAll()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery2' => $qb->execute()->fetchAll()
+                                                        ]
         );
     }
 
@@ -825,9 +825,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery4' => $qb->execute()->fetchAll()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery4' => $qb->execute()->fetchAll()
+                                                        ]
         );
     }
 
@@ -844,9 +844,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
+                                                        ]
         );
     }
 
@@ -889,9 +889,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery6' => $qb_caches_list
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery6' => $qb_caches_list
+                                                        ]
         );
     }
 
@@ -1004,15 +1004,15 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/occ_gpx_import.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'supportUploadGPXForm' => $formUpload->createView(),
-                                                          'amountProcessedCaches' => $amountProcessedCaches,
-                                                          'amountAssignedCaches' => $amountAssignedCaches,
-                                                          'amountUpdatedCaches' => $amountUpdatedCaches,
-                                                          'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
-                                                          'fetchedListingInfos' => $fetchedListingInfos,
-                                                          'differencesDetected' => $differencesDetected
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'supportUploadGPXForm' => $formUpload->createView(),
+                                                            'amountProcessedCaches' => $amountProcessedCaches,
+                                                            'amountAssignedCaches' => $amountAssignedCaches,
+                                                            'amountUpdatedCaches' => $amountUpdatedCaches,
+                                                            'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
+                                                            'fetchedListingInfos' => $fetchedListingInfos,
+                                                            'differencesDetected' => $differencesDetected
+                                                        ]
         );
     }
 
@@ -1065,7 +1065,7 @@  discard block
 block discarded – undo
 
             if ((($fetchedListingInfo->nodeListingAvailable == true) && ($fetchedOCCache->status != 1))
                 || (($fetchedListingInfo->nodeListingAvailable
-                     == false)
+                        == false)
                     && ($fetchedOCCache->status == 1))
             ) {
                 array_push($tempArray, 'OC status != import status');
@@ -1075,7 +1075,7 @@  discard block
 block discarded – undo
 
             if ((($fetchedListingInfo->nodeListingArchived == true) && ($fetchedOCCache->status != 3))
                 || (($fetchedListingInfo->nodeListingAvailable
-                     == false)
+                        == false)
                     && ($fetchedOCCache->status == 3))
             ) {
                 array_push($tempArray, 'OC status != import status');
@@ -1175,11 +1175,11 @@  discard block
 block discarded – undo
                     ] as $checkItem) {
                         if ($wpt[$checkItem] != $fetchedExistingSupportListingInfoArray[$checkItem]) {
                             $newComment .= $checkItem
-                                           . ' changed from '
-                                           . $fetchedExistingSupportListingInfoArray[$checkItem]
-                                           . ' to '
-                                           . $wpt[$checkItem]
-                                           . PHP_EOL;
+                                            . ' changed from '
+                                            . $fetchedExistingSupportListingInfoArray[$checkItem]
+                                            . ' to '
+                                            . $wpt[$checkItem]
+                                            . PHP_EOL;
                         }
                     }
 

Please login to merge, or discard this patch.

		@@ -186,9 +186,9 @@ discard block
		block discarded – undo
186	186
187	187	return $this->render(
188	188	'backend/support/searchedCaches.html.twig', [
189		- 'supportCachesForm' => $formSearch->createView(),
190		- 'foundCaches' => $fetchedCaches
191		- ]
	189	+ 'supportCachesForm' => $formSearch->createView(),
	190	+ 'foundCaches' => $fetchedCaches
	191	+ ]
192	192	);
193	193	}
194	194
		@@ -209,9 +209,9 @@ discard block
		block discarded – undo
209	209
210	210	return $this->render(
211	211	'backend/support/reportedCaches.html.twig', [
212		- 'supportCachesForm' => $formSearch->createView(),
213		- 'reportedCaches_by_id' => $fetchedReports
214		- ]
	212	+ 'supportCachesForm' => $formSearch->createView(),
	213	+ 'reportedCaches_by_id' => $fetchedReports
	214	+ ]
215	215	);
216	216	}
217	217
		@@ -231,10 +231,10 @@ discard block
		block discarded – undo
231	231
232	232	return $this->render(
233	233	'backend/support/bonusCaches.html.twig', [
234		- 'supportCachesForm' => $formSearch->createView(),
235		- 'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
236		- 'bonusCaches_by_id' => $fetchedBonuscaches
237		- ]
	234	+ 'supportCachesForm' => $formSearch->createView(),
	235	+ 'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
	236	+ 'bonusCaches_by_id' => $fetchedBonuscaches
	237	+ ]
238	238	);
239	239	}
240	240
		@@ -256,10 +256,10 @@ discard block
		block discarded – undo
256	256
257	257	return $this->render(
258	258	'backend/support/bonusCachesAssignment.html.twig', [
259		- 'supportCachesForm' => $formSearch->createView(),
260		- 'bonus_Cache' => $wpID,
261		- 'caches_by_owner' => $fetchedOwnerCaches
262		- ]
	259	+ 'supportCachesForm' => $formSearch->createView(),
	260	+ 'bonus_Cache' => $wpID,
	261	+ 'caches_by_owner' => $fetchedOwnerCaches
	262	+ ]
263	263	);
264	264	}
265	265
		@@ -286,10 +286,10 @@ discard block
		block discarded – undo
286	286
287	287	return $this->render(
288	288	'backend/support/bonusCachesAssignment.html.twig', [
289		- 'supportCachesForm' => $formSearch->createView(),
290		- 'bonus_Cache' => $toBonusCache,
291		- 'caches_by_owner' => $fetchedOwnerCaches
292		- ]
	289	+ 'supportCachesForm' => $formSearch->createView(),
	290	+ 'bonus_Cache' => $toBonusCache,
	291	+ 'caches_by_owner' => $fetchedOwnerCaches
	292	+ ]
293	293	);
294	294	}
295	295
		@@ -397,10 +397,10 @@ discard block
		block discarded – undo
397	397
398	398	return $this->render(
399	399	'backend/support/databaseQueries.html.twig', [
400		- 'supportCachesForm' => $formSearch->createView(),
401		- 'SQLFlexForm' => $formSQLFlex->createView(),
402		- 'suppSQLqueryFlex' => $fetchedInformation
403		- ]
	400	+ 'supportCachesForm' => $formSearch->createView(),
	401	+ 'SQLFlexForm' => $formSQLFlex->createView(),
	402	+ 'suppSQLqueryFlex' => $fetchedInformation
	403	+ ]
404	404	);
405	405	}
406	406
		@@ -531,16 +531,16 @@ discard block
		block discarded – undo
531	531
532	532	return $this->render(
533	533	'backend/support/occ.html.twig', [
534		- 'supportCachesForm' => $formSearch->createView(),
535		- 'supportCommentFormUser' => $formCommentUser->createView(),
536		- 'supportCommentFormCache' => $formCommentCache->createView(),
537		- 'occ_cache_data' => $fetchedCacheData,
538		- 'occ_cache_comments' => $fetchedCacheComments,
539		- 'occ_cache_infos' => $fetchedCacheInfos,
540		- 'occ_user_data' => $fetchedUserData,
541		- 'occ_user_comments' => $fetchedUserComments,
542		- 'occ_user_relations' => $fetchedUserRelations
543		- ]
	534	+ 'supportCachesForm' => $formSearch->createView(),
	535	+ 'supportCommentFormUser' => $formCommentUser->createView(),
	536	+ 'supportCommentFormCache' => $formCommentCache->createView(),
	537	+ 'occ_cache_data' => $fetchedCacheData,
	538	+ 'occ_cache_comments' => $fetchedCacheComments,
	539	+ 'occ_cache_infos' => $fetchedCacheInfos,
	540	+ 'occ_user_data' => $fetchedUserData,
	541	+ 'occ_user_comments' => $fetchedUserComments,
	542	+ 'occ_user_relations' => $fetchedUserRelations
	543	+ ]
544	544	);
545	545	}
546	546
		@@ -669,10 +669,10 @@ discard block
		block discarded – undo
669	669
670	670	return $this->render(
671	671	'backend/support/userDetails.html.twig', [
672		- 'supportCachesForm' => $formSearch->createView(),
673		- 'supportUserAccountActions' => $formActions->createView(),
674		- 'user_account_details' => $fetchedUserDetails
675		- ]
	672	+ 'supportCachesForm' => $formSearch->createView(),
	673	+ 'supportUserAccountActions' => $formActions->createView(),
	674	+ 'user_account_details' => $fetchedUserDetails
	675	+ ]
676	676	);
677	677	}
678	678
		@@ -764,9 +764,9 @@ discard block
		block discarded – undo
764	764
765	765	return $this->render(
766	766	'backend/support/databaseQueries.html.twig', [
767		- 'supportCachesForm' => $formSearch->createView(),
768		- 'suppSQLquery1' => $qb->execute()->fetchAll()
769		- ]
	767	+ 'supportCachesForm' => $formSearch->createView(),
	768	+ 'suppSQLquery1' => $qb->execute()->fetchAll()
	769	+ ]
770	770	);
771	771	}
772	772
		@@ -791,9 +791,9 @@ discard block
		block discarded – undo
791	791
792	792	return $this->render(
793	793	'backend/support/databaseQueries.html.twig', [
794		- 'supportCachesForm' => $formSearch->createView(),
795		- 'suppSQLquery2' => $qb->execute()->fetchAll()
796		- ]
	794	+ 'supportCachesForm' => $formSearch->createView(),
	795	+ 'suppSQLquery2' => $qb->execute()->fetchAll()
	796	+ ]
797	797	);
798	798	}
799	799
		@@ -825,9 +825,9 @@ discard block
		block discarded – undo
825	825
826	826	return $this->render(
827	827	'backend/support/databaseQueries.html.twig', [
828		- 'supportCachesForm' => $formSearch->createView(),
829		- 'suppSQLquery4' => $qb->execute()->fetchAll()
830		- ]
	828	+ 'supportCachesForm' => $formSearch->createView(),
	829	+ 'suppSQLquery4' => $qb->execute()->fetchAll()
	830	+ ]
831	831	);
832	832	}
833	833
		@@ -844,9 +844,9 @@ discard block
		block discarded – undo
844	844
845	845	return $this->render(
846	846	'backend/support/databaseQueries.html.twig', [
847		- 'supportCachesForm' => $formSearch->createView(),
848		- 'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
849		- ]
	847	+ 'supportCachesForm' => $formSearch->createView(),
	848	+ 'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
	849	+ ]
850	850	);
851	851	}
852	852
		@@ -889,9 +889,9 @@ discard block
		block discarded – undo
889	889
890	890	return $this->render(
891	891	'backend/support/databaseQueries.html.twig', [
892		- 'supportCachesForm' => $formSearch->createView(),
893		- 'suppSQLquery6' => $qb_caches_list
894		- ]
	892	+ 'supportCachesForm' => $formSearch->createView(),
	893	+ 'suppSQLquery6' => $qb_caches_list
	894	+ ]
895	895	);
896	896	}
897	897
		@@ -1004,15 +1004,15 @@ discard block
		block discarded – undo
1004	1004
1005	1005	return $this->render(
1006	1006	'backend/support/occ_gpx_import.html.twig', [
1007		- 'supportCachesForm' => $formSearch->createView(),
1008		- 'supportUploadGPXForm' => $formUpload->createView(),
1009		- 'amountProcessedCaches' => $amountProcessedCaches,
1010		- 'amountAssignedCaches' => $amountAssignedCaches,
1011		- 'amountUpdatedCaches' => $amountUpdatedCaches,
1012		- 'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
1013		- 'fetchedListingInfos' => $fetchedListingInfos,
1014		- 'differencesDetected' => $differencesDetected
1015		- ]
	1007	+ 'supportCachesForm' => $formSearch->createView(),
	1008	+ 'supportUploadGPXForm' => $formUpload->createView(),
	1009	+ 'amountProcessedCaches' => $amountProcessedCaches,
	1010	+ 'amountAssignedCaches' => $amountAssignedCaches,
	1011	+ 'amountUpdatedCaches' => $amountUpdatedCaches,
	1012	+ 'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
	1013	+ 'fetchedListingInfos' => $fetchedListingInfos,
	1014	+ 'differencesDetected' => $differencesDetected
	1015	+ ]
1016	1016	);
1017	1017	}
1018	1018
		@@ -1065,7 +1065,7 @@ discard block
		block discarded – undo
1065	1065
1066	1066	if ((($fetchedListingInfo->nodeListingAvailable == true) && ($fetchedOCCache->status != 1))
1067	1067	\|\| (($fetchedListingInfo->nodeListingAvailable
1068		- == false)
	1068	+ == false)
1069	1069	&& ($fetchedOCCache->status == 1))
1070	1070	) {
1071	1071	array_push($tempArray, 'OC status != import status');
		@@ -1075,7 +1075,7 @@ discard block
		block discarded – undo
1075	1075
1076	1076	if ((($fetchedListingInfo->nodeListingArchived == true) && ($fetchedOCCache->status != 3))
1077	1077	\|\| (($fetchedListingInfo->nodeListingAvailable
1078		- == false)
	1078	+ == false)
1079	1079	&& ($fetchedOCCache->status == 3))
1080	1080	) {
1081	1081	array_push($tempArray, 'OC status != import status');
		@@ -1175,11 +1175,11 @@ discard block
		block discarded – undo
1175	1175	] as $checkItem) {
1176	1176	if ($wpt[$checkItem] != $fetchedExistingSupportListingInfoArray[$checkItem]) {
1177	1177	$newComment .= $checkItem
1178		- . ' changed from '
1179		- . $fetchedExistingSupportListingInfoArray[$checkItem]
1180		- . ' to '
1181		- . $wpt[$checkItem]
1182		- . PHP_EOL;
	1178	+ . ' changed from '
	1179	+ . $fetchedExistingSupportListingInfoArray[$checkItem]
	1180	+ . ' to '
	1181	+ . $wpt[$checkItem]
	1182	+ . PHP_EOL;
1183	1183	}
1184	1184	}
1185	1185

OpencachingDeutschland / oc-server3

Push — development ( ffe605...8efd8c )

Status

Category

Indentation +67 added lines, -67 removed lines patch added patch discarded remove patch