OpenSkill / Datatable

src/OpenSkill/Datatable/Columns/ColumnOrder.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
     }
 
     /**
-     * @return bool
+     * @return string
      */
     public function isAscending()
     {

src/OpenSkill/Datatable/Datatable.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use OpenSkill\Datatable\Providers\Provider;
 use OpenSkill\Datatable\Versions\VersionEngine;
 use OpenSkill\Datatable\Views\DatatableView;
-use Symfony\Component\VarDumper\Cloner\Data;
 
 /**
  * Class Datatable

Indentation +1 added lines, -1 removed lines

@@ -55,6 +55,6 @@
      * @return DatatableView the view to work with
      */
     public function view($view = null) {
-       return new DatatableView($view, $this->versionEngine->getVersion());
+        return new DatatableView($view, $this->versionEngine->getVersion());
     }
 }
\ No newline at end of file

src/OpenSkill/Datatable/Queries/Parser/QueryParser.php

Unused Use Statements -2 removed lines

@@ -2,11 +2,9 @@
 
 namespace OpenSkill\Datatable\Queries\Parser;
 
-use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use OpenSkill\Datatable\Columns\ColumnConfiguration;
 use OpenSkill\Datatable\Queries\QueryConfiguration;
-use Symfony\Component\HttpFoundation\Response;
 
 /**
  * Interface DTQueryParser

src/OpenSkill/Datatable/Responses/Datatable19ResponseCreator.php

Doc Comments +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      * @param ResponseData $data The processed data.
      * @param QueryConfiguration $queryConfiguration the query configuration for the current request.
      * @param array $columnConfiguration the column configurations for the current data table.
-     * @return Response the response that should be returned to the client.
+     * @return JsonResponse the response that should be returned to the client.
      */
     public function createResponse(ResponseData $data, QueryConfiguration $queryConfiguration, array $columnConfiguration)
     {

src/OpenSkill/Datatable/Views/DatatableView.php

Doc Comments +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      * DatatableView constructor, will take a view as a string if a custom one should be used. will also take the
      * column configurations to provide out of the box headers for the view.
      * If no columns are given the user must provide them before building the view.
-     * @param array $columnConfiguration The columnConfiguration of the the server side if available
+     * @param string|null $columnConfiguration The columnConfiguration of the the server side if available
      * @param Version $version The version that supports the current request
      * @param string $view the name of the view that should be rendered
      */

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
      * Will render the table
      */
     public function table() {
-        if(empty($this->columnConfigurations)) {
+        if (empty($this->columnConfigurations)) {
             throw new \InvalidArgumentException("There are no columns defined");
         }
     }
@@ -52,7 +52,7 @@ 
      * Will render the javascript for the table
      */
     public function script() {
-        if(empty($this->columnConfigurations)) {
+        if (empty($this->columnConfigurations)) {
             throw new \InvalidArgumentException("There are no columns defined");
         }
     }

src/OpenSkill/Datatable/DatatableServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 
         $this->app->tag(['DT19Version', 'dt.default.version'], 'dt.query.versions');
 
-        $this->app->singleton("datatable", function (Application $app) {
+        $this->app->singleton("datatable", function(Application $app) {
             return new Datatable(
                 $app->make('request'),
                 new VersionEngine($app->tagged('dt.query.versions'))

src/OpenSkill/Datatable/Providers/CollectionProvider.php

Spacing +6 added lines, -6 removed lines

@@ -55,7 +55,7 @@ 
         $this->collection = $collection;
         $this->totalInitialDataCount = $collection->count();
         // define search functions
-        $this->globalSearchFunction = function ($data, $search) {
+        $this->globalSearchFunction = function($data, $search) {
             foreach ($data as $item) {
                 if (str_contains(mb_strtolower($item), mb_strtolower($search))) {
                     return true;
@@ -82,7 +82,7 @@ 
         // generate a custom search function for each column
         foreach ($this->columnConfiguration as $col) {
             if (!array_key_exists($col->getName(), $this->columnSearchFunction)) {
-                $this->columnSearchFunction[$col->getName()] = function ($data, ColumnSearch $search) use ($col) {
+                $this->columnSearchFunction[$col->getName()] = function($data, ColumnSearch $search) use ($col) {
                     if (str_contains(mb_strtolower($data[$col->getName()]), mb_strtolower($search->searchValue()))) {
                         return true;
                     }
@@ -137,7 +137,7 @@ 
             $searchFunc = $this->globalSearchFunction;
         }
 
-        $this->collection->transform(function ($data) use ($columnConfiguration, $searchFunc) {
+        $this->collection->transform(function($data) use ($columnConfiguration, $searchFunc) {
             $entry = [];
             // for each column call the callback
             foreach ($columnConfiguration as $i => $col) {
@@ -161,7 +161,7 @@ 
             return $entry;
         });
 
-        $this->collection = $this->collection->reject(function ($data) {
+        $this->collection = $this->collection->reject(function($data) {
             if (empty($data)) {
                 return true;
             } else {
@@ -203,10 +203,10 @@ 
     {
         if ($this->queryConfiguration->hasOrderColumn()) {
             $order = $this->queryConfiguration->orderColumns()[0];
-            $this->collection->sort(function ($first, $second) use ($order) {
+            $this->collection->sort(function($first, $second) use ($order) {
                 return strnatcmp($first[$order->columnName()], $second[$order->columnName()]);
             });
-            if(!$order->isAscending()) {
+            if (!$order->isAscending()) {
                 $this->collection->reverse();
             }
         }

src/OpenSkill/Datatable/Columns/ColumnConfigurationBuilder.php

Spacing +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
     {
         if (is_null($this->callable) || !is_callable($this->callable)) {
             $self = $this;
-            $this->callable = function ($data) use (&$self) {
+            $this->callable = function($data) use (&$self) {
                 $name = $self->name;
 
                 if (is_array($data) && array_key_exists($name, $data)) {

src/OpenSkill/Datatable/Composers/ColumnComposer.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
         if (!is_null($callable)) {
             if (is_callable($callable)) {
                 $config->withCallable($callable);
-            } elseif (is_string($callable)){
+            } elseif (is_string($callable)) {
                 $config->withCallable(function($data) use ($callable) { return $callable; });
             }
         }