Completed
Pull Request — master (#29)
by Tim
02:19
created
src/OpenSkill/Datatable/Providers/QueryBuilderProvider.php 2 patches
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -133,7 +133,6 @@  discard block
 block discarded – undo
133 133
     /**
134 134
      * Will compile the collection into the final collection where operations like search and order can be applied.
135 135
      *
136
-     * @param QueryBuilder $query
137 136
      * @param ColumnConfiguration[] $columnConfiguration
138 137
      * @return QueryBuilder
139 138
      * @throws DatatableException
@@ -150,7 +149,7 @@  discard block
 block discarded – undo
150 149
     /**
151 150
      * When a global (single) search has been done against data in the datatable.
152 151
      *
153
-     * @param array $columnConfiguration
152
+     * @param ColumnConfiguration[] $columnConfiguration
154 153
      * @return QueryBuilder
155 154
      * @throws DatatableException
156 155
      */
@@ -182,6 +181,9 @@  discard block
 block discarded – undo
182 181
         }
183 182
     }
184 183
 
184
+    /**
185
+     * @param string $searchValue
186
+     */
185 187
     private function createQueryForColumn(ColumnConfiguration $column, $searchValue)
186 188
     {
187 189
         $searchType = $column->getSearch();
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2,12 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace OpenSkill\Datatable\Providers;
4 4
 
5
-use Illuminate\Support\Collection;
6
-use Illuminate\Database\Eloquent\Builder;
7 5
 use Illuminate\Database\Query\Builder as QueryBuilder;
6
+use Illuminate\Support\Collection;
8 7
 use OpenSkill\Datatable\Columns\ColumnConfiguration;
9
-use OpenSkill\Datatable\Columns\ColumnOrder;
10
-use OpenSkill\Datatable\Columns\ColumnSearch;
11 8
 use OpenSkill\Datatable\Columns\Searchable\DefaultSearchable;
12 9
 use OpenSkill\Datatable\Data\ResponseData;
13 10
 use OpenSkill\Datatable\DatatableException;
Please login to merge, or discard this patch.