Completed
Push — feature/use-flashed-for-error-... ( da6479 )
by Michiel
03:10
created
SelfServiceBundle/Security/Authentication/Token/SamlToken.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /**
38 38
      * Returns the user credentials.
39 39
      *
40
-     * @return mixed The user credentials
40
+     * @return string The user credentials
41 41
      */
42 42
     public function getCredentials()
43 43
     {
Please login to merge, or discard this patch.
SelfServiceBundle/Service/U2fSecondFactor/ProofOfPossessionResult.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
         return new self;
59 59
     }
60 60
 
61
+    /**
62
+     * @param string $secondFactorId
63
+     */
61 64
     public static function secondFactorCreated($secondFactorId, RegistrationVerificationResult $u2fResult)
62 65
     {
63 66
         $result = new self;
Please login to merge, or discard this patch.
Security/Authentication/AuthenticatedSessionStateHandler.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -65,6 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
     /**
67 67
      * @param string $uri
68
+     * @return void
68 69
      */
69 70
     public function setCurrentRequestUri($uri);
70 71
 
@@ -76,6 +77,7 @@  discard block
 block discarded – undo
76 77
     /**
77 78
      * Migrates the current session to a new session id while maintaining all
78 79
      * session attributes.
80
+     * @return void
79 81
      */
80 82
     public function migrate();
81 83
 
@@ -84,6 +86,7 @@  discard block
 block discarded – undo
84 86
      *
85 87
      * Clears all session attributes and flashes and regenerates the
86 88
      * session and deletes the old session from persistence
89
+     * @return void
87 90
      */
88 91
     public function invalidate();
89 92
 }
Please login to merge, or discard this patch.
Security/Authentication/SamlAuthenticationStateHandler.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -27,6 +27,7 @@  discard block
 block discarded – undo
27 27
 
28 28
     /**
29 29
      * @param string $requestId
30
+     * @return void
30 31
      */
31 32
     public function setRequestId($requestId);
32 33
 
@@ -37,6 +38,7 @@  discard block
 block discarded – undo
37 38
 
38 39
     /**
39 40
      * Removes the requestId from the session
41
+     * @return void
40 42
      */
41 43
     public function clearRequestId();
42 44
 }
Please login to merge, or discard this patch.
StepupSelfService/SelfServiceBundle/Exception/AssertionFailedException.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -27,6 +27,11 @@
 block discarded – undo
27 27
     private $constraints;
28 28
 
29 29
     // @codingStandardsIgnoreStart Compliance with beberlei/assert's invalid argument exception
30
+
31
+    /**
32
+     * @param string $message
33
+     * @param integer $code
34
+     */
30 35
     public function __construct($message, $code, $propertyPath = null, $value, array $constraints = array())
31 36
     {
32 37
         parent::__construct($message, $code);
Please login to merge, or discard this patch.
Surfnet/StepupSelfService/SelfServiceBundle/Service/SecondFactorService.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,6 +129,11 @@  discard block
 block discarded – undo
129 129
                $vettedSecondFactors->getTotalItems() > 0;
130 130
     }
131 131
 
132
+    /**
133
+     * @param string $identityId
134
+     * @param string $state
135
+     * @param string $secondFactorId
136
+     */
132 137
     public function identityHasSecondFactorOfStateWithId($identityId, $state, $secondFactorId)
133 138
     {
134 139
         switch ($state) {
@@ -309,7 +314,7 @@  discard block
 block discarded – undo
309 314
     }
310 315
 
311 316
     /**
312
-     * @param $identity
317
+     * @param \Surfnet\StepupMiddlewareClientBundle\Identity\Dto\Identity $identity
313 318
      * @param $allSecondFactors
314 319
      * @param $allowedSecondFactors
315 320
      * @param $maximumNumberOfRegistrations
Please login to merge, or discard this patch.
DependencyInjection/SurfnetStepupSelfServiceSamlStepupProviderExtension.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -49,6 +49,9 @@  discard block
 block discarded – undo
49 49
         }
50 50
     }
51 51
 
52
+    /**
53
+     * @param string $provider
54
+     */
52 55
     private function loadProviderConfiguration(
53 56
         $provider,
54 57
         array $configuration,
@@ -237,6 +240,9 @@  discard block
 block discarded – undo
237 240
         $container->setDefinition('gssp.provider.' . $provider . '.metadata.factory', $metadataFactory);
238 241
     }
239 242
 
243
+    /**
244
+     * @param string $provider
245
+     */
240 246
     private function createRouteConfig($provider, $routeName)
241 247
     {
242 248
         // In the future, we ought to wrap this in an object.
@@ -247,6 +253,9 @@  discard block
 block discarded – undo
247 253
         ];
248 254
     }
249 255
 
256
+    /**
257
+     * @param string $type
258
+     */
250 259
     private function validateDescriptions($descriptions, $appUrl, $provider, $type)
251 260
     {
252 261
         $regex ="/%%{$type}_link_start%%[a-zA-Z0-9 ]+%%{$type}_link_end%%/";
Please login to merge, or discard this patch.
src/Surfnet/StepupSelfService/SelfServiceBundle/Value/GsspToken.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
     }
68 68
 
69 69
     /**
70
-     * @return mixed
70
+     * @return string
71 71
      */
72 72
     public function getType()
73 73
     {
Please login to merge, or discard this patch.