Completed
Pull Request — develop (#95)
by Daan van
06:16 queued 03:27
created
DependencyInjection/SurfnetStepupSelfServiceSamlStepupProviderExtension.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@  discard block
 block discarded – undo
50 50
         }
51 51
     }
52 52
 
53
+    /**
54
+     * @param string $provider
55
+     */
53 56
     private function loadProviderConfiguration(
54 57
         $provider,
55 58
         array $configuration,
@@ -198,6 +201,9 @@  discard block
 block discarded – undo
198 201
         $container->setDefinition('gssp.provider.' . $provider . '.metadata.factory', $metadataFactory);
199 202
     }
200 203
 
204
+    /**
205
+     * @param string $provider
206
+     */
201 207
     private function createRouteConfig($provider, $routeName)
202 208
     {
203 209
         // In the future, we ought to wrap this in an object.
Please login to merge, or discard this patch.
SelfServiceBundle/Security/Authentication/Provider/SamlProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * @param  SamlToken $token
59
-     * @return TokenInterface|void
59
+     * @return SamlToken
60 60
      */
61 61
     public function authenticate(TokenInterface $token)
62 62
     {
Please login to merge, or discard this patch.
SelfServiceBundle/Security/Authentication/Token/SamlToken.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /**
38 38
      * Returns the user credentials.
39 39
      *
40
-     * @return mixed The user credentials
40
+     * @return string The user credentials
41 41
      */
42 42
     public function getCredentials()
43 43
     {
Please login to merge, or discard this patch.
Surfnet/StepupSelfService/SelfServiceBundle/Service/SecondFactorService.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -128,6 +128,11 @@
 block discarded – undo
128 128
                $vettedSecondFactors->getTotalItems() > 0;
129 129
     }
130 130
 
131
+    /**
132
+     * @param string $identityId
133
+     * @param string $state
134
+     * @param string $secondFactorId
135
+     */
131 136
     public function identityHasSecondFactorOfStateWithId($identityId, $state, $secondFactorId)
132 137
     {
133 138
         switch ($state) {
Please login to merge, or discard this patch.
SelfServiceBundle/Service/U2fSecondFactor/ProofOfPossessionResult.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
         return new self;
59 59
     }
60 60
 
61
+    /**
62
+     * @param string $secondFactorId
63
+     */
61 64
     public static function secondFactorCreated($secondFactorId, RegistrationVerificationResult $u2fResult)
62 65
     {
63 66
         $result = new self;
Please login to merge, or discard this patch.