Completed
Pull Request — develop (#225)
by
unknown
09:12 queued 07:20
created
StepupSelfService/SelfServiceBundle/Mock/RemoteVetting/MockGateway.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,6 @@  discard block
 block discarded – undo
141 141
     }
142 142
 
143 143
     /**
144
-     * @param string $samlRequest
145 144
      * @param string $fullRequestUri
146 145
      * @return SAML2AuthnRequest
147 146
      * @throws \Exception
@@ -343,7 +342,7 @@  discard block
 block discarded – undo
343 342
 
344 343
     /**
345 344
      * @param Assertion $assertion
346
-     * @param $authnContextClassRef
345
+     * @param string $authnContextClassRef
347 346
      */
348 347
     private function addAuthenticationStatementTo(Assertion $assertion, $authnContextClassRef)
349 348
     {
@@ -398,6 +397,9 @@  discard block
 block discarded – undo
398 397
         return $this->gatewayConfiguration->getIdentityProviderPublicKeyCertData();
399 398
     }
400 399
 
400
+    /**
401
+     * @param string $status
402
+     */
401 403
     private function isValidResponseStatus($status)
402 404
     {
403 405
         return in_array($status, [
@@ -408,6 +410,9 @@  discard block
 block discarded – undo
408 410
         ]);
409 411
     }
410 412
 
413
+    /**
414
+     * @param string $subStatus
415
+     */
411 416
     private function isValidResponseSubStatus($subStatus)
412 417
     {
413 418
         return in_array($subStatus, [
Please login to merge, or discard this patch.
Service/RemoteVetting/Encryption/IdentityWriterInterface.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -24,6 +24,7 @@
 block discarded – undo
24 24
      * Writes identity data to a data store. The data should be passed as a string.
25 25
      *
26 26
      * @param string $data
27
+     * @return void
27 28
      */
28 29
     public function write($data);
29 30
 }
Please login to merge, or discard this patch.
SelfServiceBundle/Service/RemoteVetting/State/RemoteVettingState.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -27,6 +27,7 @@
 block discarded – undo
27 27
 {
28 28
     /**
29 29
      * The entity can not contain state to be able to (de-)serialize session data
30
+     * @return void
30 31
      */
31 32
     public function __construct();
32 33
 
Please login to merge, or discard this patch.
Service/RemoteVetting/Encryption/IdentityFilesystemWriter.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -43,6 +43,9 @@
 block discarded – undo
43 43
         file_put_contents($fileName, $data."\n");
44 44
     }
45 45
 
46
+    /**
47
+     * @return string
48
+     */
46 49
     private function createFileName($location)
47 50
     {
48 51
         $fileName = uniqid('identity_', true);
Please login to merge, or discard this patch.
Service/RemoteVetting/Configuration/RemoteVettingConfiguration.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -76,6 +76,7 @@
 block discarded – undo
76 76
 
77 77
     /**
78 78
      * @param string
79
+     * @param string $name
79 80
      * @return array
80 81
      */
81 82
     public function getAttributeMapping($name)
Please login to merge, or discard this patch.
Service/RemoteVetting/Dto/RemoteVettingIdenityProviderDto.php 1 patch
Doc Comments   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -63,8 +63,6 @@  discard block
 block discarded – undo
63 63
     private $certificateFile;
64 64
 
65 65
     /**
66
-     * @param string $identityId
67
-     * @param string $secondFactorId
68 66
      * @return RemoteVettingIdenityProviderDto
69 67
      */
70 68
     public static function create(array $configData)
@@ -110,7 +108,7 @@  discard block
 block discarded – undo
110 108
     }
111 109
 
112 110
     /**
113
-     * @return string[]
111
+     * @return string
114 112
      */
115 113
     public function getDescription($lang)
116 114
     {
Please login to merge, or discard this patch.
SelfServiceBundle/Service/RemoteVetting/Encryption/IdentityData.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,8 +53,8 @@  discard block
 block discarded – undo
53 53
      * @param AttributeCollectionInterface $attributeCollectionAggregate
54 54
      * @param string $nameId
55 55
      * @param string $applicationVersion
56
-     * @param $institution
57
-     * @param $remoteVettingSource
56
+     * @param string $institution
57
+     * @param string $remoteVettingSource
58 58
      * @throws \Assert\AssertionFailedException
59 59
      */
60 60
     public function __construct(
@@ -76,6 +76,9 @@  discard block
 block discarded – undo
76 76
         $this->remoteVettingSource = $remoteVettingSource;
77 77
     }
78 78
 
79
+    /**
80
+     * @return string
81
+     */
79 82
     public function serialize()
80 83
     {
81 84
         return json_encode(
Please login to merge, or discard this patch.