Completed
Push — feature/upgrade-remote-vetting ( 883904 )
by
unknown
65:35
created
StepupSelfService/SelfServiceBundle/Mock/RemoteVetting/MockGateway.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,6 @@  discard block
 block discarded – undo
141 141
     }
142 142
 
143 143
     /**
144
-     * @param string $samlRequest
145 144
      * @param string $fullRequestUri
146 145
      * @return SAML2AuthnRequest
147 146
      * @throws \Exception
@@ -343,7 +342,7 @@  discard block
 block discarded – undo
343 342
 
344 343
     /**
345 344
      * @param Assertion $assertion
346
-     * @param $authnContextClassRef
345
+     * @param string $authnContextClassRef
347 346
      */
348 347
     private function addAuthenticationStatementTo(Assertion $assertion, $authnContextClassRef)
349 348
     {
@@ -398,6 +397,9 @@  discard block
 block discarded – undo
398 397
         return $this->gatewayConfiguration->getIdentityProviderPublicKeyCertData();
399 398
     }
400 399
 
400
+    /**
401
+     * @param string $status
402
+     */
401 403
     private function isValidResponseStatus($status)
402 404
     {
403 405
         return in_array($status, [
@@ -408,6 +410,9 @@  discard block
 block discarded – undo
408 410
         ]);
409 411
     }
410 412
 
413
+    /**
414
+     * @param string $subStatus
415
+     */
411 416
     private function isValidResponseSubStatus($subStatus)
412 417
     {
413 418
         return in_array($subStatus, [
Please login to merge, or discard this patch.
Service/RemoteVetting/Encryption/IdentityWriterInterface.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -24,6 +24,7 @@
 block discarded – undo
24 24
      * Writes identity data to a data store. The data should be passed as a string.
25 25
      *
26 26
      * @param string $data
27
+     * @return void
27 28
      */
28 29
     public function write($data);
29 30
 }
Please login to merge, or discard this patch.
SelfServiceBundle/Service/RemoteVetting/State/RemoteVettingState.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -27,6 +27,7 @@
 block discarded – undo
27 27
 {
28 28
     /**
29 29
      * The entity can not contain state to be able to (de-)serialize session data
30
+     * @return void
30 31
      */
31 32
     public function __construct();
32 33
 
Please login to merge, or discard this patch.
SelfServiceBundle/Service/RemoteVetting/AttributeMapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /**
38 38
      * @param string $identityProviderName
39 39
      * @param AttributeListDto $localAttributes
40
-     * @param AttributeListDto $externalAttributes
40
+     * @param AttributeListDto $remoteAttributes
41 41
      * @return AttributeMatchCollection
42 42
      * @throws InvalidRemoteVettingMappingException
43 43
      */
Please login to merge, or discard this patch.
SelfServiceBundle/Service/RemoteVetting/Dto/AttributeListDto.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@
 block discarded – undo
45 45
      */
46 46
     private $nameId;
47 47
 
48
+    /**
49
+     * @param string $nameId
50
+     */
48 51
     public function __construct(array $attributes, $nameId)
49 52
     {
50 53
         Assert::string($nameId, 'The $nameId in an AttributeListDto must be a string value');
Please login to merge, or discard this patch.
Service/RemoteVetting/Dto/RemoteVettingIdenityProviderDto.php 1 patch
Doc Comments   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -42,8 +42,6 @@  discard block
 block discarded – undo
42 42
     private $slug;
43 43
 
44 44
     /**
45
-     * @param string $identityId
46
-     * @param string $secondFactorId
47 45
      * @return RemoteVettingIdenityProviderDto
48 46
      */
49 47
     public static function create(array $configData)
@@ -74,7 +72,7 @@  discard block
 block discarded – undo
74 72
     }
75 73
 
76 74
     /**
77
-     * @return string[]
75
+     * @return string
78 76
      */
79 77
     public function getDescription($lang)
80 78
     {
Please login to merge, or discard this patch.