Completed
Pull Request — develop (#248)
by Tim
01:56
created
src/Surfnet/StepupRa/RaBundle/Service/VettingService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
     }
436 436
 
437 437
     /**
438
-     * @param $procedureId
438
+     * @param string $procedureId
439 439
      * @return bool|null
440 440
      * @throws UnknownVettingProcedureException
441 441
      */
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
     }
446 446
 
447 447
     /**
448
-     * @param $procedureId
448
+     * @param string $procedureId
449 449
      * @return string
450 450
      * @throws UnknownVettingProcedureException
451 451
      */
Please login to merge, or discard this patch.
src/Surfnet/StepupRa/RaBundle/Repository/VettingProcedureRepository.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -24,6 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     /**
26 26
      * @param VettingProcedure $vettingProcedure
27
+     * @return void
27 28
      */
28 29
     public function store(VettingProcedure $vettingProcedure): void;
29 30
 
Please login to merge, or discard this patch.
Surfnet/StepupRa/RaBundle/Security/Authentication/Provider/SamlProvider.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -123,6 +123,7 @@
 block discarded – undo
123 123
     }
124 124
 
125 125
     /**
126
+     * @param string $attribute
126 127
      * @return string[]
127 128
      */
128 129
     private function getSingleStringValue($attribute, AssertionAdapter $translatedAssertion): array
Please login to merge, or discard this patch.
Surfnet/StepupRa/RaBundle/Service/U2f/AuthenticationVerificationResult.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -81,6 +81,9 @@
 block discarded – undo
81 81
         return new self(self::STATUS_API_ERROR);
82 82
     }
83 83
 
84
+    /**
85
+     * @param string $status
86
+     */
84 87
     private function __construct($status): string
85 88
     {
86 89
         $this->status = $status;
Please login to merge, or discard this patch.