View GitHub Repository Stepup-Middleware

Schedule Inspection
Subscribe
Completed
Pull Request — feature/fine-grained-authoriza... (#246)
by
unknown
40:56 queued 21:52
created
Status
Category
Toggle Patches
src/Surfnet/Stepup/Identity/Entity/RegistrationAuthorityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -47,7 +47,7 @@
 
 block discarded – undo
47 47
48 48 
     /**
49 49 
      * @param Institution $institution
50 
-     * @return RegistrationAuthority
50 
+     * @return boolean
51 51 
      */
52 52 
     public function exists(Institution $institution)
53 53 
     {
Please login to merge, or discard this patch.
StepupMiddleware/ApiBundle/Identity/Repository/RaListingRepository.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -47,7 +47,7 @@  discard block
 
 block discarded – undo
47 47
48 48 
     /**
49 49 
      * @param IdentityId $identityId The RA's identity id.
50 
-     * @return null|RaListing
50 
+     * @return RaListing
51 51 
      */
52 52 
     public function findByIdentityId(IdentityId $identityId)
53 53 
     {
 
@@ -57,7 +57,7 @@  discard block
 
 block discarded – undo
57 57 
     /**
58 58 
      * @param IdentityId $identityId The RA's identity id.
59 59 
      * @param Institution $raInstitution
60 
-     * @return null|RaListing
60 
+     * @return RaListing
61 61 
      */
62 62 
     public function findByIdentityIdAndInstitution(IdentityId $identityId, Institution $raInstitution)
63 63 
     {
Please login to merge, or discard this patch.
src/Surfnet/Stepup/Identity/Entity/InstitutionCollection.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -49,7 +49,7 @@  discard block
 
 block discarded – undo
49 49
50 50 
     /**
51 51 
      * @param Institution $institution
52 
-     * @return Institution
52 
+     * @return InstitutionRole
53 53 
      */
54 54 
     public function get(Institution $institution)
55 55 
     {
 
@@ -58,7 +58,7 @@  discard block
 
 block discarded – undo
58 58
59 59 
     /**
60 60 
      * @param Institution $institution
61 
-     * @return Institution
61 
+     * @return boolean
62 62 
      */
63 63 
     public function exists(Institution $institution)
64 64 
     {
Please login to merge, or discard this patch.