Surfnet\StepupMiddleware\ApiBundle\Configuration\Service\InstitutionAuthorizationService

Complexity

Total Complexity

6

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	findAuthorizationsByRoleFor()	0	11	2
A	findAuthorizationsFor()	0	6	1
A	findSelectRaaInstitutionsFor()	0	11	2

<?php

/**
 * Copyright 2018 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Configuration\Service;

use Surfnet\Stepup\Configuration\Value\Institution;
use Surfnet\Stepup\Identity\Value\Institution as ValueInstitution;
use Surfnet\Stepup\Configuration\Value\InstitutionAuthorizationOption;
use Surfnet\Stepup\Configuration\Value\InstitutionRole;
use Surfnet\Stepup\Identity\Collection\InstitutionCollection;
use Surfnet\StepupMiddleware\ApiBundle\Configuration\Repository\InstitutionAuthorizationRepository;

class InstitutionAuthorizationService
{
    /**
     * @var InstitutionAuthorizationRepository
     */
    private $repository;

    /**
     * @param InstitutionAuthorizationRepository $repository
     */
    public function __construct(
        InstitutionAuthorizationRepository $repository
    ) {
        $this->repository = $repository;
    }

    /**
     * @param Institution $institution
     * @param InstitutionRole $role
     * @return InstitutionAuthorizationOption
     */
    public function findAuthorizationsByRoleFor(Institution $institution, InstitutionRole $role)
    {
        $authorizations = $this->repository->findAuthorizationOptionsForInstitutionByRole($institution, $role);

        $institutions = [];
        foreach ($authorizations as $authorization) {
            $institutions[] = $authorization->institutionRelation;
        }

        return InstitutionAuthorizationOption::fromInstitutions($role, $institution, $institutions);
    }

    /**
     * @param Institution $institution
     * @return InstitutionAuthorizationOptionMap
     */
    public function findAuthorizationsFor(Institution $institution)
    {
        $authorizations = $this->repository->findAuthorizationOptionsForInstitution($institution);

        return InstitutionAuthorizationOptionMap::fromInstitutionAuthorizations($institution, $authorizations);
    }


    /**
     * @param Institution $institution
     * @return InstitutionCollection
     */
    public function findSelectRaaInstitutionsFor(Institution $institution)
    {
        $authorizations = $this->repository->findSelectRaasForInstitution($institution, InstitutionRole::selectRaa());

        $institutions = new InstitutionCollection();
        foreach ($authorizations as $authorization) {
            $institutions[] = $institutions->add(new ValueInstitution($authorization->institution->getInstitution()));

Are you sure the assignment to $institutions[] is correct as $institutions->add(new \Surfnet\Stepup\Identity\Value\Institution($authorization->institution->getInstitution())) (which targets Surfnet\Stepup\Identity\Collection\InstitutionCollection::add()) seems to always return null.

        }

        return $institutions;
    }


}