Completed
Pull Request — develop (#304)
by Michiel
04:12 queued 01:57
created
Surfnet/StepupMiddleware/MiddlewareBundle/Service/TokenBootstrapService.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -78,8 +78,8 @@  discard block
 block discarded – undo
78 78
     }
79 79
 
80 80
     /**
81
-     * @param $identityId
82
-     * @param $tokenType
81
+     * @param string $identityId
82
+     * @param string $tokenType
83 83
      * @return UnverifiedSecondFactor|null
84 84
      */
85 85
     public function findUnverifiedToken($identityId, $tokenType)
@@ -90,8 +90,8 @@  discard block
 block discarded – undo
90 90
     }
91 91
 
92 92
     /**
93
-     * @param $identityId
94
-     * @param $tokenType
93
+     * @param string $identityId
94
+     * @param string $tokenType
95 95
      * @return VerifiedSecondFactor|null
96 96
      */
97 97
     public function findVerifiedToken($identityId, $tokenType)
Please login to merge, or discard this patch.
MiddlewareBundle/Console/Command/AbstractBootstrapCommand.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -93,6 +93,11 @@  discard block
 block discarded – undo
93 93
         return true;
94 94
     }
95 95
 
96
+    /**
97
+     * @param string $tokenType
98
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
99
+     * @param string $secondFactorId
100
+     */
96 101
     protected function vetSecondFactor($tokenType, $actorId, $identity, $secondFactorId, $verifiedSecondFactor, $phoneNumber)
97 102
     {
98 103
         $command = new VetSecondFactorCommand();
@@ -117,6 +122,9 @@  discard block
 block discarded – undo
117 122
         $this->enricher->setMetadata($metadata);
118 123
     }
119 124
 
125
+    /**
126
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
127
+     */
120 128
     protected function verifyEmail($identity, $unverifiedSecondFactor)
121 129
     {
122 130
         $command = new VerifyEmailCommand();
Please login to merge, or discard this patch.
MiddlewareBundle/Console/Command/BootstrapSmsSecondFactorCommand.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -137,6 +137,10 @@
 block discarded – undo
137 137
         );
138 138
     }
139 139
 
140
+    /**
141
+     * @param string $secondFactorId
142
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
143
+     */
140 144
     private function provePossession($secondFactorId, $identity, $phoneNumber)
141 145
     {
142 146
         $command = new ProvePhonePossessionCommand();
Please login to merge, or discard this patch.
MiddlewareBundle/Console/Command/BootstrapYubikeySecondFactorCommand.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -136,6 +136,10 @@
 block discarded – undo
136 136
         );
137 137
     }
138 138
 
139
+    /**
140
+     * @param string $secondFactorId
141
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
142
+     */
139 143
     private function provePossession($secondFactorId, $identity, $phoneNumber)
140 144
     {
141 145
         $command = new ProveYubikeyPossessionCommand();
Please login to merge, or discard this patch.