View GitHub Repository Stepup-Gateway

Schedule Inspection
Subscribe
Completed
Pull Request — develop (#93)
by Boy
03:04
created
Status
Category
Toggle Patches
StepupGateway/SecondFactorOnlyBundle/Service/LoaAliasLookupService.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -29,7 +29,6 @@  discard block
 
 block discarded – undo
29 29 
     private $loaAliases;
30 30
31 31 
     /**
32 
-     * @param array<string,string> $loaAuthnContextClassMapping
33 32 
      */
34 33 
     public function __construct(array $loaAliases)
35 34 
     {
 
@@ -55,7 +54,7 @@  discard block
 
 block discarded – undo
55 54
56 55 
     /**
57 56 
      * @param string $alias
58 
-     * @return string|bool
57 
+     * @return false|string
59 58 
      */
60 59 
     public function findLoaIdByAlias($alias)
61 60 
     {
 
@@ -71,7 +70,7 @@  discard block
 
 block discarded – undo
71 70
72 71 
     /**
73 72 
      * @param Loa $loa
74 
-     * @return string|bool
73 
+     * @return string|false
75 74 
      */
76 75 
     public function findAliasByLoa(Loa $loa)
77 76 
     {
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Saml/ResponseFactory.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch 
@@ -146,6 +146,7 @@
 
 block discarded – undo
146 146 
     /**
147 147 
      * @param SAML2_Assertion $assertion
148 148 
      * @param SAML2_Assertion $assertion
149 
+     * @param string $authnContextClassRef
149 150 
      */
150 151 
     private function addAuthenticationStatementTo(SAML2_Assertion $assertion, $authnContextClassRef)
151 152 
     {
Please login to merge, or discard this patch.