Completed
Pull Request — feature/acceptance-tests (#192)
by Michiel
01:51
created
tests/features/bootstrap/ServiceProviderContext.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -109,6 +109,9 @@
 block discarded – undo
109 109
         $this->registerIdp($entityId, false);
110 110
     }
111 111
 
112
+    /**
113
+     * @param boolean $sfoEnabled
114
+     */
112 115
     private function registerSp($entityId, $sfoEnabled)
113 116
     {
114 117
         $publicKeyLoader = new KeyLoader();
Please login to merge, or discard this patch.
tests/src/Repository/SamlEntityRepository.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -23,6 +23,10 @@  discard block
 block discarded – undo
23 23
         $this->connection = $connection;
24 24
     }
25 25
 
26
+    /**
27
+     * @param string $entityId
28
+     * @param string $certificate
29
+     */
26 30
     public function createSpIfNotExists($entityId, $certificate, $sfoEnabled = false)
27 31
     {
28 32
         // Does the SP exist?
@@ -81,6 +85,10 @@  discard block
 block discarded – undo
81 85
         }
82 86
     }
83 87
 
88
+    /**
89
+     * @param string $entityId
90
+     * @param string $certificate
91
+     */
84 92
     public function createIdpIfNotExists($entityId, $certificate)
85 93
     {
86 94
         // Does the SP exist?
Please login to merge, or discard this patch.
tests/src/Controller/IdentityProviderController.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -63,6 +63,7 @@  discard block
 block discarded – undo
63 63
     /**
64 64
      * @param string $destination
65 65
      * @param string $nameId
66
+     * @param string $requestId
66 67
      * @return Response
67 68
      */
68 69
     public function createResponse($destination, array $nameId, $requestId)
@@ -157,6 +158,9 @@  discard block
 block discarded – undo
157 158
         return $assertion;
158 159
     }
159 160
 
161
+    /**
162
+     * @param string $destination
163
+     */
160 164
     private function addSubjectConfirmationFor(Assertion $newAssertion, $destination, $requestId)
161 165
     {
162 166
         $confirmation = new SubjectConfirmation();
Please login to merge, or discard this patch.
Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -69,6 +69,9 @@  discard block
 block discarded – undo
69 69
         return $this->selectSecondFactorForVerificationAction(self::MODE_SFO);
70 70
     }
71 71
 
72
+    /**
73
+     * @param string $authenticationMode
74
+     */
72 75
     public function selectSecondFactorForVerificationAction($authenticationMode)
73 76
     {
74 77
         $this->supportsAuthenticationMode($authenticationMode);
@@ -398,7 +401,6 @@  discard block
 block discarded – undo
398 401
     /**
399 402
      * @Template
400 403
      * @param Request $request
401
-     * @param string $authenticationMode
402 404
      * @return array|Response
403 405
      */
404 406
     public function verifySmsSecondFactorAction(Request $request)
@@ -462,7 +464,6 @@  discard block
 block discarded – undo
462 464
     /**
463 465
      * @Template
464 466
      * @param Request $request
465
-     * @param string $authenticationMode
466 467
      * @return array|Response
467 468
      */
468 469
     public function verifySmsSecondFactorChallengeAction(Request $request)
@@ -586,7 +587,6 @@  discard block
 block discarded – undo
586 587
      * @Template("SurfnetStepupGatewayGatewayBundle:SecondFactor:initiateU2fAuthentication.html.twig")
587 588
      *
588 589
      * @param Request $request
589
-     * @param string $authenticationMode
590 590
      * @return array|Response
591 591
      */
592 592
     public function verifyU2fAuthenticationAction(Request $request)
Please login to merge, or discard this patch.