OpenConext / Stepup-Gateway

src/Surfnet/StepupGateway/SamlStepupProviderBundle/DependencyInjection/SurfnetStepupGatewaySamlStepupProviderExtension.php

Doc Comments +6 added lines

@@ -53,6 +53,9 @@ 
         }
     }
 
+    /**
+     * @param string $provider
+     */
     private function loadProviderConfiguration(
         $provider,
         array $configuration,
@@ -223,6 +226,9 @@ 
         $container->setDefinition('gssp.provider.' . $provider . '.metadata.factory', $metadataFactory);
     }
 
+    /**
+     * @param string $provider
+     */
     private function createRouteConfig($provider, $routeName)
     {
         return [

src/Surfnet/StepupGateway/U2fVerificationBundle/Repository/RegistrationRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 {
     /**
      * @param KeyHandle $keyHandle
-     * @return Registration|null
+     * @return Registration
      */
     public function findByKeyHandle(KeyHandle $keyHandle)
     {

src/Surfnet/StepupGateway/U2fVerificationBundle/Service/VerificationService.php

Doc Comments +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
 
     /**
      * @param KeyHandle $keyHandle
-     * @return null|Registration
+     * @return Registration
      */
     public function findRegistrationByKeyHandle(KeyHandle $keyHandle)
     {

src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Adfs/StateHandler.php

Doc Comments +3 added lines, -3 removed lines

@@ -79,7 +79,7 @@ 
     }
 
     /**
-     * @return mixed|null
+     * @return string
      */
     public function getAuthMethod()
     {
@@ -87,7 +87,7 @@ 
     }
 
     /**
-     * @return mixed|null
+     * @return string
      */
     public function getContext()
     {
@@ -110,7 +110,7 @@ 
 
     /**
      * @param string $key
-     * @param mixed $value Any scalar
+     * @param string $value Any scalar
      */
     protected function set($key, $value)
     {

src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Saml/ResponseFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
 
     /**
      * @param Assertion $assertion
-     * @param $authnContextClassRef
+     * @param string $authnContextClassRef
      */
     private function addAuthenticationStatementTo(Assertion $assertion, $authnContextClassRef)
     {

src/Surfnet/StepupGateway/GatewayBundle/Exception/AssertionFailedException.php

Doc Comments +5 added lines

@@ -27,6 +27,11 @@
     private $constraints;
 
     // @codingStandardsIgnoreStart Compliance with beberlei/assert's invalid argument exception
+
+    /**
+     * @param string $message
+     * @param integer $code
+     */
     public function __construct($message, $code, $propertyPath = null, $value, array $constraints = array())
     {
         parent::__construct($message, $code);

src/Surfnet/StepupGateway/GatewayBundle/Entity/ServiceProvider.php

Doc Comments +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
      * it matches one of the configured allowed ACS locations for the service
      * provider. This methods checks if a given URL matches the allowed URLs.
      *
-     * @param $acsLocationInAuthnRequest
+     * @param string|null $acsLocationInAuthnRequest
      * @param LoggerInterface $logger Optional
      * @return string
      */
@@ -127,7 +127,7 @@ 
      *     https://example.com/consume
      *
      *
-     * @param $acsLocationInAuthnRequest
+     * @param string|null $acsLocationInAuthnRequest
      * @return string
      */
     public function determineAcsLocationForAdfs($acsLocationInAuthnRequest)

src/Surfnet/StepupGateway/SamlStepupProviderBundle/Controller/SamlProxyController.php

Doc Comments +1 added lines

@@ -260,6 +260,7 @@
      *
      * @param Provider $provider
      * @param string $destination
+     * @param string $message
      * @return SAMLResponse
      */
     private function createResponseFailureResponse(Provider $provider, $destination, $message)

tests/features/bootstrap/ServiceProviderContext.php

Doc Comments +3 added lines

@@ -109,6 +109,9 @@
         $this->registerIdp($entityId, false);
     }
 
+    /**
+     * @param boolean $sfoEnabled
+     */
     private function registerSp($entityId, $sfoEnabled)
     {
         $publicKeyLoader = new KeyLoader();